From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54FE73911C0 for ; Thu, 13 Aug 2026 17:36:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786642614; cv=none; b=W7X+tZ7UzVrQ4062iT0ne/0ZLEJlc5soGckpYF9fBatzTiZDwGKJgkmoTXRFlf9/sKJu4giFtyuHr738Nd3bIytXeW4BUvkVv1uzU54kFs7IHSiyynLj57MSK+sxhL1zrpBJVMu82VP7uzb/xbTfEroA1gKYK9P1b1PYGmzXo4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786642614; c=relaxed/simple; bh=BdVhuTOIb8CM1C0Z2pwcAVyjnRIeMMoFvnQIP2GWqE8=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=MnpKLtKCwfCxOOQnTJ+YWr1tEQZ8As8UFlTXrD258tZg9X79D+JwshvxNOUPk8kfcjQw5/4NH1PlmuhOPtPljctuiY0I4o/Rnn5JxKTZYx8Pkdn8d2C+S7eFgQ33ke/eaABf2KLyoYMCI+9p6hlfLGeWAy7cAPFhIx6g4UO0VLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Se/Yg64F; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Se/Yg64F" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47fe89fb333so41561f8f.3 for ; Thu, 13 Aug 2026 10:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786642611; x=1787247411; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ZcQJ8CDeUi2Xv2AodUPmyd0eqQd7G+WJbpf9TAChEp8=; b=Se/Yg64FKDh43hP9/phqdKgIKCox3OlaAvCy4vKB8C7cEYVAE1x9NQw9kbYU70fl0w b2qQEblKMgPs+jGlGrLm7Ei4ACLCu6Wik8h0rgGNQg62o+aSVrdLzoWwe6sSNjWjXkQY fkxLFepJVGAEA7AJNAvDG2tVCqWQMIz6l6zF3iAD1cR2omimPh87Rnqx9Nh4E4bw88Wv n5/w0KWroDWd2bGr1GzqBV7GeBoNuiGMZGVvvZI31l3V62yIP7mPoekhU6TMbjJ7BV2b 33BsKhXOn8gQ57dja++SpFUHyXfPiJE0dzs8987aoxBUGQKRkPTI04ENw1/w8LlAhYqu Ac0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786642611; x=1787247411; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZcQJ8CDeUi2Xv2AodUPmyd0eqQd7G+WJbpf9TAChEp8=; b=s2Mm8Cl9KN2Swyr31K6SIrsmV+bPL0ZsRK8Y/dGi2l+QBz5hXNkyhmoX/992+Tl9k1 QJRsR5onrtHcJAIo1CbnXPNxWrYfmAz0Uk9kkfF1iO9f/GMGhZyXegGUdmcHNinRQXf2 Th5IO6oEiIsItdCxOPRuwmv0AbG2XO3UfDtTRdPwyVAl5ma/ueGrSJxah/ZYjzpxwJza QJ0e6VtZ902/kfDXxxkz0qGyXzEKsluhzG8At/bm2mkgfOiT4TQBkL+10RGNz1irdomu ysaftkFow57nOCKm+NfN4LSX9XPhq+b52Z+QzKOt3FBaFCi/CU66BTbKp6dM9lIgy+gO xnjg== X-Forwarded-Encrypted: i=1; AHgh+Ronu65Gqh9yuPZVLXiqXuPJ3+WrPec4TOAkT3irpF8PxcUTuxn3BXp4viX09x0s8upn7qjDaUmPhqDwk04=@vger.kernel.org X-Gm-Message-State: AOJu0YzCzZKVPmVncfHj4dpd3YZHETw7tKDreO2mhcRpeWeceBVxHETZ nvwAdHTXMmtKPVWx/8Y2xqAs9iqxHrphJL3A25pHrpwe3Y6m7fMP4+lkuQ2bUA== X-Gm-Gg: AR+sD11gsQwt3fZnVx87SvJyhCoa/EoVC4XI9WgTCjXFt9+cu1beubs7H6b7bbI1KOP fb09dhp7u7AB0wwcb5L0WtnYo7axlRReo3anHsWCcu54lOENWxKAIgw2ktXfLMymfyN1RSlb14q rFBs2H01uv8qC/dXFy85b0MBijhp0AlHFi3b+T9ybm7bvbeJloZzvI2MqrN1QiN04/5rVMVYNvT QWxQF3MHrg2gCdke5dqJrlcnZc/AWVvKwFmoLKkBIHQeXBsjv+bHye8JCrfUR8MArRAYINqxgXX C+/eekIOOgl6sNPnl6mT6lDGqWPNk/RXp75SgTMzgV7tcMfJCyRAvFii40+trFYDKJlY/yJYuPE cmiX9PHAy1zaYlKkq6FpywltRbs2KtXt31L8xSgzoyEt3HEjtnSL5UnZJmvEQZ61ccZ4CTXnx5g kxSIQHyPiB7qpJA4LSpedRM/dlvjutKdyZN2v/lJUc4MdQV3h3qdGU0R12Jlnyppp2zZM/ViY3Q QbkGwwQyBt9ULhoO0KpfZ+R X-Received: by 2002:a05:6000:11c5:b0:47f:7b75:9dfe with SMTP id ffacd0b85a97d-48159cc03a1mr9333850f8f.8.1786642611456; Thu, 13 Aug 2026 10:36:51 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f1ffffdsm852124f8f.2.2026.08.13.10.36.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 10:36:51 -0700 (PDT) Date: Thu, 13 Aug 2026 20:36:50 +0300 From: Michail Tatas To: linusw@kernel.org, brgl@kernel.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] gpiolib: Put fwnode reference on failure Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline We get a reference to the fwnode handle which we pass to gpio_shared_make_ref. In case it fails we do not put the reference. Fix by putting the reference in the failure case Fixes: 49416483a953 ("gpio: shared: allow sharing a reset-gpios pin between reset-gpio and gpiolib") Cc: stable@vger.kernel.org Signed-off-by: Michail Tatas --- Changes in v2: - Added Cc and Fixes Tags based on the review from Bart Revisions: - v1: https://lore.kernel.org/all/anUA90ZcyYp9ka3E@michalis-linux/ drivers/gpio/gpiolib-shared.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpiolib-shared.c b/drivers/gpio/gpiolib-shared.c index 495bd3d0ddf0..5f9623e40b0f 100644 --- a/drivers/gpio/gpiolib-shared.c +++ b/drivers/gpio/gpiolib-shared.c @@ -261,10 +261,13 @@ static int gpio_shared_of_traverse(struct device_node *curr) con_id[con_id_len - suffix_len] = '\0'; } - ref = gpio_shared_make_ref(fwnode_handle_get(of_fwnode_handle(curr)), - con_id, args.args[1]); - if (!ref) + struct fwnode_handle *curr_fwnode = + fwnode_handle_get(of_fwnode_handle(curr)); + ref = gpio_shared_make_ref(curr_fwnode, con_id, args.args[1]); + if (!ref) { + fwnode_handle_put(curr_fwnode); return -ENOMEM; + } if (!list_empty(&entry->refs)) pr_debug("GPIO %u at %s is shared by multiple firmware nodes\n", -- 2.43.0