mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@oss.nxp.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Frank Li <Frank.Li@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: imx: Replace __ASSEMBLY__ with __ASSEMBLER__ in header file
Date: Thu, 13 Aug 2026 13:45:19 -0500	[thread overview]
Message-ID: <an4Qv6kA-hnbUYaA@SMW015318> (raw)
In-Reply-To: <b82da069-b76c-47f6-bf8e-f47701cb318e@redhat.com>

On Thu, Aug 13, 2026 at 09:35:38AM +0200, Thomas Huth wrote:
>
> On 19/06/2026 14.24, Thomas Huth wrote:
> > From: Thomas Huth <thuth@redhat.com>
> >
> > While the GCC and Clang compilers already define __ASSEMBLER__
> > automatically when compiling assembly code, __ASSEMBLY__ is a
> > macro that only gets defined by the Makefiles in the kernel.
> > This can be very confusing when switching between userspace
> > and kernelspace coding, or when dealing with uapi headers that
> > rather should use __ASSEMBLER__ instead. So let's standardize now
> > on the __ASSEMBLER__ macro that is provided by the compilers.
> >
> > This is a completely mechanical patch (done with a simple "sed -i"
> > statement).
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >   Note: This patch has been split from an earlier bigger patch of
> >   mine to ease reviewing.
> >
> >   include/soc/imx/cpu.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/soc/imx/cpu.h b/include/soc/imx/cpu.h
> > index 0bf610acafd06..8c53150acd76e 100644
> > --- a/include/soc/imx/cpu.h
> > +++ b/include/soc/imx/cpu.h
> > @@ -30,7 +30,7 @@
> >   #define MXC_CPU_VF600               0x600
> >   #define MXC_CPU_VF610               (MXC_CPU_VF600 | MXC_CPU_VFx10)
> >
> > -#ifndef __ASSEMBLY__
> > +#ifndef __ASSEMBLER__
> >   extern unsigned int __mxc_cpu_type;
> >   #endif
> >
>
> Friendly ping!
>
> Could anybody please pick this up? Thanks!

Sorry, I missed it. It is too late for 7.3.

Frank

>
>  Thomas
>
>

  reply	other threads:[~2026-08-13 18:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19 12:24 Thomas Huth
2026-08-13  7:35 ` Thomas Huth
2026-08-13 18:45   ` Frank Li [this message]
2026-08-31 14:46 ` Frank.Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an4Qv6kA-hnbUYaA@SMW015318 \
    --to=frank.li@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®