From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B32DF3B19BF for ; Thu, 13 Aug 2026 18:59:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786647570; cv=none; b=XAdnV3aOJ+H8iav29/fGZEeEo3sj8e4UHdQRMtlzcyUrAkWn6l6oI1kVyqgpzd/0Mwq/ZALDFvVT+Pol9V+9vhvb+NiYc5+13zjRyK4GLbLli/hg174DS4N7yOEfliMKtHGqbY6bobzIDhITzgh/2EcWxE1RLRodpj9Aag3C8r0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786647570; c=relaxed/simple; bh=lOnAaOaGVVFiK4mt8CBhfHxNuvToM4xuQKb07SccwKg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mXroDNGhxlrHrAYgkelhc1G8nxltHsa0znNarDSlRfXItDnNQhcZ3XVQwJEGDzCejybtTVTvi3eBgyR927gMIOteuJPyRM17XmtdSjIqS6rTCG5t0hoGA+H74z8rQn/g3qh56fGSdANE4O6pqjTLWGWdl6bWjrlgBFFfIlbw03g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I/UGeTz2; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I/UGeTz2" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47de0093c42so138354f8f.3 for ; Thu, 13 Aug 2026 11:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786647567; x=1787252367; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=uh/APiVl0POIqyc3Yw8orY55em9X0NLBdmnuLhihqeU=; b=I/UGeTz20vemduFDRMXcW6vq00Y7g/6c9EuAIuFbK1hw85612Hy3tr7WCLWt9bzKLx eU5H1EIUvTzF1PLfNDiiatbeSyg+xYxXtuKwq7tUMjxlTS2gkJhrp43/3xwEvsBOH+dL Za+s1ZJTAXm3K1Atpmvz7VgR+7pFqJmk1wbQKr/EbmR7nSv8Dm8GaQNZRX+86NprRTBs jysepDjbSNkXzDSlbMb5J2BlfFyeaLX+hMaZYd9nYji8A379DUG/sSDRYbAP0JExHRQe oibGqQvMALXEVuczLLiSJ9uZfDM+cfazLPyObVIEnsknNTA1/U+qYjHQFTuP19auM/U0 EoWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786647567; x=1787252367; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=uh/APiVl0POIqyc3Yw8orY55em9X0NLBdmnuLhihqeU=; b=nPQTR8OKshLF6A8LceFPtx7sVUjtFDoDxkx8RPrbbNZ5VedlkHFc29QYkPfAFeLP2w dqns42/48F5Wj25dN/Y3ynFR1lQLmkMIos7vsMIDkjJE9h+/YEgbzyjdEGyWmBadHXIG mL0ecPQw1y2d2Fo3EQSwvQs49uYOJaEPy+i+0S33xqG0PyYWwkso0FYM0Dws+KGJQJcq WQEwOe1vhqiL5V5GpBDYd/bSiDyJEWVtnlpfG+ZlSWTKDT04xQgjngTyhJOhQebq+LZh +Ep794XEU2mouJ0O0HQFFYMGclVb2alNsfmRCunEKbe3triA8uq/TXN8tHWpkZ8JVibO AAng== X-Forwarded-Encrypted: i=1; AHgh+RrpLzeNd+Ql/lH0F5YXo8DEPUhQwEthQTG0tivP+IH+betIJ936lxFakD8WvGAbJN20OBhtQm7pLWowzkM=@vger.kernel.org X-Gm-Message-State: AOJu0YxdXO92c7QSQj1AFrlvom4o6Fp0BjNbmlFV/8+lDpuGNvGvYPMd Up8WyYEP89odq0g6cr7f6ryZMCnEZr8b0+v2EBNWyqvJ4d73wRWWUzz2 X-Gm-Gg: AR+sD11dUWe1Au/9EGZmowTLDAHpLld793Ag+b/J/kYEdJN8Ss4yTng2ig4QZrJiN4H gdSQulU4PyDcOL66dCa0tPLLw1nvJ3K2Kb8V3SgTqq2b0jHepf5lVahVrImTI3V8k/CZQ97tujX pPh8Vj0fjvK+vm/gMHLERDdoxtg286ikvX0GtVj6lMPMUgPerJHevvZbTIk0HS9AkMQWMxJ1Yr7 zY0/zEueflqKTPqk3vKpBokZg2+jHTm/BdoFpgV8ui/Iu7ed9ECDAH18xhgy01frVbEzoqfKVb6 VG4uDrYSu1PUoiNq5t+mIAUrMFpaIJghy+Qhz0IdFmxZjZWE7vcRcPbQn3uhimwLquP/VZ3Xj4B xyoqQ4BD74kD8aTsAjKDdX7HiQn9g2UanyvXz/qSL5ZMvj5wZGDfLzok8EqIdEXjsU6t87Ifjcb s5xePNHyPEhT6Ewzlxvs0hMyfrcY7FRbOBsVriYGP9wiAqMdugZA73faSn X-Received: by 2002:adf:e744:0:b0:47f:81c4:36a5 with SMTP id ffacd0b85a97d-481607575e8mr426220f8f.15.1786647566850; Thu, 13 Aug 2026 11:59:26 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f21a31dsm1592554f8f.9.2026.08.13.11.59.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 11:59:26 -0700 (PDT) Date: Thu, 13 Aug 2026 21:59:22 +0300 From: Dan Carpenter To: Tomasz Unger Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: fix XXX placeholder in os_intfs.c comment Message-ID: References: <20260813-rtl8723bs-fix-xxx-placeholder-v2-v1-1-a9be805ac0e5.ref@yahoo.pl> <20260813-rtl8723bs-fix-xxx-placeholder-v2-v1-1-a9be805ac0e5@yahoo.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260813-rtl8723bs-fix-xxx-placeholder-v2-v1-1-a9be805ac0e5@yahoo.pl> On Thu, Aug 13, 2026 at 07:26:52PM +0200, Tomasz Unger wrote: > Replace the 'XXX' placeholder with 'securitypriv', the actual > field name referenced by the commented-out memset() call on the > following line. > > Using the real field name pushes the line past 100 columns, so > the comment is reflowed to multi-line style in the same change > to keep it clean. This combines a content fix with a formatting > change; I considered splitting it into two patches (content > first, reflow second) but felt the reflow is a direct and > unavoidable consequence of the content fix rather than an > unrelated cleanup. Happy to split into two patches if preferred. Put this kind of meta commentary under the --- cut off line > > Signed-off-by: Tomasz Unger > --- ^^^ here. > drivers/staging/rtl8723bs/os_dep/os_intfs.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > index f31196f54b3e..873e00a04bcb 100644 > --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c > +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c > @@ -664,7 +664,10 @@ u8 rtw_init_drv_sw(struct adapter *padapter) > /* add for CONFIG_IEEE80211W, none 11w also can use */ > spin_lock_init(&padapter->security_key_mutex); > > - /* We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */ > + /* > + * We don't need to memset padapter->securitypriv to zero, > + * because adapter is allocated by vzalloc(). > + */ > /* memset((unsigned char *)&padapter->securitypriv, 0, sizeof (struct security_priv)); */ Just delete the comment and the commented out code. regards, dan carpenter