From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74C1123BD02 for ; Fri, 14 Aug 2026 01:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786671494; cv=none; b=JUXZqBsNXkj86rexn+/WzSDdhVfWpPtIqmCFchdIPJ7CTP1LRhSuGdWO/iYZiHu9Xyjr1/2aNIyvmO9iV7sFr0VLgjpkWJFuOfq7BHVqTBpzWWlwD9uSoCpjeGAkh30HhdLgzlxRb55DDqnpD5v3SYc6xcl2SJ0svkyWhNc10Sg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786671494; c=relaxed/simple; bh=wH2BVX8rQi+9ZChgxotsL9mWq6mp/O3ySdn0wNdJCUc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F+QD4z+DM6Fd8IWfTJQwT4CEUnqglu42lRg9DVzxAfQux9Frck/7epk5h3Mfs2ayi3GpIYfdSLsnXbnZ10V5o2tid/tNMnMGpX2KDJXORLTePidOBVRc47ty3r38T1rZgi8N5M0RmsSRi5Ks0vm0M/f5eAzEzMmQdGGh8K583J0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RY5yG7wA; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RY5yG7wA" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cacf197759so8848145ad.2 for ; Thu, 13 Aug 2026 18:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786671493; x=1787276293; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wH2BVX8rQi+9ZChgxotsL9mWq6mp/O3ySdn0wNdJCUc=; b=RY5yG7wArEk7CuQX56iKBlWjiQs0LN5uzSvNel2XPb+ujlDn8yB9AeEtWuoV6kzxAi PHefbkJoczwMUAKlxMtkr3haogIH3r8vNbfy6K6ao5quZa4azTm/TnTEIOUdfH1Rr8L4 V62ZLW2zq4Cr2BCrxIWJd1jsoiWzNx3K3ik2MFNmXqpATqAE9Q6Ttuuv+Xdta6lvBDEt y2TgA73jLSbVlvFG3Zpgzal7rlIBJcHnMQxkkw+jLLuDP/duP4rP/38DOjYT7TdbvOW0 EmhxcIlHftDfrpmOTGUHlOag8Bnl39RB92yCtYgiC6iMu64G2WLmgk6chyoKCIDs7TeF UOfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786671493; x=1787276293; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wH2BVX8rQi+9ZChgxotsL9mWq6mp/O3ySdn0wNdJCUc=; b=dj3EjmI5niie2l1hj1v09/zU8yNHtaZOMaLWJj+KK62Xh1uGBXB2d4UPeKC3qEYvZp LrepHfMdktHMJv75O9ZHxtSrEbn38sIT2D2XHxGpPl9poIZ7NW8XahCvi3XERd+KGrsi Jopbtzwyt2UZrXoNVEB70aLW0ZyRPoaBEOKz2Pwou0JLm7nxWpq5XE2jd8PuqSGwYJmg g/wlxlgHWkMXoQTjndUVMI64MXqj9iPVKyXBnyiejBF69Ep32mrf98T9iROwjKGV3y0p 8PdVGqXLYS1VtzaSJYUrw/RKxdozavQxq6a2iLyFzdJ2cHdWGw8H+UeTlx+hQzEnvspL 1agw== X-Forwarded-Encrypted: i=1; AHgh+RoJwDUXbFVyjSKri/zTxwsd3HZH2cRPKVFo+ZHXbZ1cqeQ7YyWkP1AGb3WYDPk3NfqvUw5ozDbebwn5k6Y=@vger.kernel.org X-Gm-Message-State: AOJu0YySX0SCkAAcfMhvmC1NFsDbnZRq3BYOPwgHdpW0byhRs+ouv2J+ rRWaP9vBd5NK3ZHRwGglXDK+rvi84StI81L2Shc/tntMvINSqm0VaH+r X-Gm-Gg: AR+sD11kA8/sEl0Ux2IKa8zLa4lGDRbvOaUfGZDKI1sCuKn1iheN9NYP9oCXiljQM3w 8zTsQtrDU4fDQs487TbloxNw8tjf4l+KkW21BcJDMaURLuBxhyYHSVmhcezxq05wIcUgp9zoqEE HR3xsU3ePjF2dMdjd08SaiHaYMCemT7jHjGZDyGDYTvvIdOQrvYVGVO3yUu/XQ+b9ZGO5O6aWrE KlQStCx9K3mihu3KiJOcrCVaG4RbWkABXKvs5NhiHdH9bvK58zJdcDmxTMgZ7JXwHJpeU8pschJ stIKm4E70RclXR+ZDF68yqF9k7rlcC01k719IUQ7jxlcakJ1eSOX0ul0JPxXwB4CB2/iomyR6tX g1YLqaqKnnekEX0lZjFxND6CGLYO5HFvds2et/dNlFm0sfxfY6bWl9gmpG8LRvH3vU4jaW4iflp vw4g+Sxm4cwSkAC+4+M5CpxJP+4MRdZFdr7s1GdxU5EyjrgK54Hwy3QSuK8RNXgOALm1aTOkgGg ynY/tOmvLu4tD3uvgbAonEwU+0IJvy2jQ== X-Received: by 2002:a05:6a20:e613:b0:3cc:55ed:dbfa with SMTP id adf61e73a8af0-3cc71cd3ee1mr2390054637.27.1786671492726; Thu, 13 Aug 2026 18:38:12 -0700 (PDT) Received: from localhost (115-70-157-242.ip4.superloop.au. [115.70.157.242]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-141387accdbsm4104230c88.3.2026.08.13.18.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 18:38:12 -0700 (PDT) Date: Fri, 14 Aug 2026 11:37:59 +1000 From: Tsz Shan Chan To: Andy Shevchenko Cc: Jonathan Cameron , David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Tsz Shan Chan Subject: Re: [PATCH 2/2] iio: light: vcnl4000: add shared IRQ support Message-ID: References: <20260812044941.6f28cfb7@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 13, 2026 at 11:30:35AM +0300, Andy Shevchenko wrote: > I see, so why do we even bother with the _FALLING then? Make it trigger LOW > when it's not defined and always enable sharing. Makes sense. I'll clean up the checks and pass IRQF_TRIGGER_LOW directly. > You can't avoid possible regressions for the cases when firmware neglected to > set the trigger type completely. Thanks, understood. I'll update it and send v2.