From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66EB5421230 for ; Fri, 14 Aug 2026 07:43:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786693405; cv=none; b=r1gMfmhP1el75mlRw5lRVX8AcsYKPf48IjzilYuQdmWfLmWcbR7lWpyDmvOotGoxyxdwMsXUpqdRlvZiT7OxT4kRwB+Q1g3evGi7Noyx4ww0ebYODdqNzrG7EXE5TEPoHnKMRfl1ZqqBLajG0nZpL7o4Ef3n63UORSun4StHhWs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786693405; c=relaxed/simple; bh=LY6wGybHY87wN/sEHx1ZWlnOgi42U2OkAX47+zw0baM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UgVbgUdiK5GlPZmEeAQQJgaFZwyTKx1kOeU+exH6kPNVaqILyuTW6fEj1Z1LTTa7awBW0n31ToDN3tRYy2oHcJdLgMR0nJfV+gvIwM6cF6IlAzv4HQmAzcqaKmyxoUPrEWutCYfhNYnaklxRnG2P6CHdDKeszIpbA0piQyd+txU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JP6/aOzB; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JP6/aOzB" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-47f96c5b722so397379f8f.0 for ; Fri, 14 Aug 2026 00:43:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786693384; x=1787298184; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=y8vjAWe5WEpjLI973Es38xQAbA8Y/MTMFx2xNaDbwjw=; b=JP6/aOzBaudCqzQ4fgxSl+ylmjDqiSiC5b+pCvJ6zXLb5a8hn4EWyL0pwQLjSENizj lPK0Cku2P8gv6Qeiz9DbymUFeJDAsDAJzrwtljtgVC2dukmEhXVRPk5MrDEIjcAyPIlE kF3qlpogSVEHhmY94K2p11QzQAYgkuaRYe1B/oGcig2oHGlx6PfeP7ti8As442K1I6h1 nfZ5U8jTSqC0e/elUmz+Qgko3auMs6DM8saEIZiNvHlPUO/aiZikpYsGZn1Pr6yByb9X ITBCdKu0kYcsparjmM+7Sp/BsQubJ6aC2oiD68IY6R7sUwzpGm4O3VN8RjbsYmS1+1T5 nDCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786693384; x=1787298184; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=y8vjAWe5WEpjLI973Es38xQAbA8Y/MTMFx2xNaDbwjw=; b=cTjgPvU69efyF0HP/1Z5OYZD5nxFZnd4jnwLQtO6bdUbjbXzaLOHZT+58pzI09aZ+k C5w+l1oo7dq2OBZB0Jx7MViUptCQHihvBRpznYBRh0f9QEsqMqhXqYfADFADxWQ4afzx 38L6CWNdDKIespgf968MLVZsfgvFriIJ9PJ6VPtAS0VTN0s7hyMOdVyK5UUOunItAhEg ktRHhIr73kjzsHF6qWu8+FnVRpAMD4XhKHU6fDaQC4R/aq/ds8avXBWw0p+2CyExTTk4 C6ptJVkIA8DGmvoi6UCkkGWtn1OhQYAp3JwwiZef5H6Wikvm3BYKw7IgyPEjrB/MbjP/ Krxw== X-Forwarded-Encrypted: i=1; AHgh+RrvBoZ1cdMdwwsScOjY7ArD053Xe/NngK9VECkCda0N237/PT63bkDvFwGwN/1Yu7FFmTVBIufj4SyeDVA=@vger.kernel.org X-Gm-Message-State: AOJu0YxSyhq0Bg4VdqEsnJ0Iq6QRevV5ReTtn/8itCoemmUypKtpPhVr d2pDF1RTLHwP/5HvsLdSfiFbhCVnfSXvLiNhVh8rgs54oQAL50A5EPHs X-Gm-Gg: AR+sD11lodhoMmfsznXIep3uIkj7MDxNNHJDyssJZKW/mpKINwXbKYpy7V90bNLiTcK eHa7JR74/dMFsOU7nb1Ys6D7BJ9KD7Ye9O8czw9hIXNRaJsp2TEoBHGV4ZcPhJG91bMWIAKR8du IyC8RYgqIAR0Iqaa0a+iccd5P59wQYaDAdsBi/qFMTyLAThsPvMXGigz7Pz0U4LOR0b65ZO6DYw bj/++bEalYAfgiKNTGLmbbvAXk6GTsLbT8+ciC+GGJ+GSsF5W4lthc9B3Q4F+1tojkHiSdYnv6m RkMiL6VWgWR2pPmXpaMi19O3xHD0tU5t1bDrB/H66mOpI7rfrWc/xoO3ZCt6+V4HkN8EtJhmYG1 xSJd9Q7jTl1/+z12Wj1NGutJV1uVXVkAMNAnb16LLEL9VadB5v2YQr9oRAXJemBDtuWWhndHUQO UKi4KVNFb320I+RLo8OkBNmoFxaTVjweInPRvgoYkYaBSZZxLPyQ/qCRk5 X-Received: by 2002:a05:6000:40cc:b0:481:4697:a6b0 with SMTP id ffacd0b85a97d-481607a819bmr5106878f8f.20.1786693383650; Fri, 14 Aug 2026 00:43:03 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f219f7bsm5744061f8f.13.2026.08.14.00.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 00:43:03 -0700 (PDT) Date: Fri, 14 Aug 2026 10:42:59 +0300 From: Dan Carpenter To: Tomasz Unger Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: remove stale comment and dead code in os_intfs.c Message-ID: References: <20260814-v2-attempt-final-v2-1-cd3a27834b7f.ref@yahoo.pl> <20260814-v2-attempt-final-v2-1-cd3a27834b7f@yahoo.pl> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260814-v2-attempt-final-v2-1-cd3a27834b7f@yahoo.pl> On Fri, Aug 14, 2026 at 09:26:06AM +0200, Tomasz Unger wrote: > Remove the comment referencing an unresolved 'XXX' placeholder > and the commented-out memset() call it describes, rather than > fixing the placeholder in place. > > Suggested-by: Dan Carpenter Normally, we wouldn't give a Suggested-by tag for review comments, but I won't turn down credit just because it's undeserved. > Signed-off-by: Tomasz Unger > --- > Changes in v2: > - Removed the stale comment and dead commented-out memset() call, per Dan Carpenter review suggestion. Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter