From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB09037187E for ; Fri, 14 Aug 2026 07:59:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786694363; cv=none; b=cwNlFM+Q8gLP5PQpN4x1cGKpoEehPTSl4PJVyqGTxM2rvJ0Jrkv9ty3md+U8AtyYeK6p4vnWHEV7WZKBpdCUomJpBDDtIJ4ahoUGcbibLEkJQgwCdT7Hz8BPsltWMJDoP7awtUdZ/tJIBrdYQON7pSaQJrKc5SGNrmvrbV4WuUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786694363; c=relaxed/simple; bh=lFuuVXygboDHCbUA1cBZ6s2e1iwH79UL1npuRt7IJDw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WP3Z8J21XANebMKv+79obShJ8AP5DNrpknudoXx5ZgffpeKkOY4bduYAwtDZvwhYho2Mnr0+AUMRlV7L2jocb1UvSlFDwkqP/yjLr5nlCjk1x6ihEqgjPwKsb80QwxId8NU++Wab1CcOKO+I7I3gWi3RJcVpEOpLtRIzaqeeGaU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=G2srPoFy; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="G2srPoFy" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-472326ca506so439779f8f.2 for ; Fri, 14 Aug 2026 00:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786694360; x=1787299160; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=SQfNyfohuDdwICs99uq9OSV55VdM81uNBvlCVq5GtNY=; b=G2srPoFyL8qVhPyz2lHteonanOEtpVv2oUSg8MbjTgFV4KbGFZbLVzNPWm2Dn5zisU Ow04PaIN6E/xYD5vQ5GrYPUf3t4bM3CyCyiFzpooFAucJsldNBv77FrX84SWWy3R4L3n CSiTRHMIn9T+sr4DO1GpdzUmt1cxsbWP4Ieneucw2T30tV5A3t6Gu+RjRs1ZHWRSA7kz h5MLXzLVquN88NewIyo01acLE0+NpSZ16jU0hOW+wRxX5jM0VPshHm9c5J/DB/uN+HZD RPGIDdg0sgvO/vYsySHmZaGpb4lKBExShHtpdI1oryBmK45HE/eJ82VnIKSIR7mJluUK Sk4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786694360; x=1787299160; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SQfNyfohuDdwICs99uq9OSV55VdM81uNBvlCVq5GtNY=; b=R2rAgwS5A5I/XRO9uHzmmkeP0Wq4c3pfD9bQqsn9b941GJtwGFF+xwgHtm70wNNLXr wpMgfJD3YW1LjCaDnYynwStZ9/RBE/pB0PEzFMVmorZ1/xhG76rs/Utys7mHPI8m0ZM7 th+0/a8sey+TyBgMDIOymbECbvX3elPUW3Wq8MmuBQh04lOlmiQxdQ7gSGgDgXBRKq+K mLa/HZWdnwmhlepBTt3CBLbUGUQenimkps75qwclNexIq71N5d9KlagMoMsJ0ZGH92zl JybqFtrzWygWXFl8AkmbiyHml7QW8FerFchO+zjlS5SuRYX92yFDY5StbCIdQGaYD2t7 eoPw== X-Forwarded-Encrypted: i=1; AHgh+RqAY2liGOULUoGLwyt9mB3RKjRF0JXPEbErQ9zu4VKoYHPS2DjmZSmZN5qY9AJimeRZVDF4LaFpMJbrV2s=@vger.kernel.org X-Gm-Message-State: AOJu0YyheDdJSRamj2VwL60dSXXQtFaxtOt3wRR7E6kGzb8KsRdE8mww 0Un5wUENFRAYwDozp8Ft87lRsJkwnqZzlHMcRTl/i+nC31+Tr7aLuziPN0PgHSvFkfP8cwd8P61 CdwCZhrwH X-Gm-Gg: AR+sD129PU0+NbkpF50rp1mqsPUXWpR//0Yuz/u41iGsBGATWLfF3nBWSo2yPTYNwH2 m97etjcqy7x/fxADxl5eXDfoxtlIp70Ar/2L5VmTqShtJ3j8TyL+Cv+E8htWvGNK6GflXfFQtOG P3YgqekinrDy7xnSVeuGcJh8qYAnXe/HM508UCumNx4v3Fkhv7HUGvI6CettqqNAgMM2oZX3dme SlLYiBZjcZfG/U5e+KAJoIvPtAA4AucxazCVsxP3HOuV7OZqSCE7vnBjuM3EIURXpoX5bZZq1D/ GjcUWHcdhBNrZEq4Rb31jv9RDMPkudlLPLh4taocKjWXwC4LvOWss4SmuS6IR1meb9vs3f0NNSR 5GlQ/wrJonzwQdLZkNwQSGz9GHcWwadNMJsV6sqGuvq6rHwyYgdy7m7+OxXitjp0Bh7ulWKcGi8 is4FHNsSLaOI8p2HEpoqOQ7O6qmaFB+hRXAHLhF4l2+gQOkqc+qeVryvEmF2qPIxAwFbXFB0N6i D3o5es+kbNL8c1bQkI3qFGXYqYc29Sp X-Received: by 2002:a05:6000:2301:b0:47f:9096:3ef1 with SMTP id ffacd0b85a97d-4816072f9fcmr5926592f8f.9.1786694359519; Fri, 14 Aug 2026 00:59:19 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2b13c3sm4863145f8f.19.2026.08.14.00.59.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 00:59:18 -0700 (PDT) Date: Fri, 14 Aug 2026 08:59:15 +0100 From: Vincent Donnefort To: Steven Rostedt Cc: mhiramat@kernel.org, linux-trace-kernel@vger.kernel.org, mathieu.desnoyers@efficios.com, kernel-team@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 07/10] ring-buffer: Dynamically calculate max_data_size Message-ID: References: <20260813131152.3589632-1-vdonnefort@google.com> <20260813131152.3589632-8-vdonnefort@google.com> <20260813213407.6bc29cc9@gandalf.local.home> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260813213407.6bc29cc9@gandalf.local.home> On Thu, Aug 13, 2026 at 09:34:07PM -0400, Steven Rostedt wrote: > On Thu, 13 Aug 2026 14:11:49 +0100 > Vincent Donnefort wrote: > > > The ring buffer order can be dynamically modified and temporarily > > disables writing to do so. It is therefore safe to use the updated value > > to calculate the maximum event size which can be written onto the ring > > buffer. > > > > However, notice it is hardly making any difference for trace_marker > > because of the TRACE_MARKER_MAX_SIZE limit. For an 8KiB subbuf size, > > trace_marker can take 4096 characters while it can 'only' take 4054 > > bytes for smaller subbufs. > > > > Fixes: f9b94daa542a ("ring-buffer: Set new size of the ring buffer sub page") > > Why the fixes tag? What is it fixing? > > -- Steve > > > Signed-off-by: Vincent Donnefort > I wasn't too sure about that one. Let me drop it -- Vincent