From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Maxwell Doose <maxwell@maxwelld.cc>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Marius Cristea" <marius.cristea@microchip.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Tomasz Duszynski" <tduszyns@gmail.com>,
"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>
Subject: Re: [PATCH v1 1/4] iio: light: Unshadow error codes in ->store()
Date: Fri, 14 Aug 2026 11:14:00 +0300 [thread overview]
Message-ID: <an7OSM04kiviu9xL@ashevche-desk.local> (raw)
In-Reply-To: <DKOBND0GKI21.2843OFKP0KR40@maxwelld.cc>
On Thu, Aug 13, 2026 at 09:47:00PM -0500, Maxwell Doose wrote:
> On Thu Aug 13, 2026 at 3:47 PM CDT
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > On Thu, Aug 13, 2026 at 8:52 PM Maxwell Doose <maxwell@maxwelld.cc> wrote:
...
> > Note, that kernel.h shouldn't be there at all, but that is definitely out
> > of scope here.
>
> Makes sense. I wonder if it may be worth doing a patch series removing
> all of the kernel.h inclusions in IIO all at once (or maybe some drivers
> have a legitimate use for it, but that seems highly unlikely).
Yes, for sure! I have simply had no time to do it myself, but I have a low-prio
item in my always grown TODO list. So, if you do that, I will really appreciate!
But be careful, the actual patches should care about the whole bunch of the
inclusions, and not just about kernel.h. This means each driver should be
carefully inspected in accordance with the IWYU principles.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-14 8:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 7:16 [PATCH v1 0/4] iio: " Andy Shevchenko
2026-08-13 7:16 ` [PATCH v1 1/4] iio: light: " Andy Shevchenko
2026-08-13 17:51 ` Maxwell Doose
2026-08-13 20:47 ` Andy Shevchenko
2026-08-14 2:47 ` Maxwell Doose
2026-08-14 8:14 ` Andy Shevchenko [this message]
2026-08-14 8:25 ` Joshua Crofts
2026-08-14 8:50 ` Andy Shevchenko
2026-08-13 7:16 ` [PATCH v1 2/4] iio: imu: inv_mpu6050: " Andy Shevchenko
2026-08-13 17:57 ` Maxwell Doose
2026-08-13 20:48 ` Andy Shevchenko
2026-08-13 7:16 ` [PATCH v1 3/4] iio: chemical: sps30: " Andy Shevchenko
2026-08-13 17:53 ` Maxwell Doose
2026-08-13 7:16 ` [PATCH v1 4/4] iio: adc: pac1934: " Andy Shevchenko
2026-08-13 12:17 ` Marius.Cristea
2026-08-13 17:54 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an7OSM04kiviu9xL@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marius.cristea@microchip.com \
--cc=maxwell@maxwelld.cc \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®