From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D500437136 for ; Fri, 14 Aug 2026 08:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786695964; cv=none; b=okdXj5oXtDVi0eKeXTyLQoc2sIh9nEvNnbDRssBtYgZnAdhiFomGmJHu5YqVQBNB4GUHYPJTxlvNpcepnDazV0wGADq5AlQnS/br2dtFi0GSO3AFXOxkdc7QhgdD4hSWdxhNS/oLbVdGn4cGjoL/HWZqA7CZfiy0g1h2yp5bZAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786695964; c=relaxed/simple; bh=Ps0zPbYmFmr1PCTK5dolhMfnvmZuycDpsR5AKhe3KfQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eCHgkP5SsqtQFw3JvrwrqJhdABbctp3mDoxLTx/YvX6bxH3l5epMLG0NjEi1GC5uo6lAKGmm/T3Amyt9AgQPIIk8+O7+gfdN7XhmqjCJsp7VUbEgmF+PXHWvSohv68NGVc6N34GGbTZukaSGvcFNtgfbXH1Mlg3t+lr99rKIpTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=s1+wkYsL; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="s1+wkYsL" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-472326ca506so457273f8f.2 for ; Fri, 14 Aug 2026 01:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786695956; x=1787300756; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=l+iWy9azNUvFD85ODC8trsZsRoeRBZ5dWgI3BFE848Y=; b=s1+wkYsL/WbzaiCq1FDe12fW7QbxgwmmfpmaxPTjUNW8bDMcTMgyt5LoghJ6fTYgcq /NgzJ+IADwPf1MZMhlcRhDy5db3lDv+vCPX9jAoirmP/mcfMo+aQE5LragENpC3yqBFd 14HyHjdKpG3I/KLhhytlbTfoPFTDC6W2sR60tUjJrccf0ctpBIB6Hil4LOXQ/ZlZaOnS v0VmiqKs1Wbx62W+PGW0jEkehqjOgd4ciLJA6H9/S8xEnGauJLuyxsYK11gfEPmDkilc +54NjRtB1GiHPqsUDUIUErFrU+gRyNJCEiCttTXyuY5RIwrS4T5vpwj8LBPqZTJfPfSq 024Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786695956; x=1787300756; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=l+iWy9azNUvFD85ODC8trsZsRoeRBZ5dWgI3BFE848Y=; b=hNf5Slk2s0n+0H5D/GpJKUvc9CNnjy7YgXT49UzMPwUiF7P51FXbB8UZjc5SzPk6rv aDxyYtDLJxfnPXnT/M9z2OeAin29T5jfdlSRjIUqhp61vjp/LkZQ3oFO3hpyp6P4tJut j51OI4mDla6hJkZNRCbQOHf1b10/SIKYFvCFcAHVeXXcEKfC54slBnVLXdN+dlX4R6SF htNqT4nazwSWT2qMCxwJf0rT5Vt6c6ADavYL0O0UWR20kGQGX7ZtXJH9ZRz0kHcJciE3 SiNpe/oThnUyKJBUdm2fcxXaW3WoR0xs6eE/X/3S2PJvvrmcF0uHqmTbqpN131JfBWy6 Lx+g== X-Gm-Message-State: AOJu0YwFU7WJfjbjAN3Z84+iIjyhreWrIPAjNr1VGQ+vFpVKJhTWcbLb +byGKC4Dp/PqmKnaA6KnPmuBo3Ar/lw5ictVf5AC6GwUeRuK4WPTVijQPorSavVJMFdSHHItu4k v/b9JU3Ou X-Gm-Gg: AR+sD13DicXC8TmxDtNfpJGFrkC8wsbwVA2IprHoaOyak24FumWK+6RtZD38oXzzw1y JyC4iiL80dkROqn1Ws2Uwup/vESZtNhdZMbpYQ8uqLv8uKOm/VXo+Fzb+Une+djhlXfaitwnanX 60f0IMIHesRJ0bbeE0xro5Y/cHawEHxexBZ3eGwmz6o+FrH8xRVMwg9Al6PY390z1HMmd52xyUS t7XyQ0OG1rdlzVLJtn3BX4wc95+P73OQcFtznXXw9hhHaA/2wvnojRPhcw4au246JQNDALHiniX JGRhhDPbvGP6bE+IepMHzxbdEMP3FnuWiK0pxDEM1r3K4W63w/ds4fQGaSjUFZv7iuTRd9O1l4X OqDJhAg2Y8UB2VFls5t+cppHNdKzAdOMVg3R+T9pcXevnqZ+OvEIn8L0buUpI8JZf0/8kg4exTz rRYpGIqte7mjBFxfgkVOCzMCTcm0PAjmLQW22fwRB5gBnMn4cy06ov3Vwe1+xvhMW6XJ9kmkfyw v4PsUvc344NO6drPPQPnocqcoLyLbU4 X-Received: by 2002:a05:6000:288d:b0:481:5bce:44b3 with SMTP id ffacd0b85a97d-481607708femr5732525f8f.16.1786695955309; Fri, 14 Aug 2026 01:25:55 -0700 (PDT) Received: from google.com (135.91.155.104.bc.googleusercontent.com. [104.155.91.135]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2b1a91sm5960563f8f.21.2026.08.14.01.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Aug 2026 01:25:54 -0700 (PDT) Date: Fri, 14 Aug 2026 09:25:51 +0100 From: Vincent Donnefort To: Steven Rostedt Cc: LKML , Linux Trace Kernel , Masami Hiramatsu Subject: Re: [PATCH] ring-buffer: Fixes for subbuf resizing Message-ID: References: <20260813215230.7aa47950@gandalf.local.home> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260813215230.7aa47950@gandalf.local.home> On Thu, Aug 13, 2026 at 09:52:30PM -0400, Steven Rostedt wrote: > From: Vincent Donnefort > > This series addresses multiple issues discovered with the dynamic ring > buffer resizing. > > Signed-off-by: Vincent Donnefort > Signed-off-by: Steven Rostedt > --- > > This is patches 1-5,7-9 of series: https://lore.kernel.org/all/20260813131152.3589632-1-vdonnefort@google.com/ > > I'm running them through my tests right now. But I wanted to see what > Sashiko thinks of them as one big patch. In the series, Sashiko kept > complaining about existing issues that were fixed later in the series. > Sending this as one big patch will hopefully have it give better feedback. And it actually does not look bad! The only comment left was fixed in "ring-buffer: Make nr_pages unsigned int", which from Steven's feedback must be renamed as we may want to keep nr_pages unsigned long where possible. > > kernel/trace/ring_buffer.c | 268 ++++++++++++++++++++++--------------- > 1 file changed, 158 insertions(+), 110 deletions(-) > [...]