From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Yu-Chun Lin <eleanor.lin@realtek.com>
Cc: linusw@kernel.org, brgl@kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, tychang@realtek.com,
stanley_chang@realtek.com, cy.huang@realtek.com,
james.tai@realtek.com
Subject: Re: [PATCH v2 1/5] gpio: rtd1625: Minor coding style cleanups
Date: Fri, 14 Aug 2026 15:05:18 +0300 [thread overview]
Message-ID: <an8EfgU5HqwyfKHA@ashevche-desk.local> (raw)
In-Reply-To: <20260814025657.1400452-2-eleanor.lin@realtek.com>
On Fri, Aug 14, 2026 at 10:56:53AM +0800, Yu-Chun Lin wrote:
> Address a few coding style issues:
> - Drop redundant initialization.
> - Remove an unnecessary blank line in rtd1625_gpio_setup_irq().
> - And move the comment closer to the related code for better context.
Not sure if this needs to be split to two patches (the second item doesn't
really belongs to it). With that being split out, the Subject may be corrected
to the point of _this_ change, id est "Drop unneeded 'ret' assignment", and
in the commit message something like "While at it, place correctly the comment
to be just above the referenced code."
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-08-14 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 2:56 [PATCH v2 0/5] gpio: rtd1625: minor cleanups and log improvements Yu-Chun Lin
2026-08-14 2:56 ` [PATCH v2 1/5] gpio: rtd1625: Minor coding style cleanups Yu-Chun Lin
2026-08-14 12:05 ` Andy Shevchenko [this message]
2026-08-14 2:56 ` [PATCH v2 2/5] gpio: rtd1625: Fix variable type for regmap_read() Yu-Chun Lin
2026-08-14 12:05 ` Andy Shevchenko
2026-08-14 2:56 ` [PATCH v2 3/5] gpio: rtd1625: Narrow variable scope in loops Yu-Chun Lin
2026-08-14 12:07 ` Andy Shevchenko
2026-08-14 2:56 ` [PATCH v2 4/5] gpio: rtd1625: Replace pr_err_ratelimited() with dev_err_ratelimited() Yu-Chun Lin
2026-08-14 12:07 ` Andy Shevchenko
2026-08-14 2:56 ` [PATCH v2 5/5] gpio: rtd1625: Use IRQ_TYPE_DEFAULT macro Yu-Chun Lin
2026-08-14 12:08 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an8EfgU5HqwyfKHA@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=brgl@kernel.org \
--cc=cy.huang@realtek.com \
--cc=eleanor.lin@realtek.com \
--cc=james.tai@realtek.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stanley_chang@realtek.com \
--cc=tychang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®