From: Jiri Olsa <olsajiri@gmail.com>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Leon Hwang <leon.hwang@linux.dev>,
bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
Emil Tsalapatis <emil@etsalapatis.com>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Move tracing_multi_bench_attach to bench
Date: Fri, 14 Aug 2026 16:54:50 +0200 [thread overview]
Message-ID: <an8sOsKmqUexcYKv@krava> (raw)
In-Reply-To: <an4HDVUea-8zgdUM@krava>
On Thu, Aug 13, 2026 at 08:03:57PM +0200, Jiri Olsa wrote:
> On Tue, Aug 04, 2026 at 03:40:30PM -0700, Andrii Nakryiko wrote:
> > On Tue, Aug 4, 2026 at 8:48 AM Leon Hwang <leon.hwang@linux.dev> wrote:
> > >
> > > In CI, the tracing_multi_bench_attach test could cost >10s, which should
> > > be avoided in daily CI running.
> > >
> > > ./test_progs -t tracing_multi_bench_attach -v
> > > WATCHDOG: test case tracing_multi_bench_attach executes for 10 seconds...
> > > serial_test_tracing_multi_bench_attach: found 40163 functions
> > > serial_test_tracing_multi_bench_attach: attached in 9.367s
> > > serial_test_tracing_multi_bench_attach: detached in 1.798s
> > > #546 tracing_multi_bench_attach:OK
> > >
> > > Since it is for benchmark attachment of tracing_multi link, move it to
> > > the generic bench framework.
> > >
> > > ./bench tracing-multi-attach
> > > Setting up benchmark 'tracing-multi-attach'...
> > > tracing-multi-attach: found 40166 functions
> > > tracing-multi-attach: attached in 9.278s
> > > tracing-multi-attach: detached in 1.836s
> > >
> > > Assisted-by: Codex:gpt-5.6-sol
> > > Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
> > > ---
> > > tools/testing/selftests/bpf/Makefile | 2 +
> > > tools/testing/selftests/bpf/bench.c | 2 +
> > > .../bpf/benchs/bench_tracing_multi_attach.c | 177 ++++++++++++++++++
> > > .../selftests/bpf/prog_tests/tracing_multi.c | 125 -------------
> > > 4 files changed, 181 insertions(+), 125 deletions(-)
> > > create mode 100644 tools/testing/selftests/bpf/benchs/bench_tracing_multi_attach.c
> > >
> >
> > Jiri, are you ok with not exercising this logic regularly?
> >
> > but also hm, is 10 seconds expected?
>
> sorry for late reply, I overlooked this one
>
> the 'commited result' is around 1.2s.. will check
>
> serial_test_tracing_multi_bench_attach: found 51186 functions
> serial_test_tracing_multi_bench_attach: attached in 1.295s
> serial_test_tracing_multi_bench_attach: detached in 0.243s
>
> thanks,
> jirka
fyi found the possible culprint:
https://lore.kernel.org/bpf/20260716-execmem-x86-rox-bpf-v0-v3-0-4e76158c01c5@kernel.org/T/#m8184343c667a96efae72ae55f7a8679d51f6eaf6
jirka
prev parent reply other threads:[~2026-08-14 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260804154813.90795-1-leon.hwang@linux.dev>
2026-08-04 22:40 ` Andrii Nakryiko
2026-08-13 18:03 ` Jiri Olsa
2026-08-14 14:54 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=an8sOsKmqUexcYKv@krava \
--to=olsajiri@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=ihor.solodrai@linux.dev \
--cc=leon.hwang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®