From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38DF048F82E for ; Fri, 14 Aug 2026 16:57:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786726647; cv=none; b=ueyr4srATujNZIUIjTKzgKEzBgAR8vVVFLB1CoS2DzgNqbPnmX+s9G+tBlDSFgpyiroU5wDNt7RAnUzuQdt5pumqYXPm4fMtix4MJ0zZVHiDIRFCvV0X4rebHMVgk+d9Pl0W+CY7FDxWFi8/sddIDU50ICyWEaAFD6/yCDSj0xU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786726647; c=relaxed/simple; bh=P6TsHROzGFuvuQhbbFjiY+3j2uy9Mvh2w6OicTyhP+4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=ssdCxJrlaqFMi3NpMw/w2pjJfJiteyDTIGyREMTxeiYrSLOtlrbiTNLuaa3qI5JttaMrQ88gVd0tt+SM7HqpcyjahKkoLeI302cFn1JWxTwY6R8GFWLfa+0uOGy7ArepnGmvprO0dP4F6s9C1sslVxDIsT5xihhpbLnRAoeX74s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AJIfzpYP; arc=none smtp.client-ip=209.85.215.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AJIfzpYP" Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cbee57593baso743175a12.3 for ; Fri, 14 Aug 2026 09:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786726645; x=1787331445; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X2uuaYXrIG65WiBuHQ7NDeP7zvEjj+v6bDkDWDXYLIs=; b=AJIfzpYP7ZOCo0Y0NYaXmZzmOg1LUTSoNOlQ5e9z/q5JgcRbE+1QijDFzAvNPwrFsO 3ZoQPn354oZU0XPq4sdIq4X8cdL4iYMoROGXUjrIdUSm8XNucEp+ii/cT4bYn3JgUEGo j+giJo1V4bYIPEkzkvB7M13JnQdn2FvYJ+pUIFiQ1fkThcUFlR+qIhGzHuWYW3hc1FSU cICp59phLHLHbBhh7dpHFT1durglijsi1PnMvB1MoXhYEIwBAqGyrJNSxIe7966KB+Z8 ZnwVubVq0Qp7bE4RN18/2g49B4/yPX+7x337Ob39qwQVTKRxAHPeUCTFcBNfuX0ng5lX 0hkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786726645; x=1787331445; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X2uuaYXrIG65WiBuHQ7NDeP7zvEjj+v6bDkDWDXYLIs=; b=lkQa6e5niXn8xhPj3tWgfn6Qa6Xbtr7DzvNnEc1Ki1J8YEGEvKFSVTSQuVdGBd6oKo 0W1uem3bXpSespzRKBDY0kT0vKGfJUqWsIw3xfIuaLpPlCRNHJFwI3tSUZcVkdBjFalo dJvfGjLbCakVLL1GTRQ9b4UySp/MxIgEAwaPlqQ5HSWpw769jbO5hkXi028azDl06kkX CBC0T3fYMcFtRaUDFiHBNwpGOwW8kdK+dW+WO9lPaxr8upIOO5XSwxOB7Fz9YfVgcjMY MRFspXOf/fsbPga4w61BtanNzHsP6usy9YmHUHE58NPmjjYIU00Nbhf7J6JPxnrWYJXp zmKw== X-Forwarded-Encrypted: i=1; AHgh+RorDNNpIzV+kJuDeC55NbHD74V3asP0wHlArPwUlUTMcdPsFFrnqLo6skJ+MFhKlKlnexbhYmXwJ2RNxPA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywi4yYY1U4Mv5NZtEt1f/jYPcNUgs0hbiACrTL5H8ZNiTrEfV8k Lp+Pc/8JuKndj4SAcuktFHMrP0djKuCobb4uWEJrHYNWgstdJtdfDaYTysKAHU/LqhdOXRB3ZbX oQ18iFg== X-Received: from pgmu38.prod.google.com ([2002:a63:2366:0:b0:c99:90dc:7b3f]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6300:6708:b0:3b4:6026:6c5d with SMTP id adf61e73a8af0-3cc7196e726mr8567420637.5.1786726645347; Fri, 14 Aug 2026 09:57:25 -0700 (PDT) Date: Fri, 14 Aug 2026 09:57:24 -0700 In-Reply-To: <4f58be1f-74de-411b-9aac-896ad7af57ee@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260129063653.3553076-1-shivansh.dhiman@amd.com> <20260129063653.3553076-8-shivansh.dhiman@amd.com> <4f58be1f-74de-411b-9aac-896ad7af57ee@amd.com> Message-ID: Subject: Re: [PATCH 7/7] KVM: SVM: Enable save/restore of FRED MSRs From: Sean Christopherson To: "Nikunj A. Dadhania" Cc: Shivansh Dhiman , pbonzini@redhat.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, xin@zytor.com, nikunj.dadhania@amd.com, santosh.shukla@amd.com Content-Type: text/plain; charset="us-ascii" On Fri, Aug 14, 2026, Nikunj A. Dadhania wrote: > > > On 8/14/2026 5:17 AM, Sean Christopherson wrote: > > On Thu, Aug 13, 2026, Nikunj A. Dadhania wrote: > >> On 8/13/2026 4:57 AM, Sean Christopherson wrote: > >>> On Mon, Aug 10, 2026, Shivansh Dhiman wrote: > >>>> Would you prefer it handled in svm_recalc_fred_msr_intercepts() instead > >>>> while setting intercepts? Or is there a better way to deal with this? > >>> > >>> Take a hard dependency on an upcoming APM update that states the control area > >>> is valid after shutdown, and rework KVM to not clobber control fields on shutdown > >>> interception. > >> > >> AMD APM 3.45 [1] is now publicly available and has the updated wording: > >> > >> "After an intercepted shutdown, the VMCB control area is valid (with > >> the exception of offsets 60h, 61h, and 68h) and the VMCB state save > >> area is undefined." > > > > Very tangential side topic: are combined versions (all five volumes in one PDF) > > of the APM available? Having to open five different PDFs to find information > > is a pain in the rear, especially since I can never remember what's in which > > volume. I can manually splice the PDFs together, but that's far from ideal. > > Yes, combined version (Vol 1-5) is available here: > > https://docs.amd.com/v/u/en-US/40332_4.10_APM_Vol1-5 Awesome, thanks!