From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B3CE49483B for ; Fri, 14 Aug 2026 17:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.198 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786730270; cv=none; b=WSnDuY3IkVanLlQSXv3QfYFrK05TlTx0XRmtC9CudbZJQFRZO2oASczu1XgAWhR6BLr4DK7v7RiAE7rhEliVAUXQxUcm/ZK70V8EdaI2LBtRPJCPRJBgJt4qVULt3/egQD6u3CHEptDkojhCM4xCLo8ATv38mC1/v83Si4C2o7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786730270; c=relaxed/simple; bh=vfWVk5cbC2alWZ2RcQ2gPFo+PGPYjPxWOtNwHPYXyoc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=dBPE9MvBdL8nUXsiPTSf9tSES6OsQYk7eqBAOfaot5cTvbiUzlgriDj+/84AdyhAgcZxaQAmStTFNHZznj/CEtEjLbO2vxW5bl2/gGjduw/HXahKbNWpFXLValNwXJ2jSju/0KkWq4JOnmKA26gZmsIzSiqG4c0VUBG63/+AkYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=T+cbN0QJ; arc=none smtp.client-ip=209.85.214.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="T+cbN0QJ" Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cea6a46766so20836375ad.0 for ; Fri, 14 Aug 2026 10:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786730268; x=1787335068; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FTRpQbBcuIQQHhR/UQMYNM1PA+jfAXsDHcYqcmWTXOk=; b=T+cbN0QJAG39Q+VhsESLtUVozx52DEwrqTIq1n7m3RCErpkB/FlaWzlNjYiXyph4p4 bKL8YGFd1mAZmlWpS91ETHhFpnGGg99yNovCiBsn747I9u5UWB5IDDrSTg8g0fyTpqYw axNYimylIvtry/W8h3GAaTobIjj8h/aJpGVQPHk2j15NK6HwdD6WRu/Q2ngNigNdw1Qt EWf/HZwIi296XSK0LRAiHEdIFBwfaF/ZVReRFYpClR+4WUywxdkuD/J2Mr+AHNauhpOD tqIR53WxMONQHgfQXrPoGJgzNPors3Nlf8gj/T4mLWK4JbFnsGNT2CpngcYgtHCWtlAi 5DOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786730268; x=1787335068; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FTRpQbBcuIQQHhR/UQMYNM1PA+jfAXsDHcYqcmWTXOk=; b=M2dQe+HSrmiqTQgsvDBueNtJYLfISDdYCpR1n7d2bEvWZ8UpfmSKf/qCNqDnz/6zKJ wO7HQUgoX71aCYcFNEkw9iOnnrX+/EOJYSR0lHKBfNZho21Er+epxDeFRoogeBYt5CiZ 8XmRbSo7TicZ9wA69P9A+Cf6BxfdQC3kNHpeT6BF0l+1fqWVwvGeqZGqcrDubURp0ccs iSlUpxVIYptB/5bpg5o13vhULJYrYiHK/kim1uSGD350N07tYT3OOdZCBVErnuNHURkV AVj5NaPensEERrUDXllRiuMt6G03sczlvSiUkm9+ag0QO9o6w6rHl47p3FmBuJnNSCmP d/bA== X-Forwarded-Encrypted: i=1; AHgh+RqyxJEy+TXOGj4qiFEVZ52UmisWidiaHpFhjyBJgCQMfEzQGyLqDJ4Adur+/pxIg9sPtzPk0gABW33nwzk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxv3beG2xZo50QyCGyGzZpueaeeB0pRfRiZntgu6orlYHhaYCL1 UX8ZsEyTDBXuxwClpAmeqlLQmCfVWIXWhpvtreXJAjbsyCPhccx5nLATKBk8WiW9sXyZu+zYjVS LEuOy+Q== X-Received: from plbmt15.prod.google.com ([2002:a17:903:b0f:b0:2ca:5dc9:51d3]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:22c6:b0:2c0:db23:4c4 with SMTP id d9443c01a7336-2d3b0c8852emr91417425ad.16.1786730267363; Fri, 14 Aug 2026 10:57:47 -0700 (PDT) Date: Fri, 14 Aug 2026 10:57:46 -0700 In-Reply-To: <36baf0ec-0b7c-4ffd-9a1e-dfe9617e057d@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260807-gmem-inplace-conversion-v10-0-2fc18ee6d3ba@google.com> <20260807-gmem-inplace-conversion-v10-18-2fc18ee6d3ba@google.com> <36baf0ec-0b7c-4ffd-9a1e-dfe9617e057d@linux.intel.com> Message-ID: Subject: Re: [PATCH v10 18/41] KVM: TDX: Make source page optional for KVM_TDX_INIT_MEM_REGION From: Sean Christopherson To: Binbin Wu Cc: ackerleytng@google.com, aik@amd.com, andrew.jones@linux.dev, brauner@kernel.org, chao.p.peng@linux.intel.com, david@kernel.org, jmattson@google.com, jthoughton@google.com, michael.roth@amd.com, oupton@kernel.org, pankaj.gupta@amd.com, qperret@google.com, rick.p.edgecombe@intel.com, rientjes@google.com, shivankg@amd.com, steven.price@arm.com, tabba@google.com, willy@infradead.org, wyihan@google.com, yan.y.zhao@intel.com, forkloop@google.com, pratyush@kernel.org, suzuki.poulose@arm.com, aneesh.kumar@kernel.org, liam@infradead.org, Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Jonathan Corbet , Shuah Khan , Shuah Khan , Vishal Annapurve , Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Youngjun Park , Qi Zheng , Shakeel Butt , Kiryl Shutsemau , Baoquan He , Jason Gunthorpe , John Hubbard , Peter Xu , tarunsahu@google.com, Vlastimil Babka , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev Content-Type: text/plain; charset="us-ascii" On Fri, Aug 14, 2026, Binbin Wu wrote: > On 8/8/2026 5:52 AM, Ackerley Tng via B4 Relay wrote: > > From: Ackerley Tng > > > > Update tdx_gmem_post_populate() to handle cases where userspace requests > > "no source page". To handle "no source page", populate (perform > > TDH.MEM.PAGE.ADD) using memory in-place at the target PFN. > > > > Allow "no source page" only when gmem_in_place_conversion is enabled, > > because retroactively adding support for out-of-place conversion would mean > > requiring a userspace update for a feature that's being deprecated. > > > > Also, KVM supporting "no source page" without in-place conversion would > > effectively be an obscure zero-page optimization that relies on the page > > being zeroed when it is allocated by guest_memfd. > > > > Rejecting "no source page" without in-place conversion scenario is valuable > > for KVM developers since it helps newcomers understand what exactly is and > > isn't possible. > > > > Signed-off-by: Sean Christopherson > > Nit: > Is Sean's SoB intentional here? Kinda sorta? I handed commits to Ackerley after rebasing them locally at one point, which is how my SoB got here. I think it makes sense to just drop them from the patches where I'm not listed as the author or Co-developed-by. In the end, I expect to apply this series and so my SoB will get added backon anyways.