From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C0F739185A for ; Mon, 3 Aug 2026 06:15:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785737710; cv=none; b=p7JUuzfppvrw9Geex26vLQ4UgxZzvv/0tA5W7QU8F+PYrStL9gZcrgrKxn6qsiV/6rdV/caHPVorFe8FyFhYIK1hWgxHimZOJQOxCp7VlqaGJcliiQb2j2e9sunxKTohM4V9bTnYizVcNkIwgNsqgGvGEKyLqNRKbpqme94nfuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785737710; c=relaxed/simple; bh=lV0FNc2jGbA4z0aPBrbq09G9Arq65dq7bjEYXqJ5/+Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NVXHVIiXXcvGXsk0rUb+7gFcUw6iawv40EzrWzVYzAsjqjfkd5c0Nqu2bcZ+rQWvtxfiN5RbwWlD/O8Lh7HnMr52/gt8JKdgFL8C6ATv+IzO0C1w3PdPsUXgM0GrYb5zcPVVaTZH6klmS6xPiDcOWi8glVQD1g2KekWi1NHDWWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=i4+OJ5/c; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=REYXmbVc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="i4+OJ5/c"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="REYXmbVc" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 672LVe6B3299614 for ; Mon, 3 Aug 2026 06:15:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=B7h+X9G8Urq50HCuJaQ8lxLP AAO5dohspwHE3VjyRzs=; b=i4+OJ5/cTfBTDrvpwhUzMGxbJ3Qa2NfFGLDNfzm1 nWw6sIHaPI0KVCgri5tJcQyoOUXrC1I/2zQ1P5TBP7HICjJuIQlcw/bwCch1RgmO yg4qJCSGG50ikGRtK1W9IwJsDHe1M7qXiGOM+g5aN59V658/RoOO8gSuj5YbJflp TRDvPfCuc14SnufVOWvVTv5rTTfOhStZ79yhJ9qIMPRP89EtzflOSC6xmhr2jYUT im6XaPQ2TLjnpybsGTbl7AiEVRWxGy3+IK+rXyk0hKIUp+IoKeo+Vpe4kg5u4e+R dbxLLWaGC4OYSvaFzSvJ/dnGE6M3iSSPl7MZxAgimIcIMA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fs8qpvrt1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 03 Aug 2026 06:15:07 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93106d8af18so231294585a.0 for ; Sun, 02 Aug 2026 23:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785737706; x=1786342506; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=B7h+X9G8Urq50HCuJaQ8lxLPAAO5dohspwHE3VjyRzs=; b=REYXmbVcLmZTkAMdv9xm/3pntfBrDRMekYic1fEckmMW8Ce7dkC86gU0azxdCym0AD wjpS86177Q0YuWwpyEI6GXe6WV25oFQaycfsQwGBHJ2PdE4P/GRVqNTG8sJeDnpo3e/b /BUFTovQjc7pJ5/+bRn1wZMZulD/lqqGGiaqKhOFEXM8taYgVkvbIn8qvI4JOzOYO0v1 UHSJWh6a5FXCu/ht7e1FnIxAbI3ZPcbC7YNHXUqmvLJzHMH+/fuuGJyPlrGfiV9ZPu+7 btVhegBbU4lV1dTj+0LrSECz4g3OgZkNWZmISr3qivtkQr3ECVji/LcpMLBQfRVgA4gW fk7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785737706; x=1786342506; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B7h+X9G8Urq50HCuJaQ8lxLPAAO5dohspwHE3VjyRzs=; b=EgIpNIWXhf9l2x7Nvn7HIjxywkj0M8jjEXOF98SdAB2S2QVDQ7VMbUKJKrqdSuU8hx HkVysKyTDfILGvPjTpaAne87cB52VJ9VrKwlVMr18kSNGE37O+n4s4SrQiEMR5GYkBjX ilC9/C9guN1SLTdj2pRYFgcOc7pCfWfLTCeHkVVV8Q/WoFJNMeP0vuDhdoAwXG44nhw7 6MoYYPRZ0txE/BbFDek6UoSknKMuBnBBbHHpKTyLmB0PBxUEMvZgeF0xSL19q9G9fKux Ou1SsNwTeMavNujmUyiDJqkvjpnAcRS6ySBgX0pe0VC91WOW1YczV0XHgMfpcvOu61fj J6pQ== X-Forwarded-Encrypted: i=1; AHgh+RrL5xVZX9+xUaonZGztFJP+4l4s20yt4COX7GXE+GZV83VsZWtrSu4F4tJ+jYKZeONGPoXGKwYEFbhzl7Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yyt5pMHSiEEdT/WYjSYaHgiwfRbfVSs4jUuuTduHBG+Ypy+X5Go 489IJhHrgyrBkoG4jMXUxRHhJTSTR6rbz0vO/vMTLoHzc6s7bT1F8GXkaqO9k2pgi8Ujp1D9hA9 bHXjKEXakqy+xLtBmcZfr8w10ZG+lRHi9XkDph/AAJlxjWhk6g+ajbJcZGspTvvlh/h4= X-Gm-Gg: AR+sD11OqvcePzFYaHC3zxC9v1NydGzv5kyYz+FrfiyIXyzcH5NEdT8lU8Rs1+bFEA2 1pZk89Mq17gjowbXa1ySF7uAGKcFbVK8hLCSPYbnG2ZM9BCwzCsvZXeepa71szlJ9oKdjq97sUk /q+Nlzli20G9i5CqmNvAgt9Z/iGMz+1ZqG1g2ho95flzIssyJNUCt4+CH/mM6lZXT0e4fOKBQ+D w8zQPY5EqJXstdrPYADNhULD2hQoaHdHAVpQ4kUQV7fBuzPcQZLZrZTo/3fMpO8OFVLZ99BONOZ wSp79E/PotCDusBS9Wp/ADW/TTYUE8fSDvJDnY34kM2z1wTVgfRHcmMVNWHpHd/g1EA/fx9ZGvX M5XGynpYfP4GaGrCNBkbhfwwj0KwtE0w3QQWEUKJvEPYMmXg+mz7AmyCaJvvH0lk= X-Received: by 2002:a05:620a:4104:b0:92e:2c3a:a15c with SMTP id af79cd13be357-934a0943968mr1814479585a.29.1785737706250; Sun, 02 Aug 2026 23:15:06 -0700 (PDT) X-Received: by 2002:a05:620a:4104:b0:92e:2c3a:a15c with SMTP id af79cd13be357-934a0943968mr1814470385a.29.1785737705658; Sun, 02 Aug 2026 23:15:05 -0700 (PDT) Received: from YUANJIEY2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9349c19f881sm594920985a.29.2026.08.02.23.15.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 23:15:05 -0700 (PDT) Date: Mon, 3 Aug 2026 14:14:58 +0800 From: yuanjiey To: Krzysztof Kozlowski Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, tingwei.zhang@oss.qualcomm.com Subject: Re: [PATCH v2 1/2] dt-bindings: arm: qcom: Add HAMOA-IOT-COME board Message-ID: References: <20260727070758.528-1-yuanjie.yang@oss.qualcomm.com> <20260727070758.528-2-yuanjie.yang@oss.qualcomm.com> <20260730-alchemical-phoenix-of-excitement-fff9bc@quoll> <2eb33f53-2320-40dc-8098-79fc4f48af8e@kernel.org> <28fb7750-bd46-4f3f-a3ba-7cc1fb88b235@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28fb7750-bd46-4f3f-a3ba-7cc1fb88b235@kernel.org> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODAzMDA1MyBTYWx0ZWRfX3byxsHt7kMTa xzoJRkgBbIunQP4drr2hNljqYmJXk16fp7ICznCvzh+Y0gXgXZ+W1tnPfVGbwog5XUK8eSTZ/W0 FrETUolMPPfsGbNDmTczIn739WVrrbpkA34Mp3v++vlPuBGG6ObJbrHmh/AyMLz88aGWVXl6LUg 7K7jYNcurGZZELlyaX5VZsx7AcsUg89TYZ9RIXr3zD604F9mg2iVPpQBfy+sVUSqsN2e7Z1P0JU tRQ5u+z4Nq5I0A5VOVzX7IVOR4TlH22TRRQ3Tymm8APu2m4U2YHrx8sD6dHZVPpWDNjOFnknGHi 4D2KI2j82PVGc4Sp/HnfzbGrjiJUPPmeJmIxTwQH++9uAImyWznCN2IlFqIyRaZcWSjUOw43w1N GWFMfw7owsQtodCTcHKRxqjpaM7FtFTEUpTyR6NMf9I36smp8F0AEHfouWEfMaTjKIEOchj+Kzw ETYZHMkhqlYgX37iSxQ== X-Proofpoint-GUID: NbpYmzBocsdoL3NxdtobGMl1fJTJ3S2G X-Authority-Analysis: v=2.4 cv=MpViLWae c=1 sm=1 tr=0 ts=6a7031eb cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=TJUqZQk6AAAA:8 a=EUspDBNiAAAA:8 a=m8ToADvmAAAA:8 a=HtLsr6L4JtS92wG4dZoA:9 a=CjuIK1q_8ugA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=Q0W1slMkcave-rSCEGgY:22 a=kCrBFHLFDAq2jDEeoMj9:22 X-Proofpoint-ORIG-GUID: NbpYmzBocsdoL3NxdtobGMl1fJTJ3S2G X-Proofpoint-Spam-Info: AW1haW4tMjYwODAzMDA1MyBTYWx0ZWRfXwz6yLDWLjAQ6 1QKSe4XJWr5aToGWtDUGqQZFNmdYPpg6pRIXLiEC8uMxH1CyxsH7DIedrTSupAlijs5EEKlGPoy rh5RN7PnbHQhmkA5Jfx+UqDWyfvVOOg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-02_06,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 adultscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608030053 On Thu, Jul 30, 2026 at 12:23:56PM +0200, Krzysztof Kozlowski wrote: > On 30/07/2026 12:08, Krzysztof Kozlowski wrote: > > On 30/07/2026 11:54, yuanjiey wrote: > >> On Thu, Jul 30, 2026 at 08:51:40AM +0200, Krzysztof Kozlowski wrote: > >>> On Mon, Jul 27, 2026 at 03:07:16PM +0800, Yuanjie Yang wrote: > >>>> Document the device tree binding for the HAMOA-IOT-COME board based on > >>>> the Qualcomm X1E80100 SoC. > >>>> > >>>> The platform consists of a system-on-module (SoM) mounted on a carrier > >>>> board. The SoM integrates the core system functionality, including a > >>>> SiP containing the X1E80100 SoC and its supporting components. > >>>> > >>>> The COME SiP hardware is effectively the same as the SoM used on the > >>> > >>> Effectively the same or the same? I googled for "hamoa iot come" and it > >>> gives me zero results. Provide some URLs describing both. > >> The same. > >> > >> > >> Here is pdf about the "hamoa iot come" SiP and SoM > >> link: https://advdownload.advantech.com.cn/productfile/PIS/SOM-6820/file/SOM-6820_DS(052925)20250529110758.pdf > >> > >> The preliminary figure provides a complete overview of architecture, including the SiP, SoM. > >> > >> In Block Diagram > >> hamoa come Qualcomm X-Elite SiP Module is the SoM on haoma evk. > > > > I see on that PDF "SOM-6820", not "Hamoa IoT Come". > > > > I have an impression that all this and previous bindings and DTs did not > > match reality at all. Or did not match how upstream works with such > > hardware. > > > > Adding more: I did ask in the past to properly represent SoM and > carriers. I pointed to other examples how this is done correctly. I did > look now inside and found absolutely no reference of actual product > called "Hamoa IoT" or "Purwa IoT". For sure there is no "Hamoa IoT Come" > SoM (sometimes COMe appears). I check the hamoa iot evk board page: https://docs.qualcomm.com/doc/80-77183-262/topic/Getting-started.html#get-familiar and purwa iot evk board page: https://docs.qualcomm.com/doc/80-80022-297/80-80022-297_REV_AC_Qualcomm_IQ-X_Series_Evaluation_Kit_-_Linux_Bringup_guide.pdf And I see below info: Dragonwing IQ-X7xxx EVK components: The kit includes the following components: Dragonwing IQ-X7xxx EVK mainboard "System in package (SiP) " I think the current naming of hamoa-iot-som.dtsi and purwa-iot-som.dtsi in the Linux device tree is incorrect. They should be renamed to hamoa-iot-sip.dtsi and purwa-iot-sip.dtsi. hamoa-iot-som.dtsi --> hamoa-iot-sip.dtsi purwa-iot-som.dtsi --> purwa-iot-sip.dtsi > Look, this is a SoM: > https://www.toradex.com/computer-on-modules/verdin-arm-family/nxp-imx95 > > And you can find corresponding bindings and DTS in tree. > > I refuse to accept more of this fake products trying to imitate well > known industry standards in their own way and effectively pushing some > downstream crap, just because that's how we do it in downstream. > > Unless you can present us with such product details matching what you > send, I will be NAK-ing these and future patches like that. Thanks for your tips: I check hamoa come som page: https://advdownload.advantech.com.cn/productfile/PIS/SOM-6820/file/SOM-6820_DS(052925)20250529110758.pdf and come board page: https://www.advantech.com.cn/zh-cn/products/1-fc23ff/som-db5830/mod_16b1a718-27d6-4a4c-8684-e8f2a8e9c57b So I should rename come binding with real devices name: binding should be: - items: - enum: - hamoa-som6820-db5830.dts - const: hamoa-som6820.dtsi - const: qcom,hamoa-iot-sip - const: qcom,x1e80100 Thanks, Yuanjie > Best regards, > Krzysztof