From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 945BE40B0F9 for ; Mon, 3 Aug 2026 13:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785762734; cv=none; b=VZAePIr5XHzosLFJ7QgIeLZaFCoDMPQFf92oZc9wjrPEvpYTjCN5qxul61fwVeTLw3s9Jlwj4U9C2sgE4yVxw8TRnQv7waXeDTbXdLdKgvYyo3JOkHCEAHa7jmuevawfYSKeuo9QbUbojFN4hLBLgOZqQSLR5JILSuai5WI8JJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785762734; c=relaxed/simple; bh=PyrcMBjEqokckfH0shgijzNdomu1NbS53nS/jPFEemw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=loI2QppklsvNgsEMr1cj8RpLDO6JgBbXajlBJaJ98FStRLRgAu7CHYUtNc2mZddbpgjzGg/qwiuwULJeXKruA7+AJzmgbAwBXdqgZ6eUaul8pFFI9l1Iqu2PYD/dojFBGnQJom/ca+bX2w6PxVqmBNMYvOAcWFt04Ng4gowb4r0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qP3Q+ALK; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qP3Q+ALK" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4953e04ef16so21417945e9.2 for ; Mon, 03 Aug 2026 06:12:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785762726; x=1786367526; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=97ECrh6uROUaQf13d9FVHmMobqo4zoNzxlywg2vKSMk=; b=qP3Q+ALKnsIeCFhq16bngMUyBFhqkAPvYN3HXwm+nE+2VJ71GxPdZoIO5Yn5O63FBn Df/jIjdZUvWkw1ZtkbNExSiXbe5v8wHRYQaMA6HkxVdx1+ya7vEylsnql4k8iEesylB6 D8qP8zunX/7nuKLKc5VMvpHlxdaq6e+gn2Od44Gt2luePcmmvhV4uCmn8YhE/MRv3+ad 0SEwC9fmWcaglXGCOvA0Px9oeoVNXAu6SG017CS4GxU/fc1k0+w6gTTJu7SJweIr3rii QNK5ktYfQS8MZ5wEjrIhYUPDpwxc1X71XaFaIhY+dUpJSrv03F6VBasPxDsjZcPMskH0 1C8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785762726; x=1786367526; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=97ECrh6uROUaQf13d9FVHmMobqo4zoNzxlywg2vKSMk=; b=TJZxmlaaXtRR4Xw5bWmgDnt9uMz+klHQbhCar6hbpmt/mqwauKA3vl8oHXLGzGgfRW rKqYkpt9gnjKBEEiLmH/HenbgTVXTFUZZYV+lEGeK5uF6pLcI1cQUXAew75p957RUz+t 2/z/5tzM1giMxFSebX84Iq+F1nWSoJLbr6HmeCIvrMmkJh2WmFxn7SYGBn6O98+xnW9l FEsuOiGSagSmnP13lYXCK5HoV1oxJCxU59UWlc0jiOUIuekuqp83RN4bLuN8BkxGqqAH DFmCACYl7B/fCyZNhXWA0PAbbnHlKqVVVjwase5vgkYIvn6Xk0sm3DQxisLfNty7Hkc/ Hs3Q== X-Forwarded-Encrypted: i=1; AHgh+RpmA9QwmgwyOoHylABYDBRTzopy/EI2vnJa5Ef7BC98Zj7RGcxym/RuJvt5Ou53JtKF1F1WiUQvJP1AItg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyu0ex3MHwixJlVhBFSHrrdo7BvVZwsZFu/NTmGFgTSyWsK32bL 7fASArWSx1YyZSOXqiJyDM+pa/+gTe2vIU6tPIZVmfY8N/aBaWMkewU3 X-Gm-Gg: AR+sD13KPozQWpPa+yztd6IS6LWenjaRQg3LA7uHZm1hnRr2jYelj0+Rk6oE0kZsh9V YVqKYw/U7UBFCC0YZcwz7J0rrDCqjoCctge0kuZYLoKRHT1lOesEVBVRixlzYvWsLkKun4WBEZK xWX6RRq+tOUqTKk91hoLlDy9DnPM7NDeVhl44q1JI4jVcs1va/TOGOTm1EyGcOtEZr0vXUDrYMk EE0kqbX3bpGgKZBK1ks+UFZt3En8Vs4J5cE7xvDJQYKrKOtbShT7cR2GP0WHmURPnpf+cRTOTx+ g7rhq/XFgF3Shl00NrYM+2KzqsPxjTh4jmKOj1P5oTwP3M0Ki/lk9ls5t2M6F22Gf29LkBGj6SV ygjdJS2O4kax8BvnmllWSK8Gs1fbEeQu214F8RwBRUrtBVzS69TlcrnGxZZgG3GNlwRLBXMdKNP 5h8M3jQIJBWrCRWVeYZTVRguAdnJ03+5JyJ2uHYylouF59ZCCTLVb0 X-Received: by 2002:a05:600c:46c6:b0:496:c977:3b6d with SMTP id 5b1f17b1804b1-4980c6747f0mr172273935e9.12.1785762725410; Mon, 03 Aug 2026 06:12:05 -0700 (PDT) Received: from nsa ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49807b6745csm232708385e9.7.2026.08.03.06.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 06:12:05 -0700 (PDT) Date: Mon, 3 Aug 2026 14:13:14 +0100 From: Nuno =?utf-8?B?U8Oh?= To: phucduc.bui@gmail.com Cc: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , nuno.sa@analog.com, Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Steven Eckhoff , Srinivas Kandagatla , Kuninori Morimoto , Charles Keepax , Linus Walleij , u.kleine-koenig@baylibre.com, Thorsten Blum , Kees Cook , Chen Ni , Bartosz Golaszewski , Shengjiu Wang , Sebastian Krzyszkowiak , Pengpeng Hou , Richard Fitzgerald , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 01/26] ASoC: codecs: sigmadsp: Use guard() for mutex locks Message-ID: References: <20260727094046.23001-1-phucduc.bui@gmail.com> <20260727094046.23001-2-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260727094046.23001-2-phucduc.bui@gmail.com> On Mon, Jul 27, 2026 at 04:40:21PM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > Clean up the code using guard() for mutex locks. > Merely code refactoring, and no behavior change. > > Signed-off-by: bui duc phuc > --- Reviewed-by: Nuno Sá > sound/soc/codecs/sigmadsp.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c > index 2e08fde3989c..b7dbeb237447 100644 > --- a/sound/soc/codecs/sigmadsp.c > +++ b/sound/soc/codecs/sigmadsp.c > @@ -5,6 +5,7 @@ > * Copyright 2009-2014 Analog Devices Inc. > */ > > +#include > #include > #include > #include > @@ -135,7 +136,7 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, > uint8_t *data; > int ret = 0; > > - mutex_lock(&sigmadsp->lock); > + guard(mutex)(&sigmadsp->lock); > > data = ucontrol->value.bytes.data; > > @@ -148,8 +149,6 @@ static int sigmadsp_ctrl_put(struct snd_kcontrol *kcontrol, > ctrl->cached = true; > } > > - mutex_unlock(&sigmadsp->lock); > - > return ret; > } > > @@ -160,7 +159,7 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, > struct sigmadsp *sigmadsp = snd_kcontrol_chip(kcontrol); > int ret = 0; > > - mutex_lock(&sigmadsp->lock); > + guard(mutex)(&sigmadsp->lock); > > if (!ctrl->cached) { > ret = sigmadsp_read(sigmadsp, ctrl->addr, ctrl->cache, > @@ -174,8 +173,6 @@ static int sigmadsp_ctrl_get(struct snd_kcontrol *kcontrol, > ctrl->num_bytes); > } > > - mutex_unlock(&sigmadsp->lock); > - > return ret; > } > > @@ -677,10 +674,10 @@ static void sigmadsp_activate_ctrl(struct sigmadsp *sigmadsp, > return; > changed = snd_ctl_activate_id(card, &ctrl->kcontrol->id, active); > if (active && changed > 0) { > - mutex_lock(&sigmadsp->lock); > - if (ctrl->cached) > - sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); > - mutex_unlock(&sigmadsp->lock); > + scoped_guard(mutex, &sigmadsp->lock) { > + if (ctrl->cached) > + sigmadsp_ctrl_write(sigmadsp, ctrl, ctrl->cache); > + } > } > } > > -- > 2.43.0 >