From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31DC83B7B8C for ; Mon, 3 Aug 2026 14:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785768547; cv=none; b=o71Cti9milwXMuwTiERwWkcff/G9/sBB/Q/0mGe9tHnnYfI4zZBZlxfwFEYUlPMlbLded5zo9Sa7d0n1X+CvQ8JtS2dzMjSEM/DazjeHaozdz9OKQwX3KLVcMOOkOicH3DinNxiDvuvhnCgyrII940EByl6niekD7HC543kAdqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785768547; c=relaxed/simple; bh=OrkJ17+vCAsRIQXuaRNBuz1299LRR2+fMs7PjNpccUs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L88slc5gr0GIh9ySq8sIMH70jOMmGx29ucOjDeBqRGEWUVJPgWBr5ae0B6EzdxFNygqyLuJF0wuxQbiZAh7rN4pfD1eI8xFFxy6ss1zLHlnwWthrGMagKAF3IfPSxFwnr8eVMVO758Ii3SIMMdvN7iBopISQm4ads1reqBOP5VY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=SlTp34eH; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="SlTp34eH" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-51c5382806fso32892871cf.2 for ; Mon, 03 Aug 2026 07:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1785768544; x=1786373344; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BPe4gHIdFNPXlT0kLvLSW569L8hxSCoFqSGU6JskmWo=; b=SlTp34eHKTgjmMi7VUTpMYSMsYlJzxmqVBknrvYnxSbvb9AlVYKndpVSNsM6V/h3oj dNioIpvUm/3H+AC1Buty2un9LiamGp5GyVouBqKazxIO+Q5pnXC+tjyltWEYeKm0hUmo Ir2/HWuutTPVOsg3L7ru67AS4LDUiRzWdrkeTzaT9lhgqzzIZ6kSJNtFs8yMLF/NdgWD r5Azc+VAgD4Qbha7Sl1OBwGlv4rBSH3sr5yXV2gq65yBBcdVLThNrawE2KxvsY5oB1iI b1CjDfQToX8Z0pQvk43rLCual862w23/90MFPHmk8O7AWWIsRZvr12/8CRxqc0UPbP5L jHew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785768544; x=1786373344; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BPe4gHIdFNPXlT0kLvLSW569L8hxSCoFqSGU6JskmWo=; b=UBOUAwNUEmBEUPsaDCpTJfk5MgSc/lQJnn7eY3r2M7tSdflQh+gwJ5wBuMD7vf9PCQ ohBpcG8Gh6JzwSGjkl/XvZQ6LLetqraDzBGJGvwALPXhtNNdrb8SQpFgdrB1VaX1OJiZ 9IWpDc4dI7AGKqvnxKAjNr4tShmSHM5p4Gmh6ypImd9zYnAlCyW0W337LdNBoCQHU9Vg 6PQLzDYVnzHcDonKp7iO0TorqVNJd2gyx0KpRnMI+KVTCSfwnHYPnTmstFaAQ9lZRepi A8JRthr8xRW+FFVgNttVQDl9PeJ+pA38pD4xsRCogfP+WOlkZfeCvEzyafOctIOvLMlr k2Yw== X-Forwarded-Encrypted: i=1; AHgh+RquAfVaSp5KGHtlJXiu4dGpXt3rwdSg7C9Iy3pDqrR6sexEHnbf4cbkir090ov3z/CPVw4OJ2k/tlYPMlg=@vger.kernel.org X-Gm-Message-State: AOJu0YzI4E5WIoNAkdqUgCyj0oXLPh2kjwqYwm4qCiDcomB228wbzzNK 1oB2LnXVvFDs9+mAqAbF/CerM72NLqjxrIQa3wSWXAhkNMmLGsCTZSuWWY35zbDkPsM= X-Gm-Gg: AR+sD11ju0JemN0tiFuPmMqR3v1BTI4/3Z+rLscNWnbVec8MMO/FBP3a8JIDdKn+sGQ s7QA265CpJDP1hMcGHKMZOkO4zhrnyso4xtj0+XH2cToEiS+VIInNlJNnNaD+ikyCjXUxuD8etn 3SuuIefyDoL0ooDN8IiTpCHLrZWtqqtauMB586g8AAftDU5qPbGCzbpC2acGd8I5IqhXOcT35nD dwFaa/l1IuJS36fn9gFPtikwzXLJTiFPNsRedUV1JHTUWUioHMNw8K2wZotXF0dRxdRFMf02RWb bvRRxyjV0hZxFJb0/dYxE/83IdEAEi+alBqYZ911BGMIrvSRa9+ak+UQjULgOIGINlralVE5Frh XYx/QSUvSozceCCG37Wups/rQwvlOebvzoaw2pYlMjOkPwI7IkFRRFwvMRPPc7hxrRxB8BhKwJ5 3oGXa0S+0VYOj//Hj74KC2cpjZ7HY4Qq97dvsADGywu8K78kodUTQz+GQUNVE63PeuY5rMspVPW ARKI/NJ7DoZaHc/xCBj0CJZSe3ekz/aGfx26M6pWo6w X-Received: by 2002:a05:622a:5145:b0:516:ed02:c85d with SMTP id d75a77b69052e-52b5666f9c1mr211511451cf.3.1785768543910; Mon, 03 Aug 2026 07:49:03 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52b4eb96ad0sm62590271cf.23.2026.08.03.07.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:49:03 -0700 (PDT) Date: Mon, 3 Aug 2026 10:49:01 -0400 From: Gregory Price To: Ackerley Tng Cc: Alistair Popple , Andrew Morton , Byungchul Park , David Hildenbrand , Joshua Hahn , Matthew Brost , Muchun Song , Oscar Salvador , Rakie Kim , Ying Huang , Zi Yan , erdemaktas@google.com, fvdl@google.com, jiaqiyan@google.com, jthoughton@google.com, mhocko@kernel.org, michael.roth@amd.com, pasha.tatashin@soleen.com, pbonzini@redhat.com, peterx@redhat.com, pratyush@kernel.org, rick.p.edgecombe@intel.com, rientjes@google.com, roman.gushchin@linux.dev, seanjc@google.com, shakeel.butt@linux.dev, shivankg@amd.com, vannapurve@google.com, yan.y.zhao@intel.com, Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 1/3] mm: hugetlb: Consolidate interpretation of gbl_chg within alloc_hugetlb_folio() Message-ID: References: <20260803-hugetlb-mpol-interpretation-v5-0-af2b7089f8a9@google.com> <20260803-hugetlb-mpol-interpretation-v5-1-af2b7089f8a9@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260803-hugetlb-mpol-interpretation-v5-1-af2b7089f8a9@google.com> On Mon, Aug 03, 2026 at 06:37:58AM -0700, Ackerley Tng wrote: > The dequeue_hugetlb_folio_vma() function currently handles the gbl_chg > parameter to determine if a folio can be dequeued based on global page > availability. This leaks reservation-specific logic into the dequeueing > path. > > Relocate this logic to alloc_hugetlb_folio() so that > dequeue_hugetlb_folio_vma() focuses solely on selecting and dequeuing a > folio. In alloc_hugetlb_folio(), only attempt to dequeue a folio if a > reservation exists (gbl_chg == 0) or if there are available huge pages in > the global pool. > > No functional change intended. > > Reviewed-by: James Houghton > Acked-by: Oscar Salvador > Reviewed-by: Joshua Hahn > Signed-off-by: Ackerley Tng Reviewed-by: Gregory Price