From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 642E7343893 for ; Mon, 3 Aug 2026 14:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785769189; cv=none; b=CV0UN1DtuyRXWszqZwFqsVD3fF6rxlCSGOA5qF0RVU0C+gCbEuX1Q5fWKFvbRQFOig8Y3Q36oYF/suEX+W99l0+1QsVzcCeYYmAjxK5IXKezrjvDnJNBl/jEQBlpD5BmrTk28zdGa6apW9gRDRPM78AiIKBKOFbLXwD+DImI/us= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785769189; c=relaxed/simple; bh=m7IUBNA3PUHIwAtQ7rPyJ5R6i+Bm5Q8MmnPoqsU+4I0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PRgM8TvGIEPU9WTfk3EKS3LXelEv6z16m35GClKBdj6Sir4nhdnpq/0BT8Ksn5TpeN9t4gYRe+OOdCFP2HHvz9qErrH5xA0TqUX+gCilCUC8rRe57oyVKz9Q+lzBP1U4xNYlF2HlWxJOKiBD/I5ldZ9B3ORVZU98F1kkziXjxWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=POK5XcvO; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="POK5XcvO" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-934956bee57so299170685a.2 for ; Mon, 03 Aug 2026 07:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1785769186; x=1786373986; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=53dYbIroP5cNJFfZLCrtYqk/aTOAkqcu4BnJ3vI5eGA=; b=POK5XcvO+Uc4LzZEBltOwP0n/lRHju9NJjDOchErl8reXSTTqnvaZta55TkoQsBnXo JQ11EpAKsvPFv5xxmSZzyhabP5cjatMZRFigDTEW0vWDS7rudVSrb2lCEkIgn8XARFij PvcWxhYXhSmSOWIVahLaE8NtERGbQi1KNlr+4d4ZN/ylk+cUSfhCQeCePvdcKKfXu/E6 L2OzIjicGjueHyAkeDfPTvekaw5XTaRRv5tvFzIFcffZtVn7DXxmPdsRubr2VJMhzAoe r97uc9EUDJSfnhJqbMdG0i7ay8YgEft1uRghj7mM0hghonRPJ+vhnB7cw5n4g6cSY5KN TYDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785769186; x=1786373986; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=53dYbIroP5cNJFfZLCrtYqk/aTOAkqcu4BnJ3vI5eGA=; b=BXhTeDQZ08TaZDoV4pTQVycJ927cp7zS1gd2ue4WPp2ANvzJX1Lhn7h3+wAvCFixgs agT7AvcB3gFYan0F1nSCIie2zNIeAUjDq/BiCaltJzJZNAk8BzBTm4Ep4EAy18jnF+4W nk1RZgDWXgJiCcKYvsFvF++8qij1YpNYBz4SWj2deBZs72GrlXxBqEXJcoulXbBfQgmG 53vkbfvvnSFuip6LAlEsm0T8/dHsIEjGzlng7qWEwciXCwOtcWuogSXx6QsBImyz6Gae RnzR0bccOEqgvEvTQL6h6CNUWe6NkDiIh2Of1ZUXLqWGbpommqsucDPXqm+pEy02Am/L SPgA== X-Forwarded-Encrypted: i=1; AHgh+RpNxodCaNQzFB5nSQXFQ31PlQ1jDzEgAb7gJxCQHqvz9KCtemRes4PNSpxxcarr+oONFbMGShN0RU9PaRs=@vger.kernel.org X-Gm-Message-State: AOJu0YxFM6HgwJKzIK2hHhAc9YpQZCDrYgoZm9nJhLCkl88oqNJCTnW/ 2OPB9CchUw85k4fJ2nX9XICnnCFB1dWEv0A3h3c83hHq64Sqrs0QK5pFcINtB7G5GvI= X-Gm-Gg: AR+sD10wn65jsiBj3xGVG7ZCrlIUDPVeuk7m02tzHw1YQNlOyVea4ZfQANufWlzI8Fp w0bzfB38yo6hBTMNQrqoIojV1KB09fnxM9N1hfp2wfY8widgKT3+zT2+2B6TTAQW+7CrqmtMgUH TVuafSQ/APPQi/H2tk8aZY+MsOGfvko0Ld2yOGPOMxdEl7sgCQt1NjR0lBK8J5NqiwZgsOlYsQ/ SRTn+xMCJogCyllrSfXOMiaVcm1nEwzHx10V/C4FT07jIev3SzCJQrDzTXsWwRKIVOcr/U5fs2w Yi47jn5Hkw/68HEVqmJbfeOR6/qylvnXlUxyZhmHkvz1NFDy6zaf67Pw36x5DMmbvrhevzwzsFi iKP5Zf5Gp9VVE8FZ15ucEzFD/kQiRSbyMKUpidAPLkvd1P93Ksb31523aBrrQqFc/R4rfmw10fl AWV+Q8XNS0ZgZXehi4AThlo06+NMZxQtYRFHIwORgKjew1VczkM/R6x+AlNajuj1VpHP/bxgwbb lCaUdKThd2OFAT9E+Rr38W9pO5DeHo4gbKszKThoraA X-Received: by 2002:a05:620a:5be3:b0:932:df7e:b31d with SMTP id af79cd13be357-934a0784031mr1438847385a.12.1785769185244; Mon, 03 Aug 2026 07:59:45 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9349c1c1cdcsm685303285a.34.2026.08.03.07.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:59:44 -0700 (PDT) Date: Mon, 3 Aug 2026 10:59:42 -0400 From: Gregory Price To: Ackerley Tng Cc: Alistair Popple , Andrew Morton , Byungchul Park , David Hildenbrand , Joshua Hahn , Matthew Brost , Muchun Song , Oscar Salvador , Rakie Kim , Ying Huang , Zi Yan , erdemaktas@google.com, fvdl@google.com, jiaqiyan@google.com, jthoughton@google.com, mhocko@kernel.org, michael.roth@amd.com, pasha.tatashin@soleen.com, pbonzini@redhat.com, peterx@redhat.com, pratyush@kernel.org, rick.p.edgecombe@intel.com, rientjes@google.com, roman.gushchin@linux.dev, seanjc@google.com, shakeel.butt@linux.dev, shivankg@amd.com, vannapurve@google.com, yan.y.zhao@intel.com, Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 3/3] mm: hugetlb: Move mpol interpretation out of dequeue_hugetlb_folio_vma() Message-ID: References: <20260803-hugetlb-mpol-interpretation-v5-0-af2b7089f8a9@google.com> <20260803-hugetlb-mpol-interpretation-v5-3-af2b7089f8a9@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260803-hugetlb-mpol-interpretation-v5-3-af2b7089f8a9@google.com> On Mon, Aug 03, 2026 at 06:38:00AM -0700, Ackerley Tng wrote: ... snip ... > @@ -2925,35 +2935,23 @@ struct folio *alloc_hugetlb_folio(struct vm_area_struct *vma, > */ > folio = NULL; > if (!gbl_chg || available_huge_pages(h)) > - folio = dequeue_hugetlb_folio_vma(h, vma, addr); > + folio = dequeue_hugetlb_folio(h, gfp, &mpoli); > > if (!folio) { > - struct mempolicy_interpreted mpoli; > - struct mempolicy *mpol; > - nodemask_t *nodemask; > - int nid; > - > spin_unlock_irq(&hugetlb_lock); > - nid = huge_node(vma, addr, gfp, &mpol, &nodemask); > - mpoli = (struct mempolicy_interpreted){ > - .nid = nid, > -#ifdef CONFIG_NUMA > - .mode = mpol ? mpol->mode : MPOL_DEFAULT, > -#else > - .mode = MPOL_DEFAULT, > -#endif > - .nodemask = nodemask, > - }; Bah, mea culpa on prior comment, i did not notice this was a prexisting patterns. This is frustrating to say the least. It does seem like there should be a better way to do this, but i think we should be ok with this for now. Reviewed-by: Gregory Price (Meta)