From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88B372DCC05 for ; Tue, 4 Aug 2026 05:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785821531; cv=none; b=qSPn1AuC2Mx4pavHsz3dtW+FUkdXKy8rtftFtukkJYKuCTo1KzcANtRNhpSgOt7Xi9xLIl9JHNbWhGQcNOeABUB9ZitTU6vdXi5Z4EQiJ3TLMu6l3cL3+12bA0SQZ+aOqgRRtQ3geqFUwPBX2iKPy6q1IwMDouw7ioidn8zOfg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785821531; c=relaxed/simple; bh=IAA8nFUZpC/UPplaX0lplMjH/PVZvv2wQ41dchLY7OA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WBID4mADk9VWFAHyFQJhP5RrDUPQYWZnXCvT2pcipfGdQh9/lvDnsh7m0/w+407n9liD4vOIPJo6UOiTvBt1ltKH3aRq/BJWU069XqCoPFWDjcSyMbJ6E6YuLuXursjWl0fxoJA3DenRpShzD08F9uEM/Z8XHbXra0VtkidMitE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=WNEYCCst; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WNEYCCst" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2cc7ef7ec27so46901845ad.1 for ; Mon, 03 Aug 2026 22:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785821530; x=1786426330; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+B3M0tFqnJnc29FP5kYp7HH8DS15buEwgObTWQDsxOU=; b=WNEYCCstOc6FR/4rzM5giabmLGkghOcM3gEw+PneE1r2m0g9eHFH+KBjBcp3iGkJN2 62krzBuhI4ffpyqkDAVwPeedacXFLZ99jpQTVdBaqgSE7AuHg6zGpH7qLVRKC/TiLkT1 1YtOTipG26gxOxteSiMyPo2MB3C379iGKsNLc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785821530; x=1786426330; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+B3M0tFqnJnc29FP5kYp7HH8DS15buEwgObTWQDsxOU=; b=VHMU4yJi5AMkj5TU5lt54wM1GZIiO3MkQoOAP0M2ckPWESt0pGT6mrQa0QhpH4DezU +sxp6ExHmj0TDKq7aSQQPNoU3f60MGYDN9PyQ/jc879hW2UirlsMLJrZfCXum2U+x7Cr +BdTOZ50sfM/MKA+0MO2Nz00//XzEhIKkjqeOOMaK4Fl4KQf39+juRVg0ZkaS/xuVwH9 jjWe4LV6T2kYgz9cew9wYFbTGOzflB8jg0kzmipSoy4gUaOy59ZZM/nxGR6ID6mtFRxH ZPBS5CohWfAUNKc8586s2mgzVwnIon8EvZNRyapEKj5mfwy5s/mTrgV3R4KqJOji1TOK 3Wtw== X-Forwarded-Encrypted: i=1; AHgh+RothDUnPkkife8vkNmIvCMiodLkCDm+1R+9qgvoxTpVGodrABnMCST2VTLKG/9jSF08FoC1hQMOsthhiIs=@vger.kernel.org X-Gm-Message-State: AOJu0YyG3LRJg7Pm7t6bRPPRNgbd+Mma8rVvD1Jv2CITXhP1e08Dt1jA UBpfe6rzrfKoAKoE/oiiz/aiN2TDketpy+KAtrw8eufCPYKq1aK7APGc5r6yhNva/Q== X-Gm-Gg: AR+sD13BibNVT68SA448UnOAwuJ7KJEmoC43P8ydHQwRpjqK16/2Us7asTmpKA0jQcs XQQ2WvZjfNhDsc/Apg9axKC0S5YjV5yn7KoGXJWeCpmQL5MmKVj0NNQ6GKAjADZbHwk/ZKkvfu9 5jJMGcjSrqb8Zd3W2Zoq8yd06cCbdprti/pXP3473pGYE/H7On8bI5cFyFWMX8YUsHFrF+8A+IA ScuoBVLSVFBo1Pp0xPHGvW8scLoxAGw7L9hwfO4J42UZZAuRRbJ0OLEl+2D2xBsaX9eyP8RCnbf ZSugiodgUwmcb+j/y0+GqNUViszAg5bIhw2ezmeoWAYrWrVo4Ywh6+u4jOqi5CdTvoXx/VUwPAA 4a8ALVkfQ0YyL8CW2hcSpozLt9nbx2gGo5MovwLUb4NAyeYgdt8kB5w/d14riFnfH1X3mxbQOYC Pw2rEBuP4r/N2wAkzUapDPXfjUo8NQgRRoxCsJrrVZY1gQ17LtTdKDGlg9MGDln1kgzbYSAeJgT etBSJs9am0Q/dTKDamvUAnLP+J7 X-Received: by 2002:a17:902:d98b:b0:2ca:20b1:3e0a with SMTP id d9443c01a7336-2d05219bb8fmr144584255ad.3.1785821529951; Mon, 03 Aug 2026 22:32:09 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:fcb5:533d:198b:8d48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04ae5ea02sm46456715ad.28.2026.08.03.22.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 22:32:09 -0700 (PDT) Date: Tue, 4 Aug 2026 14:32:04 +0900 From: Sergey Senozhatsky To: Haoqin Huang Cc: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: Re: [PATCH v5 2/4] zram: reject zero-size dictionary Message-ID: References: <20260730060133.80233-1-haoqinhuang7@gmail.com> <20260803141256.60599-1-haoqinhuang7@gmail.com> <20260803141256.60599-3-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260803141256.60599-3-haoqinhuang7@gmail.com> On (26/08/03 22:12), Haoqin Huang wrote: [..] > @@ -1700,8 +1700,12 @@ static int comp_params_store(struct zram *zram, u32 prio, s32 level, > INT_MAX, > NULL, > READING_POLICY); > - if (sz < 0) > + if (sz <= 0) { > + pr_err("failed to load dictionary %s (err=%zd)\n", > + dict_path, sz); So for empty file this will read "failed to load dictionary foo-bar (err=0)" which might be confusing. I wonder if we want to separate these two: if (sz < 0) { pr_err("failed to load dictionary %s (err=%zd)\n", dict_path, sz); return sz; } if (sz == 0) { pr_err("failed to load dictionary %s (empty file)\n", dict_path); return -EINVAL; }