From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E56EE2D1911 for ; Tue, 4 Aug 2026 05:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785821828; cv=none; b=mwV5KZD7M4FzH6N2FQRuaRO03SC3ms1k4D0+5HBVtQn3Cv+UgUtdQhnvAaSIjjI/nXfdd3cuowGgEIuA4VAJuzx7tJRcl2DDRIu35IcGSRjFhb37LZBrK1YGfGzNH61JG3NXnJ8FNjCK5wLr92LN4JYXlX97h6pYWXrbRZtup7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785821828; c=relaxed/simple; bh=yD3cgIiagIgqlzaUUHpVETjAxdNWdFZWkRrPnWKa1mM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z1Nv+uOzQekCQ2V0PNBfLwDW4tb+XznviGJ5XRa7s3/Qa87w6rKd8PgRn5ddyP76x3/rDj49RoQ5EdtVySZfQ7gy9To2VhN4akkT+gjqu3HIZ9AVpdBT1TVwnwLY+6CLTpCbp4AKI5rkynrrezpA9hfllvVvu8Q4TDLSwHGpuoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jM1mpY59; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jM1mpY59" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2cea3004256so46441535ad.0 for ; Mon, 03 Aug 2026 22:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785821826; x=1786426626; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=G1i0D2KmfuookTim9/62kIxo50WcIEe/kK0FsOm7UkM=; b=jM1mpY59KaPZQ7yl2oY8emNk3BSQTIG+yYKIuRZxw1PtmufivHQ40Pq8QtIn7rn6Ov fixPgpO0MB3/g7lNe8obKlmYpyZM0dz/OfS+7kSjS73PEIQD2vfS69S9xNGupD/XgxZx LmFdE2fE3mTthdK79Lgv83iZWl24e4roapT6c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785821826; x=1786426626; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=G1i0D2KmfuookTim9/62kIxo50WcIEe/kK0FsOm7UkM=; b=Ld53ZF0Yde6u0KFpKhoz4rrmUhASaQii2ptuaBM1Ax1rpw+M1aHIDNkwB9qSEeYen2 7uWCac8QrsEZGaR0aFWmZ4uc8ejTB1CS6aNgremSdn+Mj5m+kpJRVw+bkL84c9RKzlrS 3mP3P/OzXEde9GPpJenRunQMcBUkLXg4uMYPWgVEm8dV/jq2A+Pfp4vW3is29ZfW+Gm7 OraDYvMTZL5yT9yYiO1cXHmqBDFLqLgiF20RRGXE6s/VUjQ++EHzv13obNZ0pLparik3 eraJ4f6UqJgLTzDoLnA+lLD7BsPFswmRuTaUd+ReQYAfyTaSDPmu5v3/fTRxR4sAcPBQ eYOg== X-Forwarded-Encrypted: i=1; AHgh+RowGjiOQ6d69lwTcQ2pbN6dxZaNPR8atS9jrJjxyszXmVg8xiby4xuhczzGV5fyb+q1LAX2R8sShJ8hRYo=@vger.kernel.org X-Gm-Message-State: AOJu0YzXOZLWdjKNHbD+pe2ITHod7Vnr6a6hWjhrJouGrQw+wH2xjsye MtBGHy2CI83KbNNr0O4XxgzxN05r4zeqj6oYGPYRdkoqsZLnXMLEBkgZ8q0sz8ucbA== X-Gm-Gg: AR+sD13roA1YvcUxKdM6IWk2MRcdtYIIKHv+GWXpITJq5ixfISNWeOBfdhqGMZFvw4z N42rCOdQxfWqEatATxBhxxzxuCzgXmuvJfTU3+7cOSrQfpCIuyENDH8mlHpNtj0RI9dQW7CIyMP q/gwUrnVlfpwVVc5ykx37SJV21VH8ErWqKjcNibLsW4lToTPqpRXGRdtA/3DhkIWGetqXPcuYdb B1X0pjKGe3Nag2HSOUNIQmm0BHUDDuRSSUTkE/1vxooHj83g9+TLx8Ze1YI1ekK/wBPwcc77vrd JPF5L+jn0mC0pPQTPclcqFx3YYxUPTKDj5efchxMeDGjeYaWUANPY20wfHWQ4ylBUqER/ipv02d yfmzZF8JD9HlpdlN/Fvisvo5RIoYpq1PiYgYDwJQpD0fULfSZbGQDCL35iGk58emdleAENU1MXa VOPizTu2+Pc+Vyh62Bcl0yQrXMyev96Bd6pqZbnuli0IHq6B0ZYS3xx4C11AxXmz1OntBoZtKV9 +Dx17zpCvU5yjzS8QaTGXpplJmI X-Received: by 2002:a17:902:fd8b:b0:2cf:b68a:8b5 with SMTP id d9443c01a7336-2d05222b928mr128876165ad.14.1785821826166; Mon, 03 Aug 2026 22:37:06 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:fcb5:533d:198b:8d48]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04b1216bdsm47129115ad.69.2026.08.03.22.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 22:37:05 -0700 (PDT) Date: Tue, 4 Aug 2026 14:36:59 +0900 From: Sergey Senozhatsky To: Haoqin Huang Cc: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Nick Terrell , David Sterba , Andrew Morton , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang , Rongwei Wang Subject: Re: [PATCH v5 3/4] zram: validate parameters in each backend's setup_params Message-ID: References: <20260730060133.80233-1-haoqinhuang7@gmail.com> <20260803141256.60599-1-haoqinhuang7@gmail.com> <20260803141256.60599-4-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260803141256.60599-4-haoqinhuang7@gmail.com> On (26/08/03 22:12), Haoqin Huang wrote: > static int deflate_setup_params(struct zcomp_params *params) > { > + if (params->dict_sz) { > + pr_err("deflate: dictionary is not supported\n"); > + return -EOPNOTSUPP; > + } > + > if (params->level == ZCOMP_PARAM_NOT_SET) > params->level = Z_DEFAULT_COMPRESSION; If we want to be pedantic, then {} should also be added to the "if" in this case. And in other similar cases. > + else if (params->level < Z_DEFAULT_COMPRESSION || > + params->level > Z_BEST_COMPRESSION) { > + pr_err("deflate: invalid compression level %d\n", params->level); > + return -EINVAL; > + } > + [..] > + else if (params->level < 1 || params->level > LZ4HC_MAX_CLEVEL) { > + pr_err("lz4hc: invalid compression level %d\n", params->level); > + return -EINVAL; > + } Let's add a small comment justifying/explaining that "1" constant?