From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1729B437136 for ; Tue, 4 Aug 2026 09:53:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785837213; cv=none; b=FoxShhlowCJBUC0vyjEZjWzlRSUe87MZRjJLSu1X5OKQdlyC909Ha+s6i4Qyryj7jZrCAR/9KKiXrJfcquIgV3PD/NRT7AdcvJN5S0hveod78F9vFZRvx/lzFXBoxQSPfLOogv0JVASp5ZmjTkP8Vm+Kz3OJ9Yt4nfGUNQIPzoE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785837213; c=relaxed/simple; bh=CcMCdPBSDgbLDGGlL7AIiBX4whoy2+vE/FApkeH95bE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gbz7koYjV+ZKy5AH1s5ZVondV7+dxSCCHNVO6MlmhQIw68IT661AUqtBRrTsPWNRlaDGveCDV7TWvftI6p06DP7t3Kg8oL8EJ/t5Ua1PbnmKdnFHvDFziMABbdHKTYNtgOSsrgAg+txMzX4OhmYjRXv3tUL0tvJmeRVeLRPCLHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=l8GOOqFh; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="l8GOOqFh" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-8485ef63b68so4795159b3a.1 for ; Tue, 04 Aug 2026 02:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1785837211; x=1786442011; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=dDjsT2wG7owV0ZB7Il5NY4YqbWtuxqu2JnwZR2JRqSU=; b=l8GOOqFh32YnIcaRPND7vMd8KeO5huOc2+I9FMgosIY5PFc0StMwW60lhFWXEmPhxp K6U127U7Iz5siR76VzsEWohS8qo3tzZYqXCAS4M/B2dMGkRlGB6wbnEmirlb0oknjR7V bX5UICwLGMB1acNejLahgfsNVOAh54OvXIUFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785837211; x=1786442011; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dDjsT2wG7owV0ZB7Il5NY4YqbWtuxqu2JnwZR2JRqSU=; b=SGmAS5KBic+hDFepH5cdnfKIaIak1jAP7KaSTi/CTAk+ItMStmQO9qOdxVM+N5PG7v JIrK8QUWHcMqcVHKTGgIUlC5CYvKA4WiBvb+AUsUnOIyBBmYGLslCJ83PeW9DGjv697i 6ygDkbsjAnClTp+gjZRAExvA+ABVB85Z4gA4wrOHu6O1gD76Qdj0ODoVQUNae7N8Nj0n sWurecyFmaDoTEEGyXy+AcffQU+RGGyNXaVEkc2dAGqCI3pJyBLoyK8sNCnKZGqS+zvb F0+RPaT6RuAPmothIVqmMKc5EgsHLHCcQRz1COSlKVe5FN/4z/IYfYiJ6q348SLiIC0r l/5Q== X-Forwarded-Encrypted: i=1; AHgh+RqQi5SfFLb51Z56kvy1oAimTtKB7r/8txjW/fgdRSiKAasmrLiFzdrYyfM8t2To62eYLKYR4EYmB9YsHIw=@vger.kernel.org X-Gm-Message-State: AOJu0YzP8NJjSVEIEi/Z1XbvKWwH2873w4y4qj6TK/E8p7/mXrJCfofn PqrmfE08VQ8yPqmT3oOMDj2eAePJxRFpud1hBzakx3nMoYvldk9veWoGkGyc4FlwQw== X-Gm-Gg: AR+sD130bWw9KlBqDsRsjaoLqedCQd1qC3nIIKfyLMs4BEyzc+ygdO7xJA/j+PmcmOG xNzIm2QHIeqKjQYwMTSITggbdaATgIyYQ1vYPqpcXV2qjI5igJuunofNRXDRDsNt6YHdvsNvC8g A31FAuLJHcQ9GfD4ekQVa5E3iAqMqOk1SnKTQ5czTa0eP4M2PI/GhfFDzRcI6cX2eb7hI4LEe00 PIncKUHXfHcJ3/uFM9TKfyUaMgMhiGdHm6Jf+Gj26nDeI8NsXGUiA06QGNKU2EuIvVUrIsSSCIY YKQzi/sTYg+C88j6lVhpM7FJiEj1ibfZKptVmM+FcNVsVA1gei+NTsET1fh0gK2/GuXAFcIzRWJ 6WPJ0hqV+/Yxm42g0ltzptgnmTOKe2q/DKLSTNZ10vwMmmraf260SQa7iWaMtr71uSPezIoVZWd inkrcHnrr8c3yDVSVeLHZCMW2CDvGNG+Wkt+0kGH3sz22/q9ff/Xgu+Za6eW/GNMKdsv4rd70Xl uRWQeCE6hpa6XfKnHuXbw/UORlsiMvRKgpUX4Y= X-Received: by 2002:a05:6a00:9290:b0:84e:17ef:5460 with SMTP id d2e1a72fcca58-84ee4899c34mr12512541b3a.40.1785837211380; Tue, 04 Aug 2026 02:53:31 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:32eb:b46b:e9eb:65c5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84edc2d45afsm4874167b3a.41.2026.08.04.02.53.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 02:53:30 -0700 (PDT) Date: Tue, 4 Aug 2026 18:53:25 +0900 From: Sergey Senozhatsky To: Andrew Morton , Haoqin Huang Cc: Minchan Kim , Sergey Senozhatsky , Jens Axboe , Nick Terrell , David Sterba , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Haoqin Huang Subject: Re: [PATCH v6 0/5] zram: fix zstd error paths and add parameter validation Message-ID: References: <20260803141256.60599-1-haoqinhuang7@gmail.com> <20260804093841.67920-1-haoqinhuang7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260804093841.67920-1-haoqinhuang7@gmail.com> On (26/08/04 17:38), Haoqin Huang wrote: > From: Haoqin Huang > > Patch 1 removes zstd_release_params() from both zstd_create() and > zstd_setup_params() error paths -- the former is a layering violation > in a per-CPU callback, the latter is redundant as zcomp_init() already > calls release_params() on setup failure. > > Patch 2 rejects zero-size dictionaries and prints distinct error > messages for sz < 0 (returns the original error code) and sz == 0 > ("empty file"). Currently errors are silently swallowed. > > Patch 3 adds pr_fmt to each backend file so that pr_err() messages > are auto-prefixed with the algorithm name. > > Patch 4 validates dict and level parameters in each backend's > .setup_params(), rejecting unsupported combinations and out-of-range > levels. > > Patch 5 resets per-priority params on algorithm change before init. > > Changes since v5: > - Patch 2: split pr_err into sz < 0 and sz == 0 branches > - New patch 3: add pr_fmt to all backends; tweak winbits message; > add missing SPDX headers to lz4 and lz4hc > - Patch 4: removed inline algo-name prefixes (now handled by pr_fmt); > added comment for lz4hc < 1 lower bound; added braces to if > branches for consistency Reviewed-by: Sergey Senozhatsky