From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF3945C6F1 for ; Tue, 4 Aug 2026 11:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785842640; cv=none; b=kZ8nSH5MigAF6nwqaMtf0rxHwXjme2q7ziscSCGBKj1Ol2SiCrKwGAWPTz4jukgvBO74GP9aRv0heXLYh/FRYobpK8kBOJxwULZmprULBfY5lElstDFyV83cbLzhO864LwzNxmYIocJmQzPJWRaq0voEoGF1cFu1ihfQJkWluyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785842640; c=relaxed/simple; bh=dSqYtsfKFijnCsZOZ95MAlgSqmBheENypsz4hHbUyh8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MTjs6+3ZDqWQObaHLvGXFwdoqRl9+173S+ZkeVZBV75l4sfBeoLjpZLt4qnsgv0pCFZvmsbiZIEgXtqUik40fwLyrQHK4ehDBDbKMjiF24YddYQV7X6t8fkV+FmfVm+XbKpvoVbzsdbRsyUyNWfO0Z32f0vlZ13/7O6Q9K/7cZE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pSzp/OZz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bE+RH4lD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pSzp/OZz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bE+RH4lD" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6748wuVJ2726166 for ; Tue, 4 Aug 2026 11:23:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=z0kUAmeOvZB7aq8PtBEq+wMx JDgcUdO8yHMNm6TSqSk=; b=pSzp/OZzOLPvvX8qCOl7hxQw8WODYbzWyC7avT22 /vLBctRDf7OW+L8cMKXa5izb62xlTCrjp/VW1O2QTYtpJvOKeBBfIkrWKXu0qYHz dIvHoNEmp7FWDKpouUjo8eyS562SK005iHHN4/DD3vTEeD45F4LlF/sfXQYf81ul bMOMZ6egnuAA76Pcz4WTTQE0D3KxFE+8JZ/KQHnw2t3UnACPJp8rdYnbHD3AS7+f 1+q6gUc/Z7vMlJi7cLpohfARu7uXk8JfHODNAYsMCIBCXBt+tXAjLaI9yS/098r9 8NMqhNOdNnvUKdPG0Gc3iuCX9qmEfSOAnAEOyH1AJACeMg== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fud23ghn2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 11:23:57 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cbb6433e9d4so5972432a12.3 for ; Tue, 04 Aug 2026 04:23:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785842637; x=1786447437; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=z0kUAmeOvZB7aq8PtBEq+wMxJDgcUdO8yHMNm6TSqSk=; b=bE+RH4lDvxi2tkbYHI2r5iJjPKkl6AuKEAxpR+yJfpQYjot3HKMnHPgCPSgpQ1k+lm TqOB9Ji8spnknE2JQnK6H8X2TesY7kNUxkoZ1u1E8+7zfoU0+9XlLoyQWW8dVH4L5Y7m cKBynzoV94VQT8umZbeEQVQW/Dbx3ce/qu5/qt1BWw9To7xMsmFbM/q9X4zaCYY7nTNP sSEffEBph/omQ5Yz5xXQ5anShjqzgVn7DOCLEIUmC4K8L17sB5gwEANlEUVx6iI3ERDr jeDhkD0EHMlgstqBtAHOHIHi71ji9sIDCE60Qa8gS+pCNvl3tEY1klscqwpfc0xajKKp VrJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785842637; x=1786447437; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z0kUAmeOvZB7aq8PtBEq+wMxJDgcUdO8yHMNm6TSqSk=; b=J3arowvB35iMnOq287baM4rAMHQLspJHIYBmIoqHexqA/bIR5PkNSdRZpigzUstshv y+BC8E12plTQ8ObKEf7yeVq/qDnAKn6xOVXpbydHiJwgZ1LirigwH+pKcHE8soNF0PU5 Q084SDo2pQvxTZP/EgnEZkjdviDwRKZGzKE0Oifuxtu3lHFlS1xl5cKz4u/iHznOl+hs E19ZgIPvjQp0D3AoO8neDutK++SmwfUIYI48n8dydstvumkwVDtNNpYnWJrS/RHJdqVK /baYQArHPsJvAKEmZgv5BSc85Je3OKqIbRFRyQWmdPeIIaIUoHpFo0Vr6HtV+Jn/VjeZ u8nw== X-Forwarded-Encrypted: i=1; AHgh+RoKVy9Ntf9h5d/eD9X648G55gfQYhyz4VbJQ3CVXftMeWqvuEQt30wEOGCzltTK4mVLDYYJTplWfHW6Knc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6Iyw0T4foy6eIEP8TSB8j4S7FNM00DlDbL0eLuI1X+cesxu+r MzuBCEdW7t+bRWWVvw5wvtS0IRVlwnCnpQtslioTuevlAV8AY1cCLbBAmg0U5+pANZdevlVI+5o 9l9FM6JnTiR8w8AvYiILTQ1E8tyqoLTItAPVNs0tUG03CxyK5p+cXLbdP6+EthdmshacAExqVRr U= X-Gm-Gg: AR+sD10BtaDxwA7YE3RC/7NEZU7PK/RTyZwQIF4x5EH7iXk1UlPmcgyMvl5RMCJG6wy ksaVBJpxOP27LsgkzFskSPjXpdu3FWrH+RuGxGyRg08YjCLhLiPa36vIeK1MVBeQ+q5FlkezPx4 bKjO99iNkRLlqW5GuSdvP5yO/ZHs5dDfKV+Yrxp8+u1Kyv3Sp125nmpDKNrQJhxqCYGe4vWDISt VvJTTJCvTipq1Xdan4dPENhFulIuOCn7MC8i5GgGfTPJ8I7ZIiyxvj+Uj37jpeIt7QXDbisz+FR tf7B1CAEsxDsQI9dRuOcElgK/S+XmYab9oqqgvUJ5Df46C6zTjUHofrSpf/LateaUspHAy/97qv q2JeAdSuOEMErsK7JzBDfCqoK47qLMfRaBV15HPj/xsCZ76Xm9Vm1hCCqQtIUID7tKfv6+PR8uI 1CA44UMvHQxhs6kRI73F5zCTod70SCwg== X-Received: by 2002:a05:6a21:9cca:b0:3bf:6c08:fba7 with SMTP id adf61e73a8af0-3c92a84ec9amr14379009637.59.1785842637159; Tue, 04 Aug 2026 04:23:57 -0700 (PDT) X-Received: by 2002:a05:6a21:9cca:b0:3bf:6c08:fba7 with SMTP id adf61e73a8af0-3c92a84ec9amr14378980637.59.1785842636763; Tue, 04 Aug 2026 04:23:56 -0700 (PDT) Received: from hu-varada-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3158673be4dsm5730394eec.16.2026.08.04.04.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 04:23:56 -0700 (PDT) Date: Tue, 4 Aug 2026 16:53:48 +0530 From: Varadarajan Narayanan To: Mukesh Ojha Cc: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manikanta Mylavarapu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio , Gokul Sriram Palanisamy , Dmitry Baryshkov , Vignesh Viswanathan Subject: Re: [PATCH v14 1/9] firmware: qcom_scm: ipq5332: add support to pass metadata size Message-ID: References: <20260803-rproc-v14-0-a1f87b0b0ad2@oss.qualcomm.com> <20260803-rproc-v14-1-a1f87b0b0ad2@oss.qualcomm.com> <20260803123537.utocak6hvhl5ijqh@hu-mojha-hyd.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260803123537.utocak6hvhl5ijqh@hu-mojha-hyd.qualcomm.com> X-Proofpoint-ORIG-GUID: EG1uLVxGJ5fOtXAn50vGo1gBe7RQnJfr X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDA5MCBTYWx0ZWRfX9KZgfcz8VHSZ e+DmY2QwofuaCEFxgFzBmHj2xWv6CfSbniXCu5eAUMNBrCP4J47olTeRI9ewTkkg9JiQN1MlcvJ uXmotOW46L+3jaLk+H0CG+QVZ+tMOXA= X-Authority-Analysis: v=2.4 cv=XIkAjwhE c=1 sm=1 tr=0 ts=6a71cbcd cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=W_EDbNz8WyltxIkMcgYA:9 a=CjuIK1q_8ugA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-GUID: EG1uLVxGJ5fOtXAn50vGo1gBe7RQnJfr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDA5MCBTYWx0ZWRfXxEWoOz4NyKkA 5c02NPJPwGGfSrrOkBD0U0c+hjV3oNFECb4H0BZ6sdwHQ+b61pMVJfUx+ZK0B7C0B3A7E1MV+w6 X3CHhWqFMXz7apN6Zw6kcdhBOx+/lzf+gt3zpeGzMDjV6RvYPGSYcME3gez8cv+47b2JR/DjxpK jTRSLkuNCmvmHuMWEmKYO/0i/ZuFoQnLqiV9xUD7Tc79Vs0mM7BxhT63/dUs0JL2JfmoZFZxA9S YvrOii1qcHMX3f0jtdj14dViqjgrgE6Zu17TZxQmuVcEcbNfvKgSSBmdBtnnnKr+lIooL9IkLin yOsfZ8reybNJ16eXz+PGAZXYhGpyvQXZROJg+aOmUSUP2UwxuBARD8Gh6VviYnStmWHUzufBDiF J6jMtW0+Uk3KWpXlZPTi8zF76FkWY927apK+L5Yt6zwNqxidaA4TwkZUXwTn4/7xbCNwgZvRsH6 SCExorKftLcE60ch8JA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_02,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 malwarescore=0 adultscore=0 impostorscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040090 Mukesh, [ . . . ] > > if (IS_ERR(gunyah_wdt_dev)) { > > - dev_err(scm->dev, "Failed to register Gunyah watchdog device: %ld\n", > > + dev_err(scm->dev, "Failed to register Gunyah watchdog device: %pe\n", > > stray change.. Based on AI feedhack changed %ld to %pe to print PTR_ERR. Thanks Varada > > PTR_ERR(gunyah_wdt_dev)); > > return; > > } > > diff --git a/drivers/firmware/qcom/qcom_scm.h b/drivers/firmware/qcom/qcom_scm.h > > index cf90a565fdfb..e58c76aba45c 100644 > > --- a/drivers/firmware/qcom/qcom_scm.h > > +++ b/drivers/firmware/qcom/qcom_scm.h > > @@ -105,6 +105,7 @@ int qcom_scm_shm_bridge_enable(struct device *scm_dev); > > #define QCOM_SCM_PIL_PAS_SHUTDOWN 0x06 > > #define QCOM_SCM_PIL_PAS_IS_SUPPORTED 0x07 > > #define QCOM_SCM_PIL_PAS_MSS_RESET 0x0a > > +#define QCOM_SCM_PIL_PAS_INIT_IMAGE_V2 0x1a > > #define QCOM_SCM_PIL_PAS_GET_RSCTABLE 0x21 > > > > #define QCOM_SCM_SVC_IO 0x05 > > > > -- > > 2.34.1 > > > > Otherwise, looks fine. > > Reviewed-by: Mukesh Ojha > > -- > -Mukesh Ojha