From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E413468C20 for ; Tue, 4 Aug 2026 13:51:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785851495; cv=none; b=NjFC7lOkxtOUPVCpcBJmdV6nYv/UpQTkavoXi5iISyfuOBduMQDEcNEgp6JLqv/XoEixXOp5kMLDyB4GX2Idj0OiERIDxwFousM/pwh1SK3kK2d0X5+yDqIO83G5qOZPF5QFS2MLJfWYyvBDOluwPF6YxZhZeRIpdH6NB5+wtTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785851495; c=relaxed/simple; bh=hbrdtAk6sCR1k0zq57qNiOOiDuNn898n1D59IBoLlbc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nuqLXP41uBabHsQ7PlWXZe84Uuaxs0eh9eaKMn3kAZ9wwbDnzfd69S6Efly+BVz65tnfF6n+7Uj7IiBnVl+xLAWNG2trYBfx+kvRW7Gnbyw0y8GYwFWkawSt/WsEEBgSbFHRBcc/NBqga42tDZ+D4bAQSKHlhBNaXNGgfIZMECI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iyJ0wXMf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iyJ0wXMf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 331CE1F000E9; Tue, 4 Aug 2026 13:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785851494; bh=T5mY/j+OmwUsgyWxYodxrd+PBskI/mrpKfPAo4uWVn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=iyJ0wXMfaR5dzmHJj3nMatbYEy47gtxGAaQxZ0dRwLBersf0RYRiMqPW6MSONURKp Mx/4+zzzWmZa5b6xuXsAnrkILVzSCXLRsm45N/1dJZzCGCSQFiUtgWwS0QTONjTgRq ho2N9WlXFQkXO0x9Jcu/uCCZ6zuuxv1VGe8YMIzQMtidfMhzn1E/Dgbkvel9NuXwKO KBbEt87ZDXj5HiKUOSJnyrSx3yIY77yvaDVhHvkfXBKvYuspfma+mXANWvbDHc1a9C ZIfl7Q6NTSlNHnNkBSxYDvbp+B7TyySMIpV2rcdGYTHQO8d73xGOGE3ppkkpwypIhG 9rfPv3GfZo6bA== Date: Tue, 4 Aug 2026 14:51:28 +0100 From: Will Deacon To: Linu Cherian Cc: Catalin Marinas , Ryan Roberts , Kevin Brodsky , Anshuman Khandual , Suzuki K Poulose , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Gavin Shan Subject: Re: [PATCH v4 6/6] arm64: cpufeature: Detect BBML3 based on ID_AA64MMFR2_EL1.BBM Message-ID: References: <20260723044034.2983651-1-linu.cherian@arm.com> <20260723044034.2983651-7-linu.cherian@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Aug 03, 2026 at 09:22:02AM +0530, Linu Cherian wrote: > Hi Will, > > On Fri, Jul 31, 2026 at 04:13:20PM +0100, Will Deacon wrote: > > On Thu, Jul 23, 2026 at 10:10:33AM +0530, Linu Cherian wrote: > > > Add ID_AA64MMFR2_EL1.BBM based BBML3 feature detection in > > > cpu_supports_bbml3() so that cpus with the feature would > > > not have to be added into MIDR based supports_bbml3_list. > > > > > > Reviewed-by: Gavin Shan > > > Reviewed-by: Anshuman Khandual > > > Signed-off-by: Linu Cherian > > > --- > > > arch/arm64/kernel/cpufeature.c | 17 +++++++++-------- > > > 1 file changed, 9 insertions(+), 8 deletions(-) > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > index 896bafdb00b1..dbd7d187520c 100644 > > > --- a/arch/arm64/kernel/cpufeature.c > > > +++ b/arch/arm64/kernel/cpufeature.c > > > @@ -2133,6 +2133,12 @@ static bool hvhe_possible(const struct arm64_cpu_capabilities *entry, > > > > > > bool cpu_supports_bbml3(void) > > > { > > > + u64 mmfr2; > > > + > > > + mmfr2 = __read_sysreg_by_encoding(SYS_ID_AA64MMFR2_EL1); > > > + if (SYS_FIELD_GET(ID_AA64MMFR2_EL1, BBM, mmfr2) >= ID_AA64MMFR2_EL1_BBM_3) > > > + return true; > > > > This is a bit of a nit, but I think it would be more consistent to use > > has_cpuid_feature() here instead of __read_sysreg_by_encoding(), similarly > > to how we handle kpti in unmap_kernel_at_el0() (which also has both an > > ID register field and a list of MIDRs). > > force_pte_mapping required by map_mem(during early boot) needs > cpu_supports_bbml3 check and cpu features/capabilities are not > initialized by that time. Should i add a comment there to clarify this ? It looks to me like has_cpuid_feature() will call __read_sysreg_by_encoding() under the hood for SCOPE_LOCAL_CPU. What am I missing? Will