mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gregory Price <gourry@gourry.net>
To: Anisa Su <anisa.su887@gmail.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
	 linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
	linux-kernel@vger.kernel.org,  Dave Jiang <dave.jiang@intel.com>,
	Jonathan Cameron <jic23@kernel.org>,
	 Fan Ni <nifan.cxl@gmail.com>, Li Ming <ming.li@zohomail.com>,
	 Vishal Verma <vishal.l.verma@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	 Ira Weiny <iweiny@kernel.org>,
	Benjamin Cheatham <benjamin.cheatham@amd.com>,
	 Wonjae Lee <wj28.lee@samsung.com>,
	Junhee Park <jh9934.park@samsung.com>,
	 Heesoo Kim <habil.kim@samsung.com>
Subject: Re: [PATCH v12 2/8] cxl/mem: Read dynamic capacity configuration from the device
Date: Tue, 4 Aug 2026 12:00:39 -0400	[thread overview]
Message-ID: <anIMLnbG_KmRfjv6@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <anGtDPQ41N-SGQFG@AnisaLaptop.localdomain>

On Tue, Aug 04, 2026 at 02:12:44AM -0700, Anisa Su wrote:
> On Mon, Aug 03, 2026 at 02:52:17PM -0700, Alison Schofield wrote:
> > On Fri, Jul 31, 2026 at 01:48:07AM -0700, Anisa Su wrote:
> > > From: Ira Weiny <iweiny@kernel.org>
> > > 
> > > Devices which optionally support Dynamic Capacity (DC) are configured
> > > via mailbox commands.  CXL r4.0 section 9.13.3 requires the host to issue
> > > the Get DC Configuration command in order to properly configure DCDs.
> > > Without the Get DC Configuration command DCD can't be supported.
> > > 
> > > Implement the DC mailbox commands as specified in CXL 4.0 section
> > > 8.2.10.9.9 (opcodes 48XXh) to read and store the DCD configuration
> > > information.  Disable DCD if an invalid configuration is found.
> > > 
> > > Linux has no support for more than one dynamic capacity partition.  Read
> > > and validate all the partitions but configure only the first partition
> > > as 'dynamic ram 1'.  Additional partitions can be added in the future if
> > > such a device ever materializes.  Additionally it is anticipated that no
> > > skips will be present from the end of the pmem partition.  Check for and
> > > disallow this configuration as well.
> > 
> > Hi Anisa,
> > 
> > "Additionally, it is anticipated that no skips will be present.." sounds
> > woogedy. The paragraph starts with a Linux limitation of only one partition.
> > and next mentions skips. Is that a Linux implementation rule, a spec
> > rule, or something else?
> > 
> 
> Sorry for the lack of clarity. The commit message has been revised to
> make it clear that DPA gaps between partitions are a Linux rule. The
> spec permits a gap: the DC region base is device assigned and only has to be
> 256MB aligned (r4.0 Table 8-347). It now reads:
> 
>     Linux has no support for more than one dynamic capacity partition. Read
>     and validate all the partitions but configure only the first partition
>     as 'dynamic ram 1'. Additional partitions can be added in the future if
>     such a device ever materializes. Linux additionally requires partitions
>     to be contiguous. Therefore, check for and disallow any gap between the
>     end of the pmem partition and the first DC partition, as well as gaps
>     between the remaining DC partitions.
> 

Is this limitation something we expect to ever change, or is it
something like "The spec doesn't disallow it, but basically there's no
good way to reason about this otherwise"?

Where reasonable, we should try to work the "Linux opinion of how this
should work" into the CXL docs in-tree so it's clear where we put
constraints in where the spec does not.

~Gregory

  reply	other threads:[~2026-08-04 16:00 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31  8:48 [PATCH v12 0/8] DCD Prep Series Anisa Su
2026-07-31  8:48 ` [PATCH v12 1/8] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD) Anisa Su
2026-08-03 18:03   ` Dave Jiang
2026-08-03 21:30   ` Alison Schofield
2026-08-03 23:12     ` Jonathan Cameron
2026-08-04 15:45       ` Gregory Price
2026-08-04 15:45   ` Gregory Price
2026-08-04 18:10     ` Anisa Su
2026-08-04 16:55   ` Alison Schofield
2026-08-04 18:13     ` Anisa Su
2026-07-31  8:48 ` [PATCH v12 2/8] cxl/mem: Read dynamic capacity configuration from the device Anisa Su
2026-08-03 14:33   ` Richard Cheng
2026-08-03 22:11     ` Anisa Su
2026-08-03 21:52   ` Alison Schofield
2026-08-04  9:12     ` Anisa Su
2026-08-04 16:00       ` Gregory Price [this message]
2026-08-03 23:55   ` Jonathan Cameron
2026-08-04  9:54     ` Anisa Su
2026-07-31  8:48 ` [PATCH v12 3/8] cxl/cdat: Gather DSMAS data for DCD partitions Anisa Su
2026-08-03 22:56   ` Alison Schofield
2026-08-05  6:58     ` Anisa Su
2026-07-31  8:48 ` [PATCH v12 4/8] cxl/events: Split event msgnum configuration from irq setup Anisa Su
2026-08-03 23:01   ` Alison Schofield
2026-07-31  8:48 ` [PATCH v12 5/8] cxl/pci: Factor out interrupt policy check Anisa Su
2026-08-03 23:55   ` Alison Schofield
2026-08-06 12:27     ` Anisa Su
2026-07-31  8:48 ` [PATCH v12 6/8] cxl/mem: Configure dynamic capacity interrupts Anisa Su
2026-08-04  0:13   ` Jonathan Cameron
2026-08-04  0:34   ` Alison Schofield
2026-08-06 22:11     ` Anisa Su
2026-07-31  8:48 ` [PATCH v12 7/8] cxl/core: Return endpoint decoder information from region search Anisa Su
2026-08-04  1:02   ` Alison Schofield
2026-07-31  8:48 ` [PATCH v12 8/8] cxl/core: Enforce partition order/simplify partition calls Anisa Su
2026-08-04  0:16   ` Jonathan Cameron
2026-08-04  1:37   ` Alison Schofield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anIMLnbG_KmRfjv6@gourry-fedora-PF4VCD3F \
    --to=gourry@gourry.net \
    --cc=alison.schofield@intel.com \
    --cc=anisa.su887@gmail.com \
    --cc=benjamin.cheatham@amd.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=habil.kim@samsung.com \
    --cc=iweiny@kernel.org \
    --cc=jh9934.park@samsung.com \
    --cc=jic23@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.li@zohomail.com \
    --cc=nifan.cxl@gmail.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    --cc=wj28.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®