From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lgeamrelo11.lge.com (lgeamrelo11.lge.com [156.147.23.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F6B4A2E21 for ; Tue, 4 Aug 2026 17:06:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.147.23.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863201; cv=none; b=huaV8VcrNIaC6xGJVdfMMi/iF9pv6i8UoPmpmRyC5XBAR2f+l2PUbwx+G2B7ZuCYrfB3zhGhw0Fp66g5TOBkoGCMeEFX3XdJ/TooP6mxKuOY1BPDukZY4w/Prx43nSXg4UrAii1MQ0WOndJ2ZWZR3Irpcd3ombkY3A850KWtEOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785863201; c=relaxed/simple; bh=3cONNq/TnveYUMJ+wgFZI9069iAFr8RHqPxIeP6OXeo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n18nfNKn7qpO3TZ2UCgvgaNHYyL72A42MOX3ZKi5PtELYjWJOq+114q4BtlISZmIor/vI9SqRQ1RlDGV2kkN4EOf9kBIMy4AqR4elymAyJitcmzOTW1u1UXV5PRYANXISyrD3EG8YhrJT+6dFxQw6IoXifpYnG/+FjLoDm86xnY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com; spf=pass smtp.mailfrom=lge.com; arc=none smtp.client-ip=156.147.23.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lge.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lge.com Received: from unknown (HELO lgeamrelo02.lge.com) (156.147.1.126) by 156.147.23.51 with ESMTP; 5 Aug 2026 01:36:18 +0900 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: youngjun.park@lge.com Received: from unknown (HELO yjaykim-PowerEdge-T330) (10.177.112.156) by 156.147.1.126 with ESMTP; 5 Aug 2026 01:36:18 +0900 X-Original-SENDERIP: 10.177.112.156 X-Original-MAILFROM: youngjun.park@lge.com Date: Wed, 5 Aug 2026 01:36:18 +0900 From: Youngjun Park To: Kairui Song Cc: Youngjun Park , Andrew Morton , Chris Li , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/swap: fix stale comment on swap_info_struct::cluster_info Message-ID: References: <20260728155907.391820-1-youngjun.park@lge.com> <20260728155907.391820-2-youngjun.park@lge.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Aug 04, 2026 at 05:48:51PM +0800, Kairui Song wrote: > On Wed, Jul 29, 2026 at 12:43 AM Youngjun Park wrote: > > > > From: Youngjun Park > > > > From: Youngjun Park > > Hi Youngjun, Thanks for the patch. > > Double From:? I think you want to keep the later one right? my git config was wrong :( fixed it locally > > > > setup_swap_clusters_info() allocates cluster_info for every swap area, > > not only for SSDs. > > > > Signed-off-by: Youngjun Park > > --- > > include/linux/swap.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/linux/swap.h b/include/linux/swap.h > > index 2cb1d29307c5..e12c73891b48 100644 > > --- a/include/linux/swap.h > > +++ b/include/linux/swap.h > > @@ -246,7 +246,7 @@ struct swap_info_struct { > > struct plist_node list; /* entry in swap_active_head */ > > signed char type; /* strange name for an index */ > > unsigned int max; /* size of this swap device */ > > - struct swap_cluster_info *cluster_info; /* cluster info. Only for SSD */ > > + struct swap_cluster_info *cluster_info; /* one per cluster, on every device */ > > Nice catch. > > Acked-by: Kairui Song