From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE89D3A1A23 for ; Tue, 4 Aug 2026 21:54:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785880475; cv=none; b=dr3NsMMqRPtvhIQ/AQf2NSxA7FJXDeEphbZ5UPO1cQ1P+crCkDW5dmW7YmANKOcfDWNxoU7Si1d8Ko4ntHBnm5BDnIyL1jM3IFYkw+YehwmkUD7t2yayXlDa7nZ1ty9cSdsLyx9aGkH6F+Pvq9PmTZtOZh9scNqiM5aLLeB5mXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785880475; c=relaxed/simple; bh=IuHu+i8ykBGDsG06yppIdROtaxj37qLU5bgE3hYFvEk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gy2L9Mg6SEIZRhYqI3qv1RrLx1z/cFWHpavjmXBbrjzVxIYyBgMF55U8gDZXH7oEPfjRxVM97bK2gbaf/DT7BwQHsoyrMymHzWMPpK98vk/Cr7C0h5USTrDX6YWOyULesDbF06qucS28yfaeIfxkVfKILvDpoXZq6XIJjMLEqLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MA8HX4+k; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MA8HX4+k" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4953e04ef16so2526705e9.2 for ; Tue, 04 Aug 2026 14:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785880472; x=1786485272; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9zdxL7pbRtsTEV8EC4r/5IgaNc8hBDEJjb1U6nqESgU=; b=MA8HX4+kHKsiGKD7eO0zjOVoFwCulkDrKhsm6y+p6MbxId9Ud8I0QCjHKAZrY/bnQg LQlnJhh7PZTgK/Nn3snKMFHXn6l9+Lkv1OgGUpICs2v1A6EE2CXvpI/PvCkYJWwcCB9U PXYeffyYqWXIQxToIedSsX86oFVJV3s3mSm+7FsK1R6ADzqGqCKM5pOkHiHcsCV9zCv/ hW7AN8zEabgPy4gnUTMf2Wg2+9TyckfrXMMAf9nwkWZwpi4dSR9/BbcnF3yBPnx1RHzF v+LX2TGQ9DPtM1zvQiMcIeoSQY0WZiG3Nsi6Tnt3ABDoNE9WJQdV6qNK7Gnh/uOFbFhl JX0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785880472; x=1786485272; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9zdxL7pbRtsTEV8EC4r/5IgaNc8hBDEJjb1U6nqESgU=; b=Eb0CC5vfDINuytD4+p9wGi1QXHRZ7lgkuPKN6Sewf9M+IrCS4sKokbUIwVo5aMlP5W zIPVPHrgC3eivG3Kaz2U2jLfPcBzFTg3X1lfM4bOnqSHSUgRbn0WyRrZ6IeIKH8rWX5l eF61uyQwGMRMCBDTib/75tUeeG9BUcxY9AWjvtZ0cOfALsqAYH1pm51HvFZspMoRHA3r XXZHA1PagTCenta6GNgKWHJScti5cdmPLnhi4QTJ8F0nRTc0fgfB1dutIzPJbOIEgMct 1edYnqd05QVfOC3Dq5/S8liDlBYin/1R6mvKAYtb+q4WGstwjNr3yl57g7ody+MdX/9j vWrw== X-Forwarded-Encrypted: i=1; AHgh+RqrT/hFK3tsUW6NHvpxz2q7y8w2tkkuglmzZZmovwsH2mHUCvBLIUszmZbFnJXcHvi6WCDvdG9X9xo9PJo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1VwNxtWxfpCzYhdOsDgv4kB0415L+ein+qNQjSzc/UWu6R4YB tSfQcXIVlRx4DuqE20dFf585DcXeNGfazaFXzux4t7utEEu0beqrIOWC X-Gm-Gg: AR+sD110xo5Qfq08ufZLMSkb8aQCAVRfLaK3+0AYObjXyMPu9hV95vRqbaSh27vVACe uAqyq8lEdSSWRlQ/L/WoHQFK3LwGko1uN3ApKb8K5THzNXiaZatK5LHK2kMQY22YVtKBq+NECQ+ 00cV8l33ck2z2nP4eGMChAjcWMHQM3gMYy1sKbSSaqrZbMgEDQWnJUu2+sbtYp7N4K4GuYENlT2 DG57tPddl+qj5LB8NlA0t/Dexh3IMiapAQ6fxQTrCxXoOAI3PEvRIVuBA0F3OMgoWKNn7cGEkA/ nJon9kbSklQieEUQ0/tJuoqvNQokG748nnVPxZmUtsccxZ3nDtBeTBoBjDerlCGj7RJu16AN3/g 1zHseXM+2gdTok97tR2Lf9Fy2AZr5dMhNTjRT3gmQGxNV+soGCImMlr5wu1NK3U+NtvAfyTe37y Z4monoqaIDcPi2EPujS/pMoVs7VqZaQwdDQmW4iOL7eQ+qvB/6sgMKA2BzxDX5Vk2vEtN8Fx2Tj r2xlCknktHPCeeuC35NKU2u3Ej66UFZ3zd5uHYw3U6UWheLCmNkdp36n3jIBm8fuVk5zorsTpJK 299MbcbB7bZ8sqpTJnbqY+mgarbirlCjq82SfmJswzmax05CN0rKsFczPbC1vBJXyvfJxec3Qo4 0U8LhfA== X-Received: by 2002:a05:600c:3589:b0:493:c845:bc20 with SMTP id 5b1f17b1804b1-4994e79ab0emr15048195e9.4.1785880471944; Tue, 04 Aug 2026 14:54:31 -0700 (PDT) Received: from MacBook-Pro-von-Karl.localdomain (dynamic-2a02-3100-a48b-1c01-1c76-d8bb-0f26-1c8f.310.pool.telefonica.de. [2a02:3100:a48b:1c01:1c76:d8bb:f26:1c8f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4994e980559sm10979265e9.2.2026.08.04.14.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 14:54:31 -0700 (PDT) Date: Tue, 4 Aug 2026 23:54:30 +0200 From: Karl Mehltretter To: Marc Zyngier Cc: Oliver Upton , Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, grayhat@foxmail.com Subject: Re: [PATCH 1/2] KVM: arm64: nv: Allocate the shadow S2 MMUs individually Message-ID: References: <20260803224405.41468-1-kmehltretter@gmail.com> <86mrv2arf2.wl-maz@kernel.org> <86jyq6aq8g.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86jyq6aq8g.wl-maz@kernel.org> On Tue, Aug 04, 2026 at 03:56:47PM +0100, Marc Zyngier wrote: > > The other thing is that reallocating the pointer array isn't great. It > > adds complexity, and makes everything more fragile than it should be. > > > > See the hack below that seems to work OK. > > Your draft is indeed a bit simpler. Should I send a cleaned-up version as v2? I would allocate the table on the first call to kvm_vcpu_init_nested() and not in kvm_init_nested(), so it cannot leak if VM creation fails. There's another issue in the current code: the ptdump debugfs file keeps the raw mmu pointer as its private data. I would add that to the commit message. Thanks, Karl