From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFE2D38837B for ; Wed, 5 Aug 2026 15:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785945157; cv=none; b=PLTP2OTmyeVve4Xc/oix7hDAuvLeYcq+t1qPfBd5b1ja3fbIU/OKwfdrDfJ598V/9Yt6RCpYcKHxK40bgAFucUQwZbg/LVLR7Iai5YPJg00AlEGcz5UzSrZ+btrq4/hwFxN0+ewvsQBJYAknxtaAPVse6RIKMtbA7Obgv7pc2g8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785945157; c=relaxed/simple; bh=4iQhXtM3wBlDP3iTDZXeDcuQMd9KFElLNHXs6a6M4FI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kqMzv2GHPgQjn3Z40noOO33tfz8nrlPz5jKE33emhPSikd6ZbCLFnIE3nZ2JgUSolouhQECczXKLqHcgfYTYeP8KsLPIAirkVPa8Hyo6BXg8/YZnAvix6bpKh0kssOTvwQUeVYxotq8Y0cHVMWUXGYg6gnFLpLLAycd94ouXY7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JpQMD24J; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JpQMD24J" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38e3617ba36so1197417a91.3 for ; Wed, 05 Aug 2026 08:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785945155; x=1786549955; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Cgf0kMu9tqp0Ksra7TtyhrKQCoqib4RLVTDl85SSveg=; b=JpQMD24J3MaVw4EewVtLi+JweE5POIax0Bl6Az+LC9yCwrKvss7PMQjIcmk6KeB5Dt UiAEVGHA0Ypl3X7h+J9i96W12BBnVfQkZbcQRHbFYNmlUTIJbDZYGz/fYHYJUnF0jc2+ eEYksx+KLG/F2ejCjQB4pESAXqngQOtutpPbG/UvN4moa0THjGKTirfZqc/jaQxlCy24 iqryZRp90dAZFEyCrpih4PkSlXvTvEpNi+RE53eKr2H97/cRzD/WU5fg5SGjpdFoLd6p rF6QLxdwXC5rBDWpvzOny+DwAQa2Kn18f633WXMC898ijYymUyqE6DUr9c1zoBbu221I ReHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785945155; x=1786549955; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Cgf0kMu9tqp0Ksra7TtyhrKQCoqib4RLVTDl85SSveg=; b=rs3DWItAACTgLSPntrNVnDWEuvGz8xh24xYwY0Vh4PMSKOF//BXdCB86+QHSaWDiKS ZBkelZuky8FJGAQOITUaPr2XbzssbpkWLlYjrjO5SM4bJg2D3wQDMHKEoJgy7S7WhPuM X/Nz4DJ2jP7WKAbiG4yXGvINUx4AL4Bboz/OcLEKFiLRh400EJ0qCfH09VGCsexQXQwo h6Vgo7dbYbGsj36gcHwXDMfYEkeKP/3e+hDsxDYTwol7l8rGrqcqSfCWb3NO/QawZVCh Prj1f8H4A9+2y4MfqZ2o04BnyBfnfZdRxBI7lNHomerF8PkjN8nBmPvRjiaujLgD9hUw kOaA== X-Forwarded-Encrypted: i=1; AHgh+RpXhlfT6whlZWF3T/LmaiSBpOX0LB3pKYjHVXNjBsWRqDucb/KIutLu8DIhAs8EpUrVW5zed9fab6lEXz4=@vger.kernel.org X-Gm-Message-State: AOJu0YwSBnkFU6vF9fsJ241keD5pcIARYckQMDkq38Tfwbf2IEfQmVEa x7lVizcWGqRuYLFV5ytT5gX5/pGZx3vPhXNGnxujeo50HEVAV0pTpYYd X-Gm-Gg: AR+sD10t+ddfhS9gFkztIHVPgXYtd0wyFndKkpniFzizIqyBrzuGTjhtfyIXO62es1a Quu5FNQ5dAPmNHid/Uh9B5q0XWN/0kz5RsCG8a1D5dHFi5f1rHieIi0LOkjZKl2RrOKdQDB15LF DYbt9fF2AZ7QIoRcE6oTfozfbONa2YGhVYMybIoEQ7bOgQqDjxEQkDdEGX2sL5OxOccPxxdnON7 sHYQ4/nrpv3ItzUGmmjdhAdy7Mob4+8IJ6KsLXpXVbERC7SIneZsRS3uU8FNqJSL6dgdB+Gm6zc 8rbqGlwLXbk+wd0H0mZnVs95FZkqTVYxqGBcAu4VsF11ydIKJfad8N0+WVinYz+bYgYuS8x9wtU mUJ4O0GZNTmttXxVsRf5IqlDjot6EzAABnCVJZfzWtjt3twxnD3d1Vu05AUqFj1WdBcPhc2htLS 9pfTovkqKCverqYhuQ+TLbRaXn17WP4xXtHA9wBwWhMyJuEvaeV6J0qcYnrBDLw7YQwdy2Bp8RT JuCpi5bM4L+4AlLBCOWp/l3A3xC+DAtivAD/7zc X-Received: by 2002:a17:90a:fc47:b0:38d:f5bb:e0f4 with SMTP id 98e67ed59e1d1-3903c599361mr8837360a91.1.1785945154677; Wed, 05 Aug 2026 08:52:34 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:bf3a:ac93:79c4:84fd]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13fca9111b6sm15094060c88.13.2026.08.05.08.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 08:52:33 -0700 (PDT) Date: Wed, 5 Aug 2026 08:52:30 -0700 From: Dmitry Torokhov To: Mark Pearson Cc: "Derek J . Clark" , Henrique de Moraes Holschuh , Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Nitin Joshi , Andrzej Pietrasiewicz , "platform-driver-x86@vger.kernel.org" , ibm-acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Use input_device_enabled() Message-ID: References: <4ad479fa-8465-4d00-aa73-ced177254eee@app.fastmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ad479fa-8465-4d00-aa73-ced177254eee@app.fastmail.com> Hi Mark, On Wed, Aug 05, 2026 at 10:51:53AM -0400, Mark Pearson wrote: > > > On Wed, Aug 5, 2026, at 12:03 AM, Dmitry Torokhov wrote: > > From: Andrzej Pietrasiewicz > > > > Use the new helper. Inspecting input device's 'users' member needs to be > > done under device's mutex, so add appropriate invocations. > > > > Signed-off-by: Andrzej Pietrasiewicz > > Acked-by: Henrique de Moraes Holschuh > > Link: https://lore.kernel.org/r/20200608112211.12125-7-andrzej.p@collabora.com > > Signed-off-by: Dmitry Torokhov > > --- > > > > Not sure how this got stuck in my patch queue but it is still valid... > > > > drivers/platform/x86/lenovo/thinkpad_acpi.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c > > b/drivers/platform/x86/lenovo/thinkpad_acpi.c > > index 445e1403308e..f8e116e8a65d 100644 > > --- a/drivers/platform/x86/lenovo/thinkpad_acpi.c > > +++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c > > @@ -2547,9 +2547,10 @@ static void hotkey_poll_setup(const bool > > may_warn) > > > > lockdep_assert_held(&hotkey_mutex); > > > > + mutex_lock(&tpacpi_inputdev->mutex); > > if (hotkey_poll_freq > 0 && > > (poll_driver_mask || > > - (poll_user_mask && tpacpi_inputdev->users > 0))) { > > + (poll_user_mask && input_device_enabled(tpacpi_inputdev)))) { > > if (!tpacpi_hotkey_task) { > > tpacpi_hotkey_task = kthread_run(hotkey_kthread, > > NULL, TPACPI_NVRAM_KTHREAD_NAME); > > @@ -2566,6 +2567,7 @@ static void hotkey_poll_setup(const bool may_warn) > > poll_user_mask, poll_driver_mask); > > } > > } > > + mutex_unlock(&tpacpi_inputdev->mutex); > > } > > > > static void hotkey_poll_setup_safe(const bool may_warn) > > -- > > Looks good to me. > > Only note is that can you use guard(mutex)(&tpacpi_inputdev->mutex) instead of the lock/unlock? I think that's preferred these days. If that is desired the whole driver needs converting. I can do it in a separate patch(es) if you want. > > Reviewed-by: Mark Pearson Thanks. -- Dmitry