From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: "Linmao Li" <lilinmao@kylinos.cn>,
"Hans Verkuil" <hverkuil+cisco@kernel.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Jacopo Mondi" <jacopo.mondi+renesas@ideasonboard.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] media: rcar-isp: Fix VSPX reference leaks
Date: Thu, 6 Aug 2026 13:28:46 +0300 [thread overview]
Message-ID: <anRh3g4AoDpceIJ6@kekkonen.localdomain> (raw)
In-Reply-To: <anRUpYHq3uEl462H@zed>
Hi Jacopo,
On Thu, Aug 06, 2026 at 11:33:50AM +0200, Jacopo Mondi wrote:
> Hello Linmao Li
>
> On Tue, Aug 04, 2026 at 06:24:31PM +0800, Linmao Li wrote:
> > of_parse_phandle() and of_find_device_by_node() both acquire references,
> > but the ISPCORE probe never releases them. The device node reference is
> > leaked immediately, and the VSPX device reference is leaked on probe
> > failures and on driver removal.
> >
> > Drop the node reference once the platform device has been looked up, and
> > release the device reference on the probe error paths and in the remove
> > path.
> >
> > Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
>
> Thanks, looks good to me!
>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
>
> Sakari, Hans, should we collect these two patches as fixes for 7.3 ?
I've picked these and pushed these for merging.
--
Sakari Ailus
prev parent reply other threads:[~2026-08-06 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 10:24 [PATCH v2 0/2] media: rcar-isp: Fix ISPCORE resource leaks Linmao Li
2026-08-04 10:24 ` [PATCH v2 1/2] media: rcar-isp: Release ISPCORE resources Linmao Li
2026-08-04 10:24 ` [PATCH v2 2/2] media: rcar-isp: Fix VSPX reference leaks Linmao Li
2026-08-06 9:33 ` Jacopo Mondi
2026-08-06 10:28 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anRh3g4AoDpceIJ6@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=hverkuil+cisco@kernel.org \
--cc=jacopo.mondi+renesas@ideasonboard.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=lilinmao@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®