From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0482B3B71D5 for ; Thu, 6 Aug 2026 14:12:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786025535; cv=none; b=bLPABsm08d3AupiMlHgjkooH3Yel2KEWWLyUlEm50AwtxTK/GW137FJahKz2xpq1br5drc7RSKtgHq7LVJbfCT5OM49cAt+hfvm7VQaoeiFREBkZAWYco8glV/1GiZ5rMXw7+FAemPAceEjVotIoXn2P56B1x/qsU3cr7B1Mw3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786025535; c=relaxed/simple; bh=tKT2WtltnHm9yotRiXX+eFUmEP1+4NC/PxFzeHnanKw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S+4zXG5pOqVHnpT8BC42F0ca3qEXXmktTsPOfif0j7sDgIrvTL47kAvSDfWNhk/za32id0f0rwYEjw3+QJ42mRT5RuouDFAQnbwn9T5pECepeCB8dYNcAOdeZszN5gl4Kn/eR1w+YDekEvelFXJTfu8a4Z2sIIEKizPLvjOS7Lw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HU3H2YZL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y9MPKoqz; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HU3H2YZL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y9MPKoqz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786025532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t7aUwMTNUpYcD120eKUj1K7e7+QcP8SwvajEqZfXsIM=; b=HU3H2YZL0fwaCI1m4uZ88e2OwKwQAcHoNPOundB3DfMTQ4BUYJG/qqfR5cOCbKW4ziQLn7 5wsV582jbP/am+2pK1tLulTjE7fSN/fvV8ley8r2dFBJ6FnTeB0zxkIB7tgK6q6D2gC9o5 ClTmdhadSiUMXavrZtop6s9hrYrI7Hw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-URZ-rDE_NXKDlcoXopmVxA-1; Thu, 06 Aug 2026 10:12:11 -0400 X-MC-Unique: URZ-rDE_NXKDlcoXopmVxA-1 X-Mimecast-MFC-AGG-ID: URZ-rDE_NXKDlcoXopmVxA_1786025530 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-474170b59dfso1293936f8f.3 for ; Thu, 06 Aug 2026 07:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786025530; x=1786630330; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=t7aUwMTNUpYcD120eKUj1K7e7+QcP8SwvajEqZfXsIM=; b=Y9MPKoqzFqLT728N35LXZcohQ5ADY0JIS6qy8/AvNeHFc/xiiDmjr3hzEjXVczvHq5 RFupYqJnNNTrMd3SCAmo/wcwgHfCQcdnhUJ8Tv87wx4UedBspejbTmTp3P1YHW9gODdw Eqfe9LaO1w2kU+B6QYVr+lMWXbtJ/jiE1Us9/UEX4XRA1vfZJ097Ibivmm3F87JIu39h NWTpC9hS1+LR/JzBNcPMpHD6D1LCoTs2saue42MEmAChUX9gywjMBhEyBydeWumnxRUp 5HN5m0yTbeIE/h6dutjoJ8fazNojx6bx77ONQEvxpf02+KtanHBPRuON3m3SF8Xp0HRF Tqbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786025530; x=1786630330; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t7aUwMTNUpYcD120eKUj1K7e7+QcP8SwvajEqZfXsIM=; b=Yzz87mcsyarG7OhGOlygGIqmIQUfnVB9gzVjpanbTnwC1rE+Y7B5fpubCqwJkNqnmK qCEnGsbDxGtgk1lg2aD6XvwW6RXNdVSyewL0Cj7esyNlm0GJM6ogBBziUvYJKoJ3sYcg 44ihmKwxsnuX/Kh/Ter7zz8B+3ChrfXjI4ZltpC6nniUKxuGWlTNgU4QXQexWRxoWjjV FtsU7WswpjaWjQ8U1jRCZbT6eLOe2pn28Uo+syhz2f8H5TjDZIYWIbuVkbEevIhLlFg8 lb9cpqeZcs87ghtoX8NWXIvtwSrXMqbO0wnB59lt94olVHKZd5vJXyx/Lft6bi1eeWtL U+4Q== X-Forwarded-Encrypted: i=1; AHgh+Ro9WhPcpI6yIueG5KuTefIfkKJtF4tCuw+abwMhf+dVHNbT78tCyaVt3QOaBTbgWmcBnze5xkkQtKO+A5E=@vger.kernel.org X-Gm-Message-State: AOJu0YwJ6D8eyYO64QOQ7FsEplRZ+mQcftNdTxg4F6ICaL8+twhVpsjF ngMJB31B44xjWDJnXvv2haCR1ouKLMI3EVcPNlu+0lAYPqMimc/7yCSJqSh4VOI3FtpbbVLRTyF zYr/vh2jjm2BpCaBiTxu8hRQRo6StCxq+tb/fPW3x7ZyyCUl5OKHfqkVLsm9SS7PST67Tti7Q7g == X-Gm-Gg: AR+sD12fMGNibwNOr4AWGcqJwOiRNh5/ggt8ME+3smosTB2J7p355m9YJVs7ptzVnf/ x9fGoHgqm+vaXRW9n8RLKB93nAxL8/i24MdDu9IBnHhRQ/19+3g0JcgX9ZzAKS42ihoF/YDmS2D iTN/d0tBiUTcrY/BXSip7EvPunrOWSL9VHCyrJEx/RyeQVX5BXuwY5PzT/oIdMXleYVl9SlLAzg QtVwHRKOb10S154T85jb+OWfU3Aj6kOL2lgL6X3CvEaoQz5Y2tQmxlKke9x0+hkTTkJ/r520xRl LN02WE7SeYbSpc8lUlEPhNsVqhYp+mJyX0KPIqi9FVcyrbPDkhPqjkLAXB5hF8VyHlpCjZnukEL txo4= X-Received: by 2002:a05:600c:3ba2:b0:493:aa0a:45ad with SMTP id 5b1f17b1804b1-4994e794edamr191371135e9.2.1786025530372; Thu, 06 Aug 2026 07:12:10 -0700 (PDT) X-Received: by 2002:a05:600c:3ba2:b0:493:aa0a:45ad with SMTP id 5b1f17b1804b1-4994e794edamr191369505e9.2.1786025529693; Thu, 06 Aug 2026 07:12:09 -0700 (PDT) Received: from sgarzare-redhat ([5.77.117.129]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49952dda992sm35827965e9.2.2026.08.06.07.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 07:12:09 -0700 (PDT) Date: Thu, 6 Aug 2026 16:12:03 +0200 From: Stefano Garzarella To: Sean Christopherson Cc: Andrey Drobyshev , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, mst@redhat.com, stefanha@redhat.com, jasowangio@gmail.com, eperezma@redhat.com Subject: Re: [PATCH] vhost: clear vq->worker under vq->mutex when freeing workers Message-ID: References: <20260723153310.745855-1-andrey.drobyshev@virtuozzo.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Thu, Aug 06, 2026 at 06:53:12AM -0700, Sean Christopherson wrote: >On Thu, Aug 06, 2026, Stefano Garzarella wrote: >> On Thu, Jul 23, 2026 at 06:33:10PM +0300, Andrey Drobyshev wrote: >> > The effect is harmless in practice, as this only happens while the >> > owning process (and thus the whole device) is dying, but the lockless >> > write is inconsistent with the rest of the code. Clear vq->worker under >> > vq->mutex, like everyone else, so that all writers of vq->worker follow >> > the same locking rule. >> > >> > This issue was found by Sashiko AI review. >> >> Can you share a link to the review? >> >> I don't know if it's common or not, but having the link in the commit or >> after --- will help the reviewers. > >+1. FWIW, I've been using and encouraging the "standard" Reported-by+Closes, e.g. > > Reported-by: Sashiko Bot > Closes: https://lore.kernel.org/all/20260625212001.3B6561F000E9@smtp.kernel.org > Yeah, this makes a lot of sense to me! I'll encourage the same. Thanks, Stefano