mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Atharva Tiwari" <atharvatiwarilinuxdev@gmail.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	"Darren Hart" <dvhart@infradead.org>,
	"Lukas Wunner" <lukas@wunner.de>,
	Westerberg <mika.westerberg@linux.intel.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	"Andreas Noever" <andreas.noever@gmail.com>,
	"Mika Westerberg" <westeri@kernel.org>,
	"Yehezkel Bernat" <YehezkelShB@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Jarkko Sakkinen" <jarkko@kernel.org>,
	"Mimi Zohar" <zohar@linux.ibm.com>,
	"Roberto Sassu" <roberto.sassu@huawei.com>,
	"Dmitry Kasatkin" <dmitry.kasatkin@gmail.com>,
	"Eric Snowberg" <eric.snowberg@oracle.com>,
	"Paul Moore" <paul@paul-moore.com>,
	"James Morris" <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: Re: [PATCH v5 1/2] treewide: Add a flag to detect the Apple T2 chip
Date: Fri, 7 Aug 2026 04:31:13 +0300	[thread overview]
Message-ID: <anU1YX6EAHxrNiLP@ashevche-desk.local> (raw)
In-Reply-To: <20260728005847.GBamf-x27vgqj7WG7e@fat_crate.local>

On Mon, Jul 27, 2026 at 05:58:47PM -0700, Borislav Petkov wrote:
> On Mon, Jul 27, 2026 at 05:18:02PM -0400, Atharva Tiwari wrote:
> > Add a flag to detect Apple T2 chips on Intel Macs.
> > Cache the result to avoid repeated checks. That will
> > be used in upcoming patches.

Why don't you use match_string()?

...

> >  bool x86_apple_machine;
> >  EXPORT_SYMBOL(x86_apple_machine);
> >  
> > +bool has_apple_t2_chip;
> > +EXPORT_SYMBOL(has_apple_t2_chip);
> 
> I'm guessing this is parrotting the non-GPL export of x86_apple_machine from
> 
>   630b3aff8a51 ("treewide: Consolidate Apple DMI checks")
> 
> Lemme add those folks and ask why aren't those exports GPL only?

I don't remember the details, but brief grepping shows no impediments (from my
p.o.v.) to make them GPL. Maybe Lukas knows more?

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-08-07  1:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 21:18 [PATCH v5 0/2] Add Apple T2 NHI device links Atharva Tiwari
2026-07-27 21:18 ` [PATCH v5 1/2] treewide: Add a flag to detect the Apple T2 chip Atharva Tiwari
2026-07-28  0:58   ` Borislav Petkov
2026-08-07  1:31     ` Andy Shevchenko [this message]
2026-07-27 21:18 ` [PATCH v5 2/2] thunderbolt: Add device links for Apple T2 NHI Atharva Tiwari
2026-07-28  4:48   ` Mika Westerberg
2026-07-29 18:35     ` Atharva Tiwari
2026-07-30 11:32       ` Mika Westerberg
2026-07-30 21:15         ` Atharva Tiwari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anU1YX6EAHxrNiLP@ashevche-desk.local \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=atharvatiwarilinuxdev@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=eric.snowberg@oracle.com \
    --cc=hansg@kernel.org \
    --cc=hpa@zytor.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jarkko@kernel.org \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mingo@redhat.com \
    --cc=paul@paul-moore.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=roberto.sassu@huawei.com \
    --cc=serge@hallyn.com \
    --cc=tglx@kernel.org \
    --cc=westeri@kernel.org \
    --cc=x86@kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®