From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BEEC431A40 for ; Thu, 6 Aug 2026 22:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786055427; cv=none; b=bZEaujBj3j3/TXvGnQMLolcQUJIwEHahksT2FhcrTzUY6X2lRSUNf0PqGgroLUXCP8qqJBv3s+TO8BAc4rIZ/b0INM5Za/WpijxodRB20duHPRYUMwNIcfGOsKms7L+B/Yyps/4Pc2PQ9KFsUiDS/r9eDtH41rNRTGiN39SKiBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786055427; c=relaxed/simple; bh=Z03Zgrh/PLbVv7BJUbfCMOumlNRPEiMGrdjmvgnGfrs=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=tmi2E8VKgKfJZXbtr98vqk2mzLMcEpU9SJcJB+90LClSqYBc7r1KKEQbVhjq5NdXBc0qzKuxRcM+UUMmYy8Egv6DWV81IKkblNz4Cdwycmbet9ApzzOwocXCtcBcxGkC5LsnPdj4cjbH2O2lBoZiGeR/KCmTlFBkXKslTiW6Or0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QLAX8l3c; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QLAX8l3c" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-49954b88fffso11020775e9.0 for ; Thu, 06 Aug 2026 15:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786055422; x=1786660222; darn=vger.kernel.org; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1xet6bl6hLgdXcYELv7AJKRmW7miXQG6+lZeaFGL9nE=; b=QLAX8l3ch7zORXNT6m948sfSgn1LDIgByMGfn/b1uFcVhkaPXE2miiLw6JvL2dcR37 gl7Trcsy74crUA6A6L8h80JBVjCOLbmRsOqdqB7OoF2D6Swf5haBVen7qHoYcHY0Vux5 cAOJnv5PmQMiC/xRzvt6D/RlGcHwuUEJGeW0ccwymNM4J/uaEmUP5VGWVdsvoHxwBjCr PHmd/O7yF44JuLOtBWeiiol1y3/wgpYakieINZxenhfrZzTDo3Yd4gbcUxifYF5ntDwk 3l7zU9zD+G32CzH9/16dGZhVMhne3mDzB75VPufDsDk+Lk54x4hjeD2V1k5IEn2SpLvO 0weA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786055422; x=1786660222; h=content-disposition:content-type:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1xet6bl6hLgdXcYELv7AJKRmW7miXQG6+lZeaFGL9nE=; b=FBOj5/ZgoTq0THfcbDVSMSNcjmmfOfo7Hx/ku5CZBHR2igIHzicq835HyxaONg8SVR 1EakgZVLk3yQvAnrUnFzSHw7EA6zTxKicpgflno6XPN4Vi+1QDK4FasZfGU4bsRwHBHP hEIAOn3TihIJCEfD4+qaNzyhJ1RUYBb9ZVBoaP1O1AnuLc7Hev5DS4Bhl6TBjGlh/Z/K fcJHpECqXxGw3f1rCU5JsP5oGjK30U3833hNXwjKWAoEN4sk5hYZNn0zDowW5BdIhhNF DNrOopLTaQMtxmj7mcaR1oyLYqouREJqw1IPwv3Qew0NezyvvForuagpgiwDUQRY1kr5 TnNA== X-Forwarded-Encrypted: i=1; AHgh+Rr5bmwl3/DcKJxhd2D0V/nATeY+gQYGQmV4D6aBl6UCwkD6cq+j/0cvY52ZGxDRI+qDeto315Y4/bnOHxo=@vger.kernel.org X-Gm-Message-State: AOJu0YxOt59ztN/EZJQkZ6xcM1/mrwlstvWg3dcEIipISrevs7MKGwRj nAUvE/bdX3Pm/+S3H28qazbqSEmGlvlLD549i8Zs+lyU4DbopxhBQBiDa8qSPw== X-Gm-Gg: AR+sD13g4iiCTf9q8Zr8+qul7vaS42ywUYYPtdrPLymeDNgWATOrXE6n8fxcfMxxUh7 HYb0hdruviwhP3yPXEKFjlIg2V0UgZb69yZmhodT+2XqHYSQAlXObUjr+ZphsJov+6E1/VqjU7B 1FrwCwsjgRlXfqGShJnwL1QMKC9hC3orvhk50vrcTr36rUTdCtS04C32km6KHibNxYdZmyGiHWH VCxt9Q87pQrcIkYFGZQRJhDJ2Tb/7gCO15wGrdt6IrO2nHoyPMdHRra30FJEAQqe+rDlSxVbsNu t/BxKWStW8Tg/jMLYv7KaO6MIgDficzG8T2mmXKrSqrSVONWncsNcvFhXrcpY+f1eGVVclMOTBk Xxw2kPyJDDWoaz10GYnM4XFZfQLdt9YWvPYG8M6rOH9DFT4wQCskf4AFSHK8dkmkpI8I2ga2A4h bT0mRqESYBFjaYVo2MfLlfk6IwKtFjjsu6sSn7wDmACTZWzWldRSKKqtUBDTUPsXVgphjUtwpO1 lPR0pahV9JA1CYGrK2ZlKilGIDvLb/+JdwS X-Received: by 2002:a05:600c:2142:b0:495:5858:8101 with SMTP id 5b1f17b1804b1-4994e7cbcbfmr198644225e9.15.1786055422433; Thu, 06 Aug 2026 15:30:22 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995c7a56c5sm11996605e9.3.2026.08.06.15.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 15:30:21 -0700 (PDT) Date: Fri, 7 Aug 2026 01:30:20 +0300 From: Michail Tatas To: corey@minyard.net Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] ipmi: Fix leak in __ipmi_bmc_register Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In case that ida_alloc(&ipmi_bmc_ida,...) succeeds and then platform_device_register() fails, ipmi_bmc_ida is leaked. Fix by freeing the error path Signed-off-by: Michail Tatas --- drivers/char/ipmi/ipmi_msghandler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 6ff9a15cced8..7634dff99f41 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -3301,6 +3301,7 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf, list_del(&intf->bmc_link); mutex_unlock(&bmc->dyn_mutex); intf->bmc = &intf->tmp_bmc; + ida_free(&ipmi_bmc_ida, bmc->pdev.id); put_device(&bmc->pdev.dev); goto out; } -- 2.43.0