From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tomas Chimenti <tach.365@gmail.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, hansg@kernel.org,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
andy@kernel.org, gregkh@linuxfoundation.org,
~lkcamp/patches@lists.sr.ht, koike@igalia.com
Subject: Re: [PATCH] media: atomisp: Remove useless return statement
Date: Fri, 7 Aug 2026 02:00:53 +0300 [thread overview]
Message-ID: <anUSJQw8RxTCoJEu@ashevche-desk.local> (raw)
In-Reply-To: <20260723152146.86978-1-tach.365@gmail.com>
On Thu, Jul 23, 2026 at 12:21:46PM -0300, Tomas Chimenti wrote:
> Fix checkpatch error
> "WARNING: void function return statements are not generally useful"
>
> Signed-off-by: Tomas Chimenti <tach.365@gmail.com>
> ---
> Hello
>
> This is my first patch, any feedback would be very welcome. Thanks
Right.
Please, read lore.kernel.org linux-media@ archives against this driver to
understand what to do with this patch.
Also, if you are in a group that is mentored, tell to the mentors to stop
looking into this driver by a newbie. This driver has much more urgent tasks
to do and it's not trivial, it also requires a real HW to be at hand to test.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-06 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 15:21 Tomas Chimenti
2026-08-06 23:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anUSJQw8RxTCoJEu@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=koike@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tach.365@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®