mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Rick P Edgecombe <rick.p.edgecombe@intel.com>
Cc: "nik.borisov@suse.com" <nik.borisov@suse.com>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bp@alien8.de" <bp@alien8.de>,  "x86@kernel.org" <x86@kernel.org>,
	"kas@kernel.org" <kas@kernel.org>,
	Xiaoyao Li <xiaoyao.li@intel.com>,
	 "hpa@zytor.com" <hpa@zytor.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"tglx@kernel.org" <tglx@kernel.org>,
	 "pbonzini@redhat.com" <pbonzini@redhat.com>,
	Chang Seok Bae <chang.seok.bae@intel.com>,
	 "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM: TDX: Enable Notify VM exit
Date: Thu, 6 Aug 2026 17:32:02 -0700	[thread overview]
Message-ID: <anUngktlwsNI6oUM@google.com> (raw)
In-Reply-To: <5ab71720460d268e3336e521209c796ca04b0012.camel@intel.com>

On Fri, Aug 07, 2026, Rick P Edgecombe wrote:
> On Thu, 2026-08-06 at 06:50 -0700, Sean Christopherson wrote:
> > > It should be instruction timeout (as is in the SDM). Please reword the
> > > changelog to refer to the name of the features as they are in the SDM. I.e
> > > if you search for NOTIFY_VMEXIT or NOTIFY_WINDOW absolutely nothing can be
> > > found in the SDM.  The changelog should ideally mention both - SDM's
> > > nomenclature and linux's nomenclature.
> > 
> > No, let's change Linux's nomenclature before merging this, "Notify" was always
> > vague and confusing.  It's unfortunate that we let that bleed into uAPI
> > headers, but we can simply #define aliases (or just force userspace to update
> > as well, if they use kernel headers directly).
> 
> Hmm, ok. We were trying to go with a minimal backport friendly fix.
> 
> Xiaoyao, if we are going to carve it up, I guess we might as well do the
> consolidation of the exit handlers too on this version. (a cleanup patch that
> got left off of this).

Oh, I missed that this was tagged for stable@.  Do the mass rename on top.  To
address Nikolay's concerns, I think a brief blurb at the end calling out that
KVM currently uses old terminology would suffice.  E.g.

  Note, KVM uses "pre-production" terminology for the feature formally called
  Notify VM-Exit.  All public versions of the SDM refer to the feature as
  Instruction Timeout.  This will be remedied in the near future, for now,
  use KVM's terminology for consistency.

  reply	other threads:[~2026-08-07  0:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-05  3:12 [PATCH 0/2] KVM: TDX: Enable VM-DoS Prevention Features for TDX Xiaoyao Li
2026-08-05  3:12 ` [PATCH 1/2] KVM: TDX: Enable Notify VM exit Xiaoyao Li
2026-08-06 13:33   ` Nikolay Borisov
2026-08-06 13:50     ` Sean Christopherson
2026-08-07  0:27       ` Edgecombe, Rick P
2026-08-07  0:32         ` Sean Christopherson [this message]
2026-08-07  1:07           ` Xiaoyao Li
2026-08-07  6:46           ` Nikolay Borisov
2026-08-07  1:06     ` Xiaoyao Li
2026-08-07 14:38       ` Sean Christopherson
2026-08-05  3:12 ` [PATCH 2/2] KVM: TDX: Enable Bus Lock " Xiaoyao Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anUngktlwsNI6oUM@google.com \
    --to=seanjc@google.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=kas@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nik.borisov@suse.com \
    --cc=pbonzini@redhat.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®