From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE26D469852 for ; Fri, 7 Aug 2026 07:53:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786089217; cv=none; b=WKufHXEuJVoLrIedU6sZfuPlxp96u/63G33i/oTl9PvnTSTbljgLhe8JUuBxlYARGteOU53jWYw1jyt6vNlN5UjfxeiD/293kOipbCiy4abHWHs0+ACgvyko0CS3LlXQ6Va2ud9AXGx5mVc62UQuE30/lAawQw3CeLC2PLMPy0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786089217; c=relaxed/simple; bh=pv+HUDJ6Jqv1EfEXVjkswn5QmcTtpO/JPntGSbAYY1Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b/zzweBsdCqVU+zK2Y1F/wTatPxldRCKVQjb2+XQPPxVcUN+/rjECQFh4tJryXn+cWHeiBzt4cELN+fwHPjIALmW4r054D23YniJs5HW5MCqA26u2VjjiHl/nOm1OHrj/XTuNv4hsOrToQkXECPvT67XoSwemn6W1llcTQqkRiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RuQtZofK; arc=none smtp.client-ip=209.85.219.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RuQtZofK" Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-8eeb4508f29so19787116d6.0 for ; Fri, 07 Aug 2026 00:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786089205; x=1786694005; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BkSB5UeEOgCFJxMoU/6rdUo5e6K0Xm0j0jwgxzCJuXM=; b=RuQtZofKwcL5rg8AOQvmT7dTJ1dr0YEDpHCO9RsROVnAtsG+iL5vD1751NGH3N24iy +mkC71J8cvqHJyx2QwWVtQzWDU3+nvR4ehjNtARFEugV3yZul3id/rHmXXu/q+S6dCIu A1xDf4IfFrFlNV5lbYqcwlklUBc+Dj1KZVdhfZOmjNxwbq/N2Ft+nDLcP4u7ep/Hmiob IkXmmFOlwCsC2VKz1YjwPph5NbeiqBpb5JqJ/cVTcreg/WRIIa8I0tLsXlWjOZWWsKMR bJA1XtYR2QjqMW5RfF12Y2df29VFgApgyqTUlA40LmLcb59jt3vEvwAAS2qgGpEn7Xcc uRew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786089205; x=1786694005; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BkSB5UeEOgCFJxMoU/6rdUo5e6K0Xm0j0jwgxzCJuXM=; b=Gymku55pYQhKfQlryEZ11Wulwgg7ErQY8N3iOVya47ooFw0/GxAjDgmDJp57bAC87R 1hscTrZmHJv2wfL/mjbx8Z+/SV6KJd2fVcfeXZHqJ3TZ8VEJfubEoDMPg0Rupz3oBoqJ 1ceMAcwnAM/Qv1xsB/pl0j21WBPouBDnEkMr3J01vUeVoDB+8NFRUUM8P88KRg4yQJFk 6dV6f5lm3k3q1nch1rIQ6yxAW2ORvRyrUEE8mruiWG4kR/70Vmvb+4S+tyG5nkVqeKLr cAKS71JKLLsANhBWk+pr8FCgyz1wDUNu931cue1BdsOSK8yoK+5lRmIffwehP/mecAyp bS8A== X-Forwarded-Encrypted: i=1; AHgh+RomfcsMG1/XTItH+17Pq0Klan7Dkj8EcRNyqJkkEBaso+fIh9c7W0EUTRVO6EVfeOXKR1gQBrPvVwbHPIc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy063A0R0IzV7ZGwGKVycETInyuBlt6HdeBpd+dN74RfdL7jkYn o8Wwg60SlcR5A0er7BUzIZvp9lUg00jotuex7vcJsqIXte90p817umYF X-Gm-Gg: AR+sD1390DMppqXX8Qd+o+JdJ03pJ2emRTaoHLoiBs/e8hRIk/YfJXkjCLAIMMQWsPI nBmNJ3lMmiYpClEwDt8CdKZlpQyuY3DNDgCc4iG/6vgu6pfXh4WfzVj20YRqK/EwBZIFxm+i7wq hxbYhqNEckUMNTRJ3uPUYW9W7RtleAAW/cENZDoxlFfU8Y3sREi/obGr41yvJ17miofngnzTCu3 Re4Uk+hDm3B0MsZqQR6zEj4CwKTrLH3tlynKvTamRJzkl1/761MxaftL8PjTcNl7nW3WZhKVFju BtojtVx3+0WYsepZyXxFesE+GY8KSfDSxVQ3Cea9p/fUAmo58Cn8nsNJqhcBspqRHq6H0BULx8N 3zEERv77cccWD2uv7q4yFstMqfGTWSgod8gixZ7ny0j1chsSK9wUUBZfZgG5amVRvbd0nQaNv2R vls7t09BLfT76SN3l/WXAWg/MoER/luZxCQ1WiBnDvIV03ITFHYWid3X0= X-Received: by 2002:a05:622a:1792:b0:51c:1408:6c13 with SMTP id d75a77b69052e-52ce61f0ccdmr208432251cf.44.1786089204809; Fri, 07 Aug 2026 00:53:24 -0700 (PDT) Received: from localhost ([172.93.148.182]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d1659b9fbsm6999931cf.15.2026.08.07.00.53.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 00:53:24 -0700 (PDT) Date: Fri, 7 Aug 2026 10:53:17 +0300 From: Dan Carpenter To: Nikolay Kulikov Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove static HalDetectPwrDownMode() function Message-ID: References: <20260806-rtl8723bs_efuse-v1-1-fedb8b91f346@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260806-rtl8723bs_efuse-v1-1-fedb8b91f346@gmail.com> On Thu, Aug 06, 2026 at 10:34:48PM +0300, Nikolay Kulikov wrote: > The return value of this function is ignored at the call site, and since > the function has no side effects (except for the assignment to > pHalData->pwrdown, which is not used anywhere else), it can be removed. > The patch needs to get rid of pwrdown from include/hal_data.h. There are two reasons for this. 1) For correctness and cleanliness. 2) It makes the patch easier to review because as the patch is written now we need to check the kernel source to see if what you're saying is true. But if we delete it and it is actually used somewhere then we can rely on the kbuild-bot to find the mistake. regards, dan carpenter