From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (mta1.migadu.com [37.59.57.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DDCF3E63A4 for ; Fri, 7 Aug 2026 09:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=37.59.57.117 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786096166; cv=none; b=I3KFtWh+tfKPCMnRYn1PMEr2QG+yFslLqr19mVCNHne9454r2igdZvAV13FUDWs4h1p3YDTwyh0KJdu+Ji/Ul0D/rVoPVqSEFoWRHx2CvssgQ4rOKOLqEOSUflcKSupx+qN4LJhDLvoSZnwD06PAsubSNY7kimhVEhOK+8cZrbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786096166; c=relaxed/simple; bh=Wwc25H+CpTP9tI3Bqukw/HLJEO4bBHA3AQzCKCGu+AU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uhjyEPDAv8Z5nU1HJ0FmLCrFHAfIi8FsRiytqh2NrX7V3oJbSlXNoM26Uaw21vh61W+Nd5PnK1pSYAt4TzO4mwvpOHfg98UVfiIlsTe5r9kASckBwjfN2A0anIUch9R6phSAvsaseYMTRT/QdzKzZsSFjSbM5JvAQNeampEWGDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=dza8uxmk; arc=none smtp.client-ip=37.59.57.117 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="dza8uxmk" Date: Fri, 7 Aug 2026 17:49:09 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1786096161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SZVE7Aqc673xt6dF/9mK8eMKktJen4Qxx18CVOYEK8M=; b=dza8uxmkiK+CVNxbluvRAp4hztsOmYQQivarQs5pcasCHj5NPuN9tKJnjVjNcyqlx4CJPV YmLRED9jPePthYuI5uFQfhpDMoyVkkka2LrKe3d4ZWzdlYJHxsUaxPduqUI584DeM8/57N YqwZDSThOqNHVvSIMBe4UpkKhUsWNXM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Baoquan He To: Youngjun Park Cc: Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Barry Song , her0gyugyu@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm/swap: fix stale comment on swap_info_struct::cluster_info Message-ID: References: <20260806193228.458685-1-youngjun.park@lge.com> <20260806193228.458685-2-youngjun.park@lge.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260806193228.458685-2-youngjun.park@lge.com> X-Migadu-Flow: FLOW_OUT On 08/07/26 at 04:32am, Youngjun Park wrote: > setup_swap_clusters_info() allocates cluster_info for every swap area, > not only for SSDs. > > Signed-off-by: Youngjun Park > Acked-by: Kairui Song > Reviewed-by: Barry Song > --- > include/linux/swap.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Baoquan He > > diff --git a/include/linux/swap.h b/include/linux/swap.h > index 2cb1d29307c5..2b14e2e9673b 100644 > --- a/include/linux/swap.h > +++ b/include/linux/swap.h > @@ -246,7 +246,7 @@ struct swap_info_struct { > struct plist_node list; /* entry in swap_active_head */ > signed char type; /* strange name for an index */ > unsigned int max; /* size of this swap device */ > - struct swap_cluster_info *cluster_info; /* cluster info. Only for SSD */ > + struct swap_cluster_info *cluster_info; /* array, one entry per cluster */ > struct list_head free_clusters; /* free clusters list */ > struct list_head full_clusters; /* full clusters list */ > struct list_head nonfull_clusters[SWAP_NR_ORDERS]; > -- > 2.48.1 >