From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A5073D6CCE for ; Fri, 7 Aug 2026 11:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786102831; cv=none; b=SeAthfxCykosA3CUZnPRY2XYepCYgNjNWiDs8BH2aAa1RzURq+4dC+PAgANq4+mpR/LWluvocH7kWXr7xUKduKbGPaR6r6i+8aJqXiIWv2iIzfkXgTpzaXrG3355e29IRDre+vSti3Bh0hCv4YQjPMfwCQmJ2qyh2J2PE4fysLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786102831; c=relaxed/simple; bh=N9knYDZBFNPryH7Rgx/98qENXC5GJq8BV/99VAlyTBo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CFeyiJm5FEe58KrC19pkEAKGP+GDPK22XRNP4awtXws2GW0v2PRT4VB+ehtsrkchJue1JINK0BLw58KkHcCvObrNFPvjHtT1IWTrPM7tjOnCgCRlzk+nyBK7rpKbkdtQIY6EnpTvsmi/7sxK7SE4wumO8U2+EMYc3+XeygFOj3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=ho+AG7QT; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="ho+AG7QT" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-49fa951b2c6so1920977b6e.1 for ; Fri, 07 Aug 2026 04:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1786102825; x=1786707625; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=EMmFXrjSrpeG4wnNrWhFFN4HfKJ+fxYW0scJBNmq2ko=; b=ho+AG7QTq0tBcJO5iMiHZPcbuvMjiKbaKScbh/9yZZWegr6dvgITG69snkYO2dIFoQ /d4iNi7CkQphEXYa3chPWwg4PyrIyGHpjqwXAdNxKU3GS5IJuxMtF6NpwDtfcgGazUst XyXT9hXsZfusPVoCMHdZy4j1bKU93GQ9zG6q+q0+gGw/PXJGWDzztmwIcgMSheCuKCwi nt0Ox8JXCQk6hpZ2i54sJylhFJZCGEJDI9T7OpmMYR7R96J+ec74H1CewTXECCyE0b4V EsF6bUkUw2rLEs1Lkc54X1h41RSYJBZyYFkA6p6w++g6IMHcnV41mojOOnslIQ1sTEf3 /NFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786102825; x=1786707625; h=in-reply-to:content-disposition:content-type:mime-version :references:reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EMmFXrjSrpeG4wnNrWhFFN4HfKJ+fxYW0scJBNmq2ko=; b=iCGy4npaFZp0J1ka8eSAXTj5lpP0X9e3apVBIE+CUNZkB9U54qGfE1e+9nH/a8eamc 4fqpfx0X46UyJl/RlnCWriKGz12eiYF8T/tpKXfz5ViXZJcW4lF1ONYV88aGX1p1hwxL jWNle2qi2P69iRLqPpwLiLOdAqFygEcpuJyn4HIsyVb1mpDNiUNzW3eSsLga61GnuKHK JyphdGajh7dykaOpTb27ig+A35pZxiZ3K8K+fohEb3gJxU70WsLAqU+vQvQivSMvGV7A 7mm9I7HQhYFDtzHBq1YbapksVevPfklfoBNM6Ws2oirgkuZhqEEDr9mP1cbDIhNUmKAx Nc0w== X-Forwarded-Encrypted: i=1; AHgh+RqINbSW3DSnE1ryEuH+qIiecIXGKsbje1g61tO3DqK0oaLg4+2StsaJx1mWFl3X+OPmI43Ty2vdvciaGg4=@vger.kernel.org X-Gm-Message-State: AOJu0YzpLyz5VT0TwTUX6IxVjmDsYwr+CuqaTAe5ZzfLUbFa/F6LHf22 eJdodLhTL8o93PF18ZLFkKnobMAsDIxxTk97ezYdXFVhlaubBiuwJ3LyQw1GQT8PLXWmc/taZG/ dIEJ8 X-Gm-Gg: AR+sD116JUzQFMYhFfdJigO9S28seoTtEJpAVwp8FVIgSHXLwxwjmxXN3k7ZOuovkjU iSHw+F8uozgVuUjUr1wL86O2d1tPmv5Ia8PnT8oTrwgB+kQv1O0oXi7gODjnFfpSN231fXm3Nl2 ywbURWlgwSKVVfDWyT1RMaY6oi0Etltu0ddsg527eVdouojS7IVImuak5b4gWKcSDrEaadEU5tN AxjyerF/jR3pXYe5NfbeFch6IZfE3lO69AXC0SyK+8/+kVUKMXOkoVhCmw39ecdYhNzcDaySCVJ e2IfOw7MsV8nxp7J8bnkpzCENx56/2j/V1r+kqRHNHE3zibjbz3z+0xl6gyj/gMo8q8RKoAB61B y/MoSFkS2f1RqsYD7MLGimQig8/JTrMt0AlOJqGDCFP/sAVLrQY1JaN3bnt+BlCs8+FwileF9c/ +wQAxaVFr7CIysbUJDyqVHWUT2Ir7ot6+AsZquS4snTu7NBhycSeadHNbSfy+nE3E1K5AL5bUiS D4bgCCMn0lHlUwDV6S3wzu3EORSRFq2u7j/Jb+DnSdVpb0ej2QsmKhKJnGezix4uaqD1FAEGk9a RsgeabZsAA== X-Received: by 2002:a05:6808:13cc:b0:497:deab:2bfe with SMTP id 5614622812f47-4afadecaaadmr11898057b6e.1.1786102825384; Fri, 07 Aug 2026 04:40:25 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:f431:c4b8:c018:caf2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4afae1777d2sm7036162b6e.0.2026.08.07.04.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 04:40:24 -0700 (PDT) Date: Fri, 7 Aug 2026 06:40:20 -0500 From: Corey Minyard To: pzalewski@thegoodpenguin.co.uk Cc: Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , Mattia Dongili , Weili Qian , Olivia Mackall , Herbert Xu , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-crypto@vger.kernel.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org Subject: Re: [PATCH 3/4] char: ipmi: use named initializers for acpi_device_id Message-ID: Reply-To: corey@minyard.net References: <20260807-acpi-char-v1-0-742c450254dd@thegoodpenguin.co.uk> <20260807-acpi-char-v1-3-742c450254dd@thegoodpenguin.co.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260807-acpi-char-v1-3-742c450254dd@thegoodpenguin.co.uk> On Fri, Aug 07, 2026 at 12:26:10PM +0100, Pawel Zalewski via B4 Relay wrote: > From: "Pawel Zalewski (The Capable Hub)" > > Use a named initializer for the acpi_device_id fields which > makes the code more readable and consistent with how lists > are initialized in the rest of the kernel code base. Also > drop explicitly setting fields to 0 where it is redundant. > > While we are at it - unify the list terminator to have > a single space between the brackets and no trailing > comma. This is fine, it's in my next tree for next release. Thank you, -corey > > Signed-off-by: Pawel Zalewski (The Capable Hub) > --- > drivers/char/ipmi/ipmb_dev_int.c | 4 ++-- > drivers/char/ipmi/ipmi_si_platform.c | 4 ++-- > drivers/char/ipmi/ipmi_ssif.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c > index 680ff15c30ab..d576a77df927 100644 > --- a/drivers/char/ipmi/ipmb_dev_int.c > +++ b/drivers/char/ipmi/ipmb_dev_int.c > @@ -360,8 +360,8 @@ MODULE_DEVICE_TABLE(i2c, ipmb_id); > > #ifdef CONFIG_ACPI > static const struct acpi_device_id acpi_ipmb_id[] = { > - { "IPMB0001", 0 }, > - {}, > + { .id = "IPMB0001" }, > + { } > }; > MODULE_DEVICE_TABLE(acpi, acpi_ipmb_id); > #endif > diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c > index bdc481ce1302..fa221cbb4b3b 100644 > --- a/drivers/char/ipmi/ipmi_si_platform.c > +++ b/drivers/char/ipmi/ipmi_si_platform.c > @@ -387,8 +387,8 @@ static int acpi_ipmi_probe(struct platform_device *pdev) > } > > static const struct acpi_device_id acpi_ipmi_match[] = { > - { "IPI0001", 0 }, > - { }, > + { .id = "IPI0001" }, > + { } > }; > MODULE_DEVICE_TABLE(acpi, acpi_ipmi_match); > #else > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index 07f1d2327bb7..2361103c5edc 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -2057,8 +2057,8 @@ static unsigned short *ssif_address_list(void) > > #ifdef CONFIG_ACPI > static const struct acpi_device_id ssif_acpi_match[] = { > - { "IPI0001", 0 }, > - { }, > + { .id = "IPI0001" }, > + { } > }; > MODULE_DEVICE_TABLE(acpi, ssif_acpi_match); > #endif > > -- > 2.55.0 > >