From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0120B3C1D7B for ; Fri, 7 Aug 2026 14:02:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786111334; cv=none; b=E/9E04OXwzgCPCpmbc0TjWoHZ3Qi58VGOnaOeoi7lw1Q7oXd8AlVrdHyC5zbo47yK8H7lwBoIyIct2n3SZ8i8eJJxyu0c9glNNvKmXljABBHobXL57WJm4O7x/LnsLVtirEIYyNFTeI/p2aIN9EZJ+8uaVDYXd/3n3YxTYnE9UE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786111334; c=relaxed/simple; bh=eueKFyrCoAOjNxBIAcp/1tL216FxHIGJfb2nb2IdPYI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EnLCogziz65RdpF1CHZxejMw+VUl30JMneqgVeqc1UHAmavZey6yEZyJovSxBj9L0zBCQMke0Wsk3MGkoaXlvFvGW2+ryjLbl6/0GYkJu80S1O2g5hEFGiiOQQCosA2PVVWUPs/eZ5Fr3LAIOPD+SujEQHNxs6W02tzdEZ3zl7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=pass smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=izKcaAZ2; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="izKcaAZ2" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=H9XKfy6+pFtdCncWq+6zsw9ueT3VoFKNoejpZHvXfFc=; b=izKcaAZ2gxytqFBY9YbEu9VZ2i I36MK2oBRJXsQ7d5nYIxtMPU8dPgG5tcoKahg1wsn52S4Oc9pXmRiS200wPjC84NFxCfnBRduvdFZ JG6Cnave0uFWtSjrfkFoXv4LAdmJCUktQq19FCUjJY43jl8XbpGTOUUIgbNw/tBXdZBZ6KBexQGXo t+NpjPWS6LUk9Bsi9Nk8vpN7eR1BZ5LZvkJ2YF/QO9P1O+oDXfUbGNYju7oqtyUIgY1QnUW5TR5Nk GQbVKYcJqJF+hBr2wv7H7MT25neb+3mx+NG4IMXvFUWuH6GHfgofnM/EISXD1+89NRZnVhu12d3Aq /eZWh+BQ==; Received: from willy by casper.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wsL9C-000000097f9-30i6; Fri, 07 Aug 2026 14:02:06 +0000 Date: Fri, 7 Aug 2026 15:02:06 +0100 From: Matthew Wilcox To: Wenjie Qi Cc: jaegeuk@kernel.org, chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@kernel.org, qiwenjie@xiaomi.com Subject: Re: [PATCH] f2fs: return symlink writeback errors Message-ID: References: <20260807130445.465203-1-qiwenjie@xiaomi.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260807130445.465203-1-qiwenjie@xiaomi.com> On Fri, Aug 07, 2026 at 09:04:45PM +0800, Wenjie Qi wrote: > F2FS writes long symlink data with page_symlink() and then flushes the > symlink mapping to reduce the chance of exposing a broken symlink. > > That flush result is currently ignored. If the writeback fails, symlink() > still returns success even though the symlink is not durable and the same > operation can already surface -EIO through syncfs(). > > Return the writeback error to userspace and skip the dirsync flush once the > symlink data flush has failed. > > Fixes: 424fd5d831e1 ("f2fs: Remove f2fs_get_node_page()") That commit did not touch this code.