From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3ED137E2E9 for ; Fri, 7 Aug 2026 16:22:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786119767; cv=none; b=T89K6f3gYqFdCSwPLPkOwTOlNHdqIzkfsZfO+zJcRXdF8L750aTWz7xkw49OyhYXHXa0CJXT68Yn8ZR4/UcDuUwf3LqyYuQrURh/L6zb2xMVCu0IPxxpoCAVFOA23clXusXNa5eSejEiY2hPoJYr1/Br4im5MQcgVW54xoUSOkU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786119767; c=relaxed/simple; bh=nToylCqIVIRRoxvTuxCXuldsnYcCe1mc1KPvO0JTz7U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DxlJLaVsT5FIFoceSKRNmgsqWgxPrfA5Ijh+5mcjjW+OY3wrcXKy1glenaSTjidS+qOkCD+j1EgmH/WA/UAICzMDpINWAsSXYEinAHyMZwxnAfItBHj+RuVlGFf6BFlVfmQgbb2lwy7JPMJ/EnoFT1GmMNwrSXY+FGrOhxm1GbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EOfy6PaD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=POHwGjHw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EOfy6PaD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="POHwGjHw" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 677FRZ8B1418470 for ; Fri, 7 Aug 2026 16:22:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=V68gN1dWbWurMRqZ99HneGYh SLp2VJDyk+qChxkgrt0=; b=EOfy6PaDUH9ulR8dSqFB/RCwpIgodTYBB8sTmLTc uQhI7FdlEt+ZQubLmOJpeeeYhvwEzr48I+5SCVVGovGdBToIM4hZuUYlxmJgVxjy p9sRuh3JZX7O2xyo3dXzB/4OAVuAYaxsfWyiZaalrLxr29TorYugDGS3AZY3FIs4 Htq6O52nHzginr0hIguIuDDxRyJjN5vRFvj06Q2OdIgC25onA2108fb0di6XW82Z TCtSDZH+06ognT1K8AcTXty3t03v+O/b4pQpq8dpLp5cklsDBiDj9oJttjufJObY vV86qvLvBq5xwFJK5r0todO7Vh2+I852J7TCUJSM66qRbg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fwege17w4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 07 Aug 2026 16:22:44 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38dd87656d3so4175444a91.2 for ; Fri, 07 Aug 2026 09:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786119764; x=1786724564; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=V68gN1dWbWurMRqZ99HneGYhSLp2VJDyk+qChxkgrt0=; b=POHwGjHwZtF6jGW5g3YWczUQVya8coQ9bIsLWW8jJ8kIhaDpsfzO+hxb8dFvXz7nG5 5dVa5nr3sw9Mz8eIMBGXQj0ZA/JwdCkjarkD/i9RNL6NrvTOnJPnNpF9/pGitYMSNrRW Z7Z7HGH06YeEvYu0aBIVt2upa0Dx03DveA0dsm9kdGKsgGjqPLPsU8F8cf1UavddIWMk HSkIxYWvGzynMaMDrnq9FCmn6FpRY7cDv6RTfcRuq71jsqQd0XK6s+ynyXq+Q83oD6oW dvwphiS0WtkO3e40+ZM5JKtFFilKoe+KApfJEiSi4NgYUdcKSUA7fCnv7Ea9XRsdTBt5 OWUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786119764; x=1786724564; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V68gN1dWbWurMRqZ99HneGYhSLp2VJDyk+qChxkgrt0=; b=opiqvdu+PZ1asPxa23iudRNaNngVVKLPTIugpXxhlaH+dMzbuz9ovVyVV8JnrRbT1j KFIRLkQzcqSK/23YR/vfY+o2Xg92aNsYgRekU+O3fV25nnZVKaKzTvEvFudmn755EmNH P5IRkzcw3rYZ5dhCevwLu32wjt/msY4LjazMdAtGlbsuC4d6fB37Y1QkCLSm+u0KZDVH 1Kc7el/CcJdl+kVNMkYOqSNZe2HqGYyUrtktHpq8Qb2CND2x5ovDNFxV3+qoXfrBp/Zm dD/CbARK3z0ZtNVIm1ZeSYuZKIPVC6ccjznsSRhCtJwAEgyuNd6tgoltzXrqTctDKUlR VoOg== X-Forwarded-Encrypted: i=1; AHgh+RrFPpdz5ofr3uIM5cXlUajUzmrUVMvjDiL0u3FukSrFhxv+qUr9rdPpNdHb4vLHw3IgZs/Ri+5+oAMdhqs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3cwSlq/wMGkRMNElBdx8sAn08SBXEjdqQgNrcOm7h5FuXUSVU Z6bGPenn0Iv8F/kyX416+NMdxN6Lm45qg/ZOHZYClp2PewRd7gQYxm31G/KwXON2H0NhYbTCxg3 AXCVVaS9tyKUnrganYPRXJiL7/8HSUahwNAxeunW1OJoGZniiZhXRZN2GBFBCm+x9KhE= X-Gm-Gg: AR+sD12bPwRT6Trz5rBgs4T+JyNTcmA18tk2ZaOcdbuY95fdJeBOeIHSNoQeNN1WFFn k1yT4LuGxKm4dayXyhn5Pj3Rcn/b/9RjTPPNdvK23OJBYbTiBY3lwrMPPmeE9tOq2HPqlpNR5p2 um+Oj+bgmmGZsjZhbhjrmnPnqgpscN/2X8JXoRktn7A2lUpSn9XGpZflY1IBCgVRq7O7QMKXXQS YzJbjK/lrpH+OsEgZp1Nva0cEHhGR6Rba+UBMlHTpmJa1Z8YdYUn2o04iRR+lDNEcvm2+cpcJQu IgJ5A+aykT2yxBul81/x2K4GutUmwAHDuguC2PpVQbw75/o9QFoFYvc6Sg4h7EFvrn9RIqXDxc/ nT1GEqQGtcnAJH7YkMWtiBEEkKUvBwIrQ/mCjKVQ+I8C9TETZiWlGvIJSQ33wOqbdrEDSL9DAuU Ia7Q6RqiBdnQM= X-Received: by 2002:a17:90b:1a91:b0:38f:1dc:672f with SMTP id 98e67ed59e1d1-39282501a75mr767410a91.18.1786119764084; Fri, 07 Aug 2026 09:22:44 -0700 (PDT) X-Received: by 2002:a17:90b:1a91:b0:38f:1dc:672f with SMTP id 98e67ed59e1d1-39282501a75mr767342a91.18.1786119763638; Fri, 07 Aug 2026 09:22:43 -0700 (PDT) Received: from hu-mdalam-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be86d3fcsm9240408eec.4.2026.08.07.09.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 09:22:43 -0700 (PDT) Date: Fri, 7 Aug 2026 21:52:38 +0530 From: Md Sadre Alam To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Md Sadre Alam Subject: Re: [PATCH 2/3] spi: spi-qpic-snand: add quad mode support Message-ID: References: <20260716-quad-v1-0-636f74da17e1@qti.qualcomm.com> <20260716-quad-v1-2-636f74da17e1@qti.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: A_Y9fLbJFlBtHMPBHtZcORNyNqPpp158 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA3MDEyNyBTYWx0ZWRfX4JvGCJH/ILZf yl45de/7EJmVF0sLC3yzsAxK+aqUdJ+/EQBj9XwdQMIcbHShLLppfVleuUiuiJCsUsCkmRoq3/I InNRQWqwrv1vqZC4KyIP9PEasfcO7kk= X-Proofpoint-GUID: A_Y9fLbJFlBtHMPBHtZcORNyNqPpp158 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA3MDEyNyBTYWx0ZWRfX/GDW1h2WB8/z LnGEMXq8logze50n9lPT52m7ToY4mXoG7r5PMnU0+XSjwrSPKOmVSNA+B3hknH8G/yIbDO5D9lW EeYgfFsFgZKIxjuAsoTRo7nKEppXBAht4xeOfTGmLE9UKzj3YlUB41S4Bh83R7cmTrqkkDvM3eR +mDpGNiC51QWeLIyfzKDCkQkCfNibFoY+SfK+D+y/+L+zgZx81o2CzsJ4aY7xx336Iogh/DmHLl FmJwkxfQt7NbVWWOnd2/Os3uRKyhEWwMHcQh/VXUH/lj5B11e+lU0Xle8GrkTkpd2uufw4UyKXg WQW8z25UCfuWKr7PjjkdB29AQFsJ/vd+utLtq0xnMC9vT3G1t444xZ6RsoBg2zKedeCYYdgzodN Jth4kupuWbA48Ib8seHH230vP20OMe7qPSMXysgcFV0wQY88vLI763qF4Uc62HtntAB/64WGeta ilMaYwMmGEGgJpfVqYw== X-Authority-Analysis: v=2.4 cv=X71i7mTe c=1 sm=1 tr=0 ts=6a760654 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=IgOFGxCipB3eCMMLPuYA:9 a=CjuIK1q_8ugA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-07_02,2026-08-07_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608070127 On Wed, Jul 29, 2026 at 03:46:43PM +0100, Mark Brown wrote: > On Thu, Jul 16, 2026 at 10:57:46AM +0530, Md Sadre Alam wrote: > > Add support for quad (x4) transfer mode in the QPIC SPI NAND driver. > > The controller supports both single (x1) and quad (x4) SPI transfers, > > but the driver currently operates only in x1 mode. > > > @@ -1025,12 +1040,16 @@ static int qcom_spi_cmd_mapping(struct qcom_nand_controller *snandc, u32 opcode, > > *cmd = SPINAND_WRITE_EN; > > break; > > case SPINAND_PROGRAM_EXECUTE: > > - *cmd = (PAGE_ACC | LAST_PAGE | SPI_TRANSFER_MODE_x1 | > > - SPI_WP | SPI_HOLD | OP_PROGRAM_PAGE); > > + if (snandc->qspi->quad_mode) > > + *cmd = (PAGE_ACC | LAST_PAGE | transfer_mode | > > + SPI_WP | SPI_HOLD | OP_PROGRAM_PAGE); > > This succeeds but does not initialize cmd, previously we'd accept and > use x1. > > > @@ -1042,6 +1061,15 @@ static int qcom_spi_cmd_mapping(struct qcom_nand_controller *snandc, u32 opcode, > > static int qcom_spi_read_page(struct qcom_nand_controller *snandc, > > const struct spi_mem_op *op) > > { > > + int ret; > > + u32 cmd; > > + /* Call mapping once again to update the quad mode based on > > + * buswidth > > + */ > > + ret = qcom_spi_cmd_mapping(snandc, op, &cmd); > > + if (ret < 0) > > + return ret; > > + > > if (snandc->qspi->page_rw && snandc->qspi->raw_rw) > > return qcom_spi_read_page_raw(snandc, op); > > We never reference cmd in the rest of the function, either we didn't > need to do the mapping or there's a missing update. I have addressed both the comments in revision 2 [1]. Please review. Thanks Alam 1 - https://lore.kernel.org/linux-arm-msm/20260807-quad-v2-0-8ec821e2f22b@oss.qualcomm.com/