From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C66D9296BD2 for ; Fri, 7 Aug 2026 16:41:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786120881; cv=none; b=WgchroQdlLifwPTCgyuQYTb+44EH6ddyQ4Pe+oW6SaqKYqjdJPEwKZtQ8kGJCf/2hhDPmgCSy5jRlGchOUydroMtfMjtWf9fwow5C9O74EDyBlUUEDMaxyvzzgRFWRZTilHuHCrxgsYhIpDhcALXXNOPvGTuZZVMvLOrkPGUgTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786120881; c=relaxed/simple; bh=5dIqpadMbEk+y91y1iRNf6AuBQ+eubdCVgyrzqMMx7g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UTzHFsjKLTuV96afZu+zMZMQHe7qUbaEdYmhuvsQ2IDqM2B6fZpHXkaKgSvBjpssr044msHMi7Q37hwp0Qm9zVGG/eM+k7PgPrKD2N1ZI9LEjQBf+puy491bCIR4hGukmgtoofbujPzR5BgztYBN/sEzh3qjyxW1fatzVxdtNgw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bPxUNJJg; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bPxUNJJg" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5b013084dc2so3243991e87.0 for ; Fri, 07 Aug 2026 09:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786120877; x=1786725677; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=RDWNsbn8AaiOnT73If9FoLX/GoxxLjSClflI4U9QaJA=; b=bPxUNJJg7s97PatNAXTGQdQcsMOKfaWMjxzte/jNRrlyzHiMgE8jDbgQkA5jhidKNh S50pLt09OQ5IIxCpZ2HlSDpxU01NgYeapA663yjD2cyemZ/DJ/33FiFC0t+U8RhCmhd9 QGLP8jvwSnO7EWxjE/AU7clTZvG59SxsF2AoCWFpSoDp5TPqfDg632fZi2007NN6kGij 1xvibV6FeJ7isSGbxXf3PM5z/19lNTiHWeatEVHc0EnkT8mQ2+N5FC/j4M3FDRAKU/re pHni/ZcNiwqNnXQWvbwsXiwOvF5X8/wSQn5AH/YzaKzNiIR6UghAIY/WQOtszxNpT5h1 Zy8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786120877; x=1786725677; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RDWNsbn8AaiOnT73If9FoLX/GoxxLjSClflI4U9QaJA=; b=Nqz9I91gfO1NabYdDfxw/nUhqlMCrlwRRIcPpxJoBOxZBlFdoIuAVTQWKmhYHaXD0b Fk+xDr0pyh0Dd9DGkuy7aT5rgtH8sbPAxjfttWh+itM9KjbhqNTf9tezFr20V9VQvMQl FY8piTOpgYViFR6Xcg73G/0+++VejerGykJBGZV+Oyj/xTbDEkMxRK8i8SkBfF3tvqlN ojZJemQfY+B2ARsfBm4Mmj8WzT2kXNC/0WPcqhMF8SY2WKY06wpHfG0tZ9RMJUKyIEZM k0iQRd8LUWTwmZnbG/+/tdNrG5a7a9VJEJN8cmxLVQpbnmysS2FB3UIbkIcRjW///aLP 6xfA== X-Forwarded-Encrypted: i=1; AHgh+Rqzde30+Z/nQa9ZBsaCam0xZ2RIDJkUKXJCI2Pe2BqHCxAz4vwX8a75FvHO0Qp9ueYhOLePisdoKoygHUo=@vger.kernel.org X-Gm-Message-State: AOJu0YxO7UmjCKj/zbo3pFZi6Qb5uLHDzxI7C/EOW7H1Lsm5drwEY1qn iGAYzJ9F/wXJsKfp+lQ/Mr2AKBwaKPa33AMrx60uXASntuHuHrcsAirMurUo5Q== X-Gm-Gg: AR+sD11mDdlVhPqNSYHiXqtUlAa17X20Qyz/hxoMTzmCa35sdoZGXosubkLUviP0/Ng b4zal4XnhrKBH1LGnl8w75lciJhMZfdOxNu9Ax/rukqKH79yA1B8hl53qxCZNvX/77AQJApuj3d tEqGuBQDMMf6llD/ISprU422U5oxfhMarLv34VXRFLpXLPszS6ZJSOiT6Po0XJMUQ0nLAMfNJ+T Rq8y5M5L1IPTxv6XJ9fCDtTA7U5HNBTZFLVEytcQFp73fgtWR825VPC3JrUcgUcMUKOW2edqKQg 5yYObWR/xsuYUeN6j8kshjOt38Ar2GASXP+371F7o27YZcK3WbOvI15I83TbpiFeFQmA+wbdp5m KJ548qV1wnKmcXxyEcQsdLRVpfd9tTbXyuSEI+Uk+Y/Lu7Kf1wkREXm/o+WM8bxosEdKQYgC+z4 B1jY4m8yPbAuUmhmmwIPZ6EQnVBBYpwRUGismxqG7ny+Ft3tIM3Cv0zZTxb3g= X-Received: by 2002:a05:6512:3990:b0:5b0:eda:de1b with SMTP id 2adb3069b0e04-5b30919f542mr842704e87.16.1786120876629; Fri, 07 Aug 2026 09:41:16 -0700 (PDT) Received: from archlinux ([94.229.19.199]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b3050d0147sm568681e87.27.2026.08.07.09.41.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 09:41:16 -0700 (PDT) Date: Fri, 7 Aug 2026 19:41:12 +0300 From: Nikolay Kulikov To: Dan Carpenter Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: remove static HalDetectPwrDownMode() function Message-ID: References: <20260806-rtl8723bs_efuse-v1-1-fedb8b91f346@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Aug 07, 2026 at 10:53:17AM +0300, Dan Carpenter wrote: > On Thu, Aug 06, 2026 at 10:34:48PM +0300, Nikolay Kulikov wrote: > > The return value of this function is ignored at the call site, and since > > the function has no side effects (except for the assignment to > > pHalData->pwrdown, which is not used anywhere else), it can be removed. > > > > The patch needs to get rid of pwrdown from include/hal_data.h. There > are two reasons for this. > > 1) For correctness and cleanliness. > 2) It makes the patch easier to review because as the patch is written > now we need to check the kernel source to see if what you're saying > is true. But if we delete it and it is actually used somewhere then > we can rely on the kbuild-bot to find the mistake. Thanks for the review, I'll do this in v2. Thanks, Nikolay