From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BC534502F for ; Sun, 9 Aug 2026 18:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786299119; cv=none; b=Ilh937C8hufR+SXIUChcksyRSA2rZ0rDt0wyrwiVwI1JCRdFb1RTIVlKKSzLQGRkjUmFZL8Qsng8j87IJxlVdA5zzc8wQPmDIcT9x1EygmJr+o79kotSXdi9Mv8TL3A5YsDYTg1o5rgyFshQHPPpqF/8X6TlOHukQsW4oqlWLy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786299119; c=relaxed/simple; bh=UzgFFcq25sDDfKoaHn+VXHNND3WRXeDcn+AQuJuIe+s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aiDLNorPn8gjXAJNRXp4yUPmSlftXkEtdVHvJ5SQuOQwZi64gUk4vhN0vMh6lINSa5+zi/GndzTShD+pxBsGhbEh7U278kXsCYqHnuLpgj+lCauHgSSA1wiS059bRaUFVFHXjw8Vm3/5y1Te7oM8HSOroXdPpH4J3LcbbwqEDyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MgawpL/k; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MgawpL/k" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so1208096f8f.1 for ; Sun, 09 Aug 2026 11:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786299116; x=1786903916; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WoCA45LQ4z+3BUUhv5YOm84o93I32Yjtpc3HcvkQ194=; b=MgawpL/kCf5uzgQZ9wIdyINkMb4i8RmGxXeGUyAovIkCXqKoCEQhLjDqwPbP8RXIx8 gPxZahjgfTVta1wfywes6/ypl5DVuWViZ1R3Sk90f0LfG7heGE8mgh4Q/KNB/+s/zarH LKSD+i5K0RbuCRY1wm/3m5toyl+ZUHaeCLGfLRTjDs8WXUIyEQ92F9F9Eyy+yfwxFkCe XH/RBewNJNtiLScBusWQrBy3OdJ2PFQUri2PL33UtiTsLfI2w3gQhb3td99AKekkkeZ4 yL1qPLYqvR9EO0tfnKD7+Y0bGx6+zCtsZG9RBAb5f2bpZRNqG7ps+KrBd72moY0qXdxH bYbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786299116; x=1786903916; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WoCA45LQ4z+3BUUhv5YOm84o93I32Yjtpc3HcvkQ194=; b=VW8s03pe6Kzx5yL7wvpybe8GrWF+5q9hNcNfnJDFOTEaaMR76nxYpg7pavB1TXKrhn H0kSjlRENLCD+sKNlU728h9VHk3ieLZvReJ4RGC7N7mwzwKX9WdeG9eK8a3OPdZPlyCn b8lKtOMCjY8wozBVdFUuD/PDpaFrQdAvMmG+XdI1I7AAIH6aXiwVr/8f7tJepumOlzYp XZ5UJUODIDZuRkMKGIeYD/i/hZbJ2qDg5BsR/yBXB5JJQzCQrH/vfL1vHuf4AV7CtPFC RfIHvgftCGUowqqk2+btWIOup1yb1kTyTT9FP86OeAJUsk+9PugFY8ayo3qa/mQHGH8L nAww== X-Forwarded-Encrypted: i=1; AHgh+Rr7RpQrOP1u3n4gnf5HG+8sUAHtRTCB2Itwo2hEf1qBIZ7umEmQqTT2UG2a9FXS6pXKMINwo2tU19WQi+U=@vger.kernel.org X-Gm-Message-State: AOJu0YwtWyH6NB0qEm8pOvel/f2AroJGSSEJ+vibI5V5QCMGFqjTkic/ BFPYhPcQ1Vg8a2DDrdzlZtxNPHE0aABwGV6YNw9x2gj0rOkvGNkUSsmG X-Gm-Gg: AR+sD11tC6tvQ/xfbLXt4ebl5eYLVYvvUwJaY51Ay6k8YnA7xpW9bf+jZRjB0RHFl+7 fhPXqvsb9vw9U+NA9opFHViDicgmMQWtCy5zxQiuXO7ragnc00q76cl7BT7QOY/iWQsm1ZzTvgK cfZ0FhZHcJC++cWLUeQUOmnW/4OCqHHcaHZLg7KuvWBrUaiik0sDwk/vWoer1BiEC2QpOH+lDGY A6s2yHvnrbEnPcXGasHb08QWm00wYA4UoZiSjvqlKZcKXp7CQ2v8DD/CtQCHLCkWiIUYic11vCm UQVRBe/VUKaeBcGRABp76cZLa7CdQQY+TTDQfrPXNbxcUgHNkgkf6haXXmG0+5nt42Klg3C62Az 4waoErVJp/5A5Q5nOWijPLjcAh+wztMkznEGWdXWltvO95BCkGkOa5cWuxe5/qsWmxFe1Nhkczw jsrOB3rK5mhCBZZt/ZudKmfwEcxZMrqaBEkMY/dgm3RfZsWYRKeTFnRWireCYVSQijiNDBo0wk/ 66ieZol0F/JT/Oc44fMOK+jr8AZ9Bta7epCjiYsgtIeyWVwGtZ5xZIgCup1dv8/NzEZ02sJDiJd DkZqLT0+ifFq9YPKOYHSHNwhdnkZPRreAU1dHu98ayLTCICcwg3VERY6exv1hUdzlCC5s77cGaJ RDQ== X-Received: by 2002:a05:6000:22c9:b0:47f:e7c8:3fe9 with SMTP id ffacd0b85a97d-47ffd15cb0fmr36249046f8f.0.1786299116224; Sun, 09 Aug 2026 11:11:56 -0700 (PDT) Received: from MBP-von-Karl.localdomain (dynamic-2a02-3100-ac88-a501-9c5c-9666-3a00-3cdb.310.pool.telefonica.de. [2a02:3100:ac88:a501:9c5c:9666:3a00:3cdb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480020be8f3sm24111242f8f.0.2026.08.09.11.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 11:11:55 -0700 (PDT) Date: Sun, 9 Aug 2026 20:11:54 +0200 From: Karl Mehltretter To: Marc Zyngier Cc: Oliver Upton , Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: nv: Allocate the shadow S2 MMUs individually Message-ID: References: <20260803224405.41468-1-kmehltretter@gmail.com> <86mrv2arf2.wl-maz@kernel.org> <878q6fplpd.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878q6fplpd.wl-maz@kernel.org> On Sun, Aug 09, 2026 at 12:39:10PM +0100, Marc Zyngier wrote: > My current patch is as follows, and so far, I haven't seen much that I > like better. > Hi Marc, Thanks for your revised patch. I think one correctness issue is in there. > + for (i = 0; !ret && i < S2_MMU_PER_VCPU; i++) > + ret = init_nested_s2_mmu(kvm, &tmp[i]); > + if (ret) { > + while (--i >= 0) > + kvm_free_stage2_pgd(&tmp[i]); The increment expression of the for loop still runs after an error. I reproduced this with failslab. If init_nested_s2_mmu() fails while allocating pgt, before mmu->arch is assigned, the for loop still increments i. Thus while (--i >= 0) passes the failed entry to kvm_free_stage2_pgd(). The resulting log is: Unable to handle kernel paging request at virtual address fffffffffffff650 Internal error: Oops: 0000000096000046 [#1] SMP Call trace: _raw_write_lock kvm_free_stage2_pgd kvm_vcpu_init_nested Thanks, Karl