From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FF703BB9ED for ; Mon, 10 Aug 2026 11:24:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786361085; cv=none; b=Xa7WcZEyYdP+diL/fEqoNY5d55/1LOZ6G2DMdMnfRMG2nRxWAVW0G6aQZcsYNOiHdjIHUZnV2iqi3WO0wBouQAFufrPJPZwQ7DA6xTZv0AHHtkZTMDRSjSOKuvY0nVgq/IkGTCnN+gluACaDVD2cSXPjIH7M5QakojYV3ArZFS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786361085; c=relaxed/simple; bh=kHbxdIKlkoJhCsu1Y8hGDv+v5GDmj3RkE3QDJfH5ngY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PONB7txpBy5EqrNRiS2TxEVuurv/5DAdJStG3Cs8NrbWvuxg3gMXBcR6lu9h2jXIBF+bB0HqTfAzQcNBg+OOt1wsNSVOXnsDI7XWHscHU6QQbeGrneLTLHUYPeNUnWnp8gslyPWlDV9tlH9qMn6KZwl3UqkLZljtk+iJWjlKpKE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WGGCHlV4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WGGCHlV4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E53291F000E9; Mon, 10 Aug 2026 11:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786361084; bh=kqy591bSdqJfZU1CUf17dSEwotSknUKpk2/rMLFaYV0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=WGGCHlV48DTyVindebrMZ98u9y6jHtZgG1J/EhwrsMZe/DYstv3JrOq1iRBCKNzbR OmQ2Wr2ClN+rGOG0H5ajhmhIfPI/37pPABDH9xX/AlwBHSJIkdcXOAZudNltniPWEj nMqBlmfRwZFb+dVnG2aBeNE8V7yLyGx7DvCzIi28Nv9HLK73il4frNbe+0n5YzQ5Ml +lXjN5zHzLw8JGXvHE3P156tFDZTNyTqCiIU9/pxDwE2ARBjOdvwHdxJUTz6H/HdOY Wa/Cw2tz+RzngYoi9UpyqXKjUgjb7W1sAa90XtbIlxp4WyxpsaRpkOD15+ySWurx6Z IQxi0yJPv4lHg== Date: Mon, 10 Aug 2026 12:24:26 +0100 From: "Lorenzo Stoakes (ARM)" To: Hongfu Li Cc: akpm@linux-foundation.org, david@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongfu Li Subject: Re: [PATCH] mm/cma: remove stray newline from auto-generated CMA area name Message-ID: References: <20260810093215.91419-1-hongfu.li@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260810093215.91419-1-hongfu.li@linux.dev> On Mon, Aug 10, 2026 at 05:32:15PM +0800, Hongfu Li wrote: > From: Hongfu Li > > When no name is supplied, cma_new_area() generates names with format > "cma%d\n", introducing an unintended newline character ('\n') in the > CMA name. > > Most CMA regions are created with explicit names, so this path is > seldom hit. The newline only creates cosmetic noise in debug logs, > traces and debugfs with no functional impact. > > Signed-off-by: Hongfu Li LGTM so: Reviewed-by: Lorenzo Stoakes (ARM) > --- > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index a7929c758df1..a10ea37a261d 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -242,7 +242,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size, > if (name) > strscpy(cma->name, name); > else > - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > + snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count); Ha :) I think somebody typo'd this on muscle memory gained from printk :) > > cma->available_count = cma->count = size >> PAGE_SHIFT; > cma->order_per_bit = order_per_bit; > -- > 2.54.0 > -- Cheers, Lorenzo