mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: "Matthew Brost" <matthew.brost@intel.com>,
	"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Mika Westerberg" <mika.westerberg@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Andi Shyti" <andi.shyti@kernel.org>,
	"Ramesh Babu B" <ramesh.babu.b@intel.com>,
	"Michael J. Ruhl" <michael.j.ruhl@intel.com>,
	linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v6 2/3] drm/xe/i2c: Fix the interrupt handling
Date: Mon, 10 Aug 2026 10:24:03 +0200	[thread overview]
Message-ID: <anmKoxMONVxf5FoK@black.igk.intel.com> (raw)
In-Reply-To: <anlbyVOUkafs0UHE@black.igk.intel.com>

On Mon, Aug 10, 2026 at 07:04:09AM +0200, Raag Jadav wrote:
> On Wed, Jul 22, 2026 at 03:35:53PM +0200, Heikki Krogerus wrote:
> > The platforms that support the interrupt from the I2C
> > adapter can not handle the amount of interrupts the adapter
> > generates because of the way the IRQ is routed in the
> > hardware. The I2C controller driver has to be kept in
> > polling mode because of that.
> > 
> > The AMC MCU can still generate critical alerts that have to
> > be handled. The interrupt from SMBus Alert is left enabled
> > and handled separately in the Xe. The alerts from the AMC
> > will cause the device to be declared wedged for now.
> 
> ...
> 
> > +	alert_reason = response.value;
> > +	dev_dbg(&client->dev, "Alert reason: %d\n", alert_reason);
> 
> This came up in one of the internal reports. We have quite a few call
> sites for wedging and it can happen due to various reasons from driver
> POV. We really need to identify the source from logs when it happens,
> so can we atleast have this one as dev_info()?
> 
> All the reasons are rare enough to not spam the logs and it shouldn't be
> a problem IMO.

Okay by me.

> I'm okay with doing it as a follow up if the series is already merged.

I don't think this has been taken anywhere yet. I'll send v7.

-- 
heikki

  reply	other threads:[~2026-08-10  8:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 13:35 [PATCH v6 0/3] drm/xe/i2c: alerts and controller enabling modifications Heikki Krogerus
2026-07-22 13:35 ` [PATCH v6 1/3] i2c: designware: Global register definitions Heikki Krogerus
2026-07-22 13:35 ` [PATCH v6 2/3] drm/xe/i2c: Fix the interrupt handling Heikki Krogerus
2026-07-29 15:30   ` Raag Jadav
2026-08-10  5:04   ` Raag Jadav
2026-08-10  8:24     ` Heikki Krogerus [this message]
2026-07-22 13:35 ` [PATCH v6 3/3] drm/xe/i2c: Keep the i2c controller always enabled Heikki Krogerus
2026-07-29 15:34   ` Raag Jadav
2026-07-30 11:03     ` Heikki Krogerus
2026-07-30 11:07       ` Mika Westerberg
2026-07-28 15:50 ` [PATCH v6 0/3] drm/xe/i2c: alerts and controller enabling modifications Heikki Krogerus
2026-07-29 15:24   ` Raag Jadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=anmKoxMONVxf5FoK@black.igk.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=andi.shyti@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=michael.j.ruhl@intel.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=raag.jadav@intel.com \
    --cc=ramesh.babu.b@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®