From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEC6E3DB334 for ; Mon, 10 Aug 2026 12:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786366690; cv=none; b=XVGhRTQaLg+mozYuOywBZlTsc4rtj1mS6JoTAlZRR0iv/RvQJFblnrR5qUG0BUVzf0mv3R4uE773Rz8i4lwCq4oU+faSceP2HVFTtNoGHFax9y9GBXXFtgayXWqqEquSHyTRHpE8+Clqn/qEoNNO4wwkdB1hI4LUcp+7fBwH6AA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786366690; c=relaxed/simple; bh=3VWMmJxvbM+LgvX+jVMh7ZTt/oelzRBIb6RHWDNx1EA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pQmi1HkWerXdcU+IfkrUdHotOc6EfzlLNx3I3NiqQaqhdyFK46Nu7acN7o50+FNpvmuL4IpYXKVxiZh2AfzVmKSPYfdwbE95+nfQjV/6atv308NE2SgjDn9Rzzt3jKAcpl2zpime4IsDphyOh7FRBdbKWU8QRq2VsyXtroUwNmo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JDB+Xqxn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JDB+Xqxn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E32671F000E9; Mon, 10 Aug 2026 12:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786366689; bh=jm5ze2mKCra9ETsO08n0wkCgcjZ1SmD1W0aM31gY5N0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=JDB+Xqxn+YpgM5EgiNfcdYAP4X54PmDsvZ6Uo1Lhrq8JPW24vfyPszo2hGnu3XK9J tQJ1eXyNRayWYos0l5DjDOAskJIJB/MOHUaTmspTb15QJf582OsHe4zJOPmPhR0SGT A83zZcBlNYRXRk6sK9eQaXT/xrEjHAU7VEaKMOV6WA+eKHcZi+SF/0PM51SlLvSOaT +4rWg/ZkPwmiXPEeL3jGMPMrtakKc9Q4crVxiO+t/cqfpaovNjLKwcStR6Lq3PNnwf L9VJcd2d7H70FzRYb2u9cRSoIbdQEsHqtUcf4zk7kYVUqTp83YOSgmfnvy7OdHTKn9 czmrWIVsH/Ivg== Date: Mon, 10 Aug 2026 13:57:49 +0100 From: "Lorenzo Stoakes (ARM)" To: Tal Zussman Cc: Andrew Morton , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , Barry Song , Youngjun Park , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Matthew Wilcox , Christoph Hellwig , Johannes Weiner , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] mm/page_io: refer to folios in swap_writeout() comments Message-ID: References: <20260806-b4-page_io-folios-v1-0-0899bac3b826@columbia.edu> <20260806-b4-page_io-folios-v1-5-0899bac3b826@columbia.edu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260806-b4-page_io-folios-v1-5-0899bac3b826@columbia.edu> On Thu, Aug 06, 2026 at 06:55:37PM -0400, Tal Zussman wrote: > swap_writeout() operates on folios, not pages. Update its comments > accordingly. > > Signed-off-by: Tal Zussman LGTM so: Reviewed-by: Lorenzo Stoakes (ARM) > --- > mm/page_io.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_io.c b/mm/page_io.c > index 8573f7b8967a..b18d3b7d853c 100644 > --- a/mm/page_io.c > +++ b/mm/page_io.c > @@ -208,7 +208,7 @@ int swap_writeout(struct swap_io_ctx *ctx, struct folio *folio) > goto out_unlock; > > /* > - * Arch code may have to preserve more data than just the page > + * Arch code may have to preserve more data than just the folio > * contents, e.g. memory tags. > */ > ret = arch_prepare_to_swap(folio); > @@ -219,7 +219,7 @@ int swap_writeout(struct swap_io_ctx *ctx, struct folio *folio) > > /* > * Use the swap table zero mark to avoid doing IO for zero-filled > - * pages. The zero mark is protected by the cluster lock, which is > + * folios. The zero mark is protected by the cluster lock, which is > * acquired internally by swap_zeromap_folio_set/clear. > */ > if (is_folio_zero_filled(folio)) { > > -- > 2.39.5 > -- Cheers, Lorenzo