From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FE5930DEB0 for ; Mon, 10 Aug 2026 21:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786398085; cv=none; b=FrQBUuiD+jlpDJN8nb36OWFSllWpQH9ln+nY9gfC4Ju0qlj1CXDVCSk+V1xBqzpzzUEBnHadzVY+WfZ+w2OSY8gmtmYF0LxXC9KLxWqogPT32ZK0od//iFXZDrAvnBe9deHBi2TuU9w95pUSKdgOp6rPLUn+9dGA7vXrIASkJv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786398085; c=relaxed/simple; bh=eNehOOyCnA+TvMrb51WPBynhLdkKEUG8Hc/NtvKGWvM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G+JiObkftInpp6exQNZNtTxStrZJlIwGHQk4SjoxMhJeZcrMUggw5UAkh39BYjibXArlm7gx/dycLb4OLjbtK05IYZcAUHO6qpEJBJ+7V7hgF/6i5VKuPmMXNJG89DhgiXLACwt0Xgnu9fHRRnW4lGodh/6oP1g0S8jXnYNBuEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BIf0a4iP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BIf0a4iP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08DC81F000E9; Mon, 10 Aug 2026 21:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786398084; bh=qazjNMFP/R5ov2W1PDDFuI2t1286IJY0JlH3qKHQ/Uc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=BIf0a4iPPlwKNNneg7mo8uJ0U55S0NWs35yt4Jd5ozOuarIVgBpe364PFalnOD9g4 b8ox7P/2tvUER7Ic8AAFYRCtteJHPP8sK8npRiiKsfVhyM25GUoWaqY8Y5SAtqohZe dR+oFo5bj43Ymw39jVjU/+WNNDZgpL7x0hESusYJKKk8AP6ktvw5MRbutQpbXst1nP vV1+axRQLUXuynF5hiCRfitoirpGIA39kv7TVYvbPSPDY6Y97wB8CSeeDvBg+VxOyC NqRSnEnko1s9GHq9kxCL5oFpPQeLSpewjKTUAu27KGU9QU9n7D+1Nwd62pqLSHgKAx y2dOdDYs0yO6g== Date: Mon, 10 Aug 2026 11:41:23 -1000 From: Tejun Heo To: Breno Leitao Cc: Lai Jiangshan , linux-kernel@vger.kernel.org, marco.crivellari@suse.com, kernel-team@meta.com Subject: Re: [PATCH v2 4/9] workqueue: account nr_active by the backing pool Message-ID: References: <20260805-wq-pool-refactor-v2-0-fd498d01d695@debian.org> <20260805-wq-pool-refactor-v2-4-fd498d01d695@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260805-wq-pool-refactor-v2-4-fd498d01d695@debian.org> On Wed, Aug 05, 2026 at 07:52:31AM -0700, Breno Leitao wrote: > static struct wq_node_nr_active *wq_node_nr_active(struct workqueue_struct *wq, > int node) > { > - if (!(wq->flags & WQ_UNBOUND)) > + if (WARN_ON_ONCE(!(wq->flags & WQ_UNBOUND))) > return NULL; This just pushes the crash to the caller, right? Maybe do BUG_ON() instead? Thanks. -- tejun