From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99DB1346AE8 for ; Mon, 10 Aug 2026 22:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786401170; cv=none; b=YTXyrWsbqZYxa/VZkJxviZeG29GCqMUZHwdN3w9P/l90W80CC9eB2L4K2TFEu/xe7EsJ3h+VYHWNpOi2+IYr38j7DEmbZxkIUUvLZE5eH/SwA1Zpe1jDfrM8+nzYsYLueDoeYBd+URA8mTKe3BV3usZIyqjKANndflcquUQQkbA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786401170; c=relaxed/simple; bh=Ut4xeXPIHkP/ZTuqOULeqn9lHhqonacl55jKH6OZGjI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hRE7GsPnpBTFdrPSKFR2OB/0TOBS/xDi5rwd+cNueiuV4hdXdffxj/Vupx3f2jGJoGCJ+quZ2mAbRl4e5ACPcKGzQnYMkKM0nR6HyFRQvVj8lr1teA3yM0zcfycJ1h1bSyegEl5a7iChPBOxu3sFDlKftqm7eDYcrP+jPmaD+Vo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RuT7T2Zw; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RuT7T2Zw" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4954df200ddso15923255e9.0 for ; Mon, 10 Aug 2026 15:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786401167; x=1787005967; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KujuDXjufsH4fQ0xRNZyj2JY4LmTzir+J1KJ4jS+lJA=; b=RuT7T2ZwLNQPenYetKWr8rJ5pQT5JJ0eOBf+HAjTBB8PasKUtZwme6mfvNs5PRbnLe QL/QjD8RTohL7azkidFVUJ2Ds8lqO+DGVz62nijJ93NeeCidk28noUwIwGfVVdT4ToNf pyO+XOrRzWNvRLOAQoOAh27rrLIGdLnUqtS9gJUb3nrGCLJovozhoeONz4S8kZqDA3dB y7rUXIg1YfybEK3kNLlJ1b1GNCWrvNol36ZbgYJbLX3Q32ZqjUkkeKijy4zcseejj34T HeLSMaWSRUtfaLzc9BOAR88gr6ReERxkONDIUT5n04vVBfbU5vIV9a2EUeG0eMFdzyul W6gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786401167; x=1787005967; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KujuDXjufsH4fQ0xRNZyj2JY4LmTzir+J1KJ4jS+lJA=; b=sW3/mrVSK/VmiiUuzNEJWP7ml3VZhy9DVHvSdHjvj8PtekCCeLqXnhwRvVQiJNFJjv IQMSV6X0CY4TUmKO0ynkj0RZ8jxoFe7qNuwrd66WtnGd/ax5XJqenzStcP7WsviR8JLZ QZFCEnQXvYBS6FeRmHdRr1+KbsAveH/5lA1xohFnzJKYAhLdhfF0FlsBRX+LhHHVUjAu 8k7/OFWUhUjVKBhTDzOEnHkfdLyx6SmGV4w3EylhS/iRFs/cWo8O6yTr9VrlYsIiuL9r 0pMO+d4zMlyjOYKsQOT3Ppy9dsMPgey0+ioJYChYotESBlxcd0Kz8hdqKzvJcqp7m8qI 6wTg== X-Forwarded-Encrypted: i=1; AHgh+RoW+GLs1WzIKWy9DtgOSYNWA1D+iJd8XWTK4/TsqGs57poUg8kvkAMAE7tXqQGIdCMzyyrEpu3OLY983uA=@vger.kernel.org X-Gm-Message-State: AOJu0YyxbP39Eb/OB10T3PH07cBNEtl7iTbFUSiC2ZuybhaXzU8icgAW 91sZR5gBHKcmzcHS61b0vbBev+HjdeoaqJ2ZgimBQlB6vbaNniOIv7Y8 X-Gm-Gg: AR+sD10l4XvRCABl5oToGm1fLtqRwzXVHxwv3zJnkXbkaDZULrdohWqbGf5AhDif7H/ OmgeZJCSF6Kd+FSSb8CzAn0AyuyHusdT5LrumDfpUJ47Z8qEWBc0B61klWE2uKwAp8RF8ZQyGRf gG8X1dZ8TgZSb0UEkPpz5HidWqMzxr8ONT0BAPfCPRETT0w7xFVgShph1LnMWh1obYeBStNE6ME O0F6CrC8H0SaAW4Nj+9kWsD2gOWTs1V9Hway/dHYUaiDuv057ZEK53HvDmRLyEm6/C4aarD5PQN Xx1E8ughZb5nUXq61ZgsrIR7HZP/g4Q+MJjfT189F50x/fasBzzDJxoJIjFD9j1TO8ml2sZhtQQ a+7kAn4/W21Sx4aKjmizBFrQj3kvYYy4mLGLoR6C+vpqJdunf+bycayPSMA4BNZM092vPeOc8iF rlnrN71NC+JinnLY3DM+PEVXfbBQCNYfQlamFfXIxwwTRp7wmqNp/6Owu7YSnCmnZ2R6UGmCfPw zscKns/Gi8AoeouYwloAui6kz+zwyd3f+36t/kjEvFcb13+1JesiUlvDjJg79x6Q4dXr5rz4YI3 00GociK96CmZwyEQ0k+Mml2nkjMhNERt4KcoIrj7wr9cMSl/XXkNpbIjWikc6tnFp7dmmiI= X-Received: by 2002:a05:600c:8b17:b0:499:726c:50e with SMTP id 5b1f17b1804b1-499727b1011mr49652125e9.14.1786401166552; Mon, 10 Aug 2026 15:32:46 -0700 (PDT) Received: from unknown748F3CBA5068 (dynamic-2a02-3100-a1e8-7401-316d-6c00-7a9a-8fac.310.pool.telefonica.de. [2a02:3100:a1e8:7401:316d:6c00:7a9a:8fac]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4995d85254asm153382245e9.1.2026.08.10.15.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 15:32:45 -0700 (PDT) Date: Tue, 11 Aug 2026 00:32:44 +0200 From: Karl Mehltretter To: Marc Zyngier Cc: Oliver Upton , Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: nv: Allocate the shadow S2 MMUs individually Message-ID: References: <20260803224405.41468-1-kmehltretter@gmail.com> <86mrv2arf2.wl-maz@kernel.org> <878q6fplpd.wl-maz@kernel.org> <86v79i9zl7.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86v79i9zl7.wl-maz@kernel.org> On Mon, Aug 10, 2026 at 08:58:12AM +0100, Marc Zyngier wrote: > > The increment expression of the for loop still runs after an error. > > Yup. Should be fixed with > + for (i = 0; !ret && i < S2_MMU_PER_VCPU; i++) { > ret = init_nested_s2_mmu(kvm, &tmp[i]); > + if (ret) > + break; > + } Yes, that fixes the cleanup issue. I have no other concerns with the patch. Thanks, Karl