From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id F01683B14CE
	for <linux-kernel@vger.kernel.org>; Mon, 10 Aug 2026 23:13:38 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1786403619; cv=none; b=LuQFeUSQbt4adKtViN1JEKPxovc8ruZkR6KJgu4pAcNVHvt16HJm0rPt4MwieMK37aaa30RQHY+jgWrObzmP4E6BBJKXbq0PjPUBC9XTj0JM7CZciPbDM6Y9GF8tyZr3KTPpuM1tCSmU5qWSlo020nNjNxS6CYB5ezOBXuSbfKo=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1786403619; c=relaxed/simple;
	bh=7SE9gv2aM6fWpoyXgXSsOOxYcYEnmi0qWr+Oq1tEGko=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=DTGjjWmKhT4KJ6LdM4VUh3XeRVaG/PjK8pzNr/yOmJg2iaGvLA8eSK2Rj47R0wyYf8Ns9e6vKSKF+yFFNd3HTNxx12D6NFn1mxGKXp8GsDcHTDTMh1FTEnX9r1UFO5q3wCw3d1sYAoH+LoaIJ+0EJqTDqsXBu5qGsAyHqO3V5L0=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jdFLDosd; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jdFLDosd"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3840A1F000E9;
	Mon, 10 Aug 2026 23:13:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1786403618;
	bh=7SE9gv2aM6fWpoyXgXSsOOxYcYEnmi0qWr+Oq1tEGko=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=jdFLDosdz76V9vUvd1dj/4PrgTk0HhoisBmUzrN0DelsXKCRVWDMywuv/DJv0EjNh
	 Hkpb74aUKmo96WI6HgwTbiBGTHo+Yj+7u3+H+xH/FypNGGN4jMG7P54qo8j8nyXBRW
	 NkP+e5vcJMnoum3vPk0G+xIJUZrTfNHNSi6Ry/Q6J+OCzT8Ciq3M5ns2+Yr3+4U2eb
	 0cEtP/12h+kST98ZiSrdXO2o2MOTtkBomnNWBrby/EdQJZJfCfVnQgRmzGtqS+hza4
	 DUkaaA3Afyfcc9a79NT+0oDwSeNzURhacekUKUjiXaNfjWXySvUIHQ3LvEZZGIM+xQ
	 bZFvJ+m46rTRQ==
Date: Mon, 10 Aug 2026 17:13:36 -0600
From: Keith Busch <kbusch@kernel.org>
To: Chao Shi <coshi036@gmail.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@kernel.dk>,
	Tatsuya Sasaki <tatsuya6.sasaki@kioxia.com>,
	Maurizio Lombardi <mlombard@arkamax.eu>,
	linux-kernel@vger.kernel.org, Sungwoo Kim <iam@sung-woo.kim>,
	Dave Tian <daveti@purdue.edu>, Weidong Zhu <weizhu@fiu.edu>
Subject: Re: [PATCH v6] nvme: reject passthrough of driver-managed Set
 Features
Message-ID: <anpbIKTNY3SeZxSq@kbusch-mbp>
References: <20260715155752.3363247-1-coshi036@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260715155752.3363247-1-coshi036@gmail.com>

On Wed, Jul 15, 2026 at 11:57:52AM -0400, Chao Shi wrote:
> Since commit b58da2d270db ("nvme: update keep alive interval when kato
> is modified"), a Set Features (KATO) passthrough command lets userspace
> start keep-alive on any transport. nvme_keep_alive_work() allocates with
> BLK_MQ_REQ_RESERVED, but nvme_alloc_admin_tag_set() reserves admin tags
> only for fabrics, so on other transports the allocation trips
> WARN_ON_ONCE() in blk_mq_get_tag() and fails:

Thanks, applied to nvme-7.3.