From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A63F43AFB06 for ; Tue, 11 Aug 2026 02:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786416336; cv=none; b=A6WNV7ZEKYWmubQLmxw9UnPJd4PN6dl4pd5brWotD7FDT9b+vATdcxnWHRRF9xcNDm81m91V+DCJli9Y7H5/yfN+h2CfqbWbAGZZT6ES78JwS/9Plb+DfRda0zzWlQGNRa/4ynJiKyVcJ2/Ui0TbE8pThFs0UcAPaSgrsgqTyh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786416336; c=relaxed/simple; bh=lX4DHJLmOFL2hJOsNkjbJDJK9Gej8ssxYmi+Jgr4XxA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FiuiUr6IvDvwEx4QWkGWSrriMfOJCjwFxIFb7+V0F6QVY++4W2+EbOnJyQu/5CaKtI0oDkpqF2TUE1Feq6LZLO8LPnwRhS2PPQl1FszYKYRDYQanXMZAJfgbim9EB9BehiG0WGE/ABxlpKVtdfdMxvnfTqo5k8Dn2dkstDTrDsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=o6CB5ann; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="o6CB5ann" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cfff5f88dbso39125555ad.3 for ; Mon, 10 Aug 2026 19:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786416321; x=1787021121; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=LhWDK5hddMROTflmtcNenCZqcdR+LSNsUsjL3zUAaNE=; b=o6CB5annWGCwgRV9gWqqHffxj8MtdMbCqK7ZywDheOG3P2hx46ms+xH14eP1D5KkwC TppXWbVHowRnzUO5Y5VSeBdhfFFPoBq8varq+vAgzqsFFZuN/cmvuW6kMAJL1s4Xu5Uz jRSz1JeOZeDhHeh8MxGCevor6J0KhWhlg1jCIUfqrkh2260I0g7d1BuYyTYt2Idw1Cct HRxnXSXPsy1qXq4S8c1l4ZxZEn1M7+4k1V9i1N1IQ+gwWPHw7IO5onQTdEfOcM8SYBtf /uSbFDlrQYesX/ygYvczqMzN6VsNyCtH1RACHRdliGHgMDQCOIkXgQjlGtZtU0QjzB1g qOrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786416321; x=1787021121; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LhWDK5hddMROTflmtcNenCZqcdR+LSNsUsjL3zUAaNE=; b=EIKnPlrCtkVa++87zfIq0tOajOMCO94d3CdDfI4F4Gd4mIftcRoJxxpG4DeAJxnAj5 xmfm2j4FX5Ww7JOHe4ZZqU1IOwawvWmsdoCTx/lKqd1RMlVB5wEALoOODRi9mpaPNV+b 05NhMMR9B5nIY3MUOBybGTqXR2gN64761a5SD/z6oMJBeHxhwGh0nOMyv4Q9mYDULj4X eYyGyemQ0l32oW+wzCK/jq1Y6RLNsqW9nNrqy/ijtlD1/++7vlx+h4ivugIkylaka2BI P9S/M6wMXzHpekwh2cLgcQhIBkxiS6yDf+NeXMY5PvMz4ip+d5TtgbYxS5I1HJW1120j SYcA== X-Forwarded-Encrypted: i=1; AHgh+RrU+6/lC7aPX+61d1+HOTW93Ge5FT4T2NhUD9is4WWgUgfEQt3wHvMKbl7MUUzX8zz9pc/EB+9VVzWl434=@vger.kernel.org X-Gm-Message-State: AOJu0YxufyZIrAQhjQTjqeeD3z/0kaM2X5EHDpyJQU39apxisSTFQ4RE JqtKY2N04+B7BzZSu/fDWTzeWFkfkUQU+c4KXyB4+uY7dX1P0VnXG6rT X-Gm-Gg: AR+sD11MNrncsBa6YYp69f5XlCI3JxJEVtprFfA/k1Y7iZ8RkakxMMRlEWi7jve2G38 V9q7pCOp5UYWcg2Yg6eJpSPq5CNx/f7HKQbnvNJZLc4csCdqpxa8ofw6xnfZZ8bVxS14/t2Djod 6EONjbctJDROOAmBwosJFW8qoHpM73bYkJsQI5HIkMwhz+E8L2rfDBDQPSMqsW+XSqnMVcHmft+ EJ7ZT/FnB9/Itwk9G2tevMIEN8ziffLbPN8KCrARcpc0jwf/F76UqNP3SDVK1soWyXj6J+k7x/B tXrKN0q+jYh4J4+ICihT4QeCxiSIEOw0rQd6jZ9+6Dcl42+xMB5EGj4dN2r1ri4LEWa7txkWMuT vlCT/iSksOvklYOsWHHWzHkO11qISAcVB0nJ3uq4ZWVCvn2eOlYO6dYpJaFoQk/etuhmTvl2xbl goJo86HqYyXFWnWgbtVCJVpW8npkWWSYDhDyk8J8kfBgy597sAzX6xUzJ302MeqXNHkHakDR+Vq lKiCHYh X-Received: by 2002:a05:6a21:1fc5:b0:398:8870:b58f with SMTP id adf61e73a8af0-3cc2b872b58mr522952637.14.1786416320953; Mon, 10 Aug 2026 19:45:20 -0700 (PDT) Received: from localhost ([2804:30c:4018:dc00:8be4:f5b8:4af1:4728]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1412035e08dsm151216c88.1.2026.08.10.19.45.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 19:45:20 -0700 (PDT) Date: Mon, 10 Aug 2026 23:45:55 -0300 From: Marcelo Schmitt To: Andy Shevchenko Cc: Marcelo Schmitt , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jic23@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, dlechner@baylibre.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, julianbraha@gmail.com Subject: Re: [PATCH v9 5/6] iio: adc: ltc2378: Add support for LTC2338-18 Message-ID: References: <39f2ff86cf736ff97286d6451fcc45fdba6732f9.1785186980.git.marcelo.schmitt@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Andy, On 08/10, Andy Shevchenko wrote: > On Mon, Jul 27, 2026 at 06:31:58PM -0300, Marcelo Schmitt wrote: > > LTC2338-18 is similar to LTC2378-18, differentiating from the already > > supported part mainly on the embedment of an internal voltage reference and > > addition of a resistor divider network connected to the input signal path. > > Extend the device driver, handling the internal reference and input signal > > attenuation, enabling it to also support LTC2338-18. > > ... > > > +static int ltc2378_refin_setup(struct device *dev, struct ltc2378_state *st) > > +{ > > + int ret; > > + > > + /* > > + * The internal reference buffer amplifies both the internal reference > > + * and REFIN by a factor of 2. > > + */ > > + ret = devm_regulator_get_enable_read_voltage(dev, "refin"); > > + if (ret == -ENODEV) { /* refin is optional */ > > + st->ref_uV = st->info->internal_ref_uV * 2; > > + return 0; > > + } > > + > > + if (ret < 0) > > + return dev_err_probe(dev, ret, "failed to read refin regulator\n"); > > + > > + st->ref_uV = ret * 2; > > + > > + return 0; > > I'm not sure about others' preferences, but I would do it as if-else-if and > remove dup return 0. > > if (ret == -ENODEV) /* refin is optional */ > st->ref_uV = st->info->internal_ref_uV * 2; > else if (ret < 0) > return dev_err_probe(dev, ret, "failed to read refin regulator\n"); > else > st->ref_uV = ret * 2; > > return 0; > > It also makes code shorter (in amount of LoC). This has already been applied to IIO testing. I do send another version of this specific patch if that's okay. With Best Regards, Marcelo