From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 520D62D8DB5 for ; Tue, 11 Aug 2026 04:29:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786422599; cv=none; b=XgWtEphUYvyx/5fSzi1LHw4m01gvpnhvtFyc13BPvjFH7sr0hLXuhakkAaQgaAIGrHwYFpnTv4AwXwOkUgbqT81RXK+pf/PlbKzjFpkwiezZM6GVaceRuhQvL/8aYfJRkm4DKfIQFjRtJ1hot/nbOIWOUu1LOUISpLVUaCqzJGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786422599; c=relaxed/simple; bh=S28ohBK9dXBiLnQQv+dZI37NtJ2g0+ZDJxpqPoLWBS0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LSoY7mzbyI67nNFs3Fl8y6yW8ouNapVmR0f0Hr0nb+aPpfHz2GSS05FUO06dKaKNCq4o9bF6/zFjgkr1b0X1j3LZE9BUMXG7AAsMXCT/lsDhBY1Kn36wE+jxRWji9KSHR9i8FetjhB/LR7nxZ5Kdw+elcXHnZuYihqWN1U1nAYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tK73BcIL; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tK73BcIL" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4957eefd361so19093135e9.1 for ; Mon, 10 Aug 2026 21:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786422595; x=1787027395; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=GMxhp/GgRpaUt1BU0dy/EFJVLwtZvh0sQQllQJR0VqA=; b=tK73BcILKyNZcITzWDMRI/k3r9FASAM3bDpq3iaVqjo6qz9SAeCD90ynus0qPR3ECD Hxn/TDixvGVgpFmqoIavtu9Ey0LrA6dTiOUxtShRlBREm4YRtzVU1Ed5U8DFFzS/KHFj S5xBF7vmkw/G2gFBJ5uOp4amBFrBlToO4/fdwaIEqlvQwsmxHwnC/qYyW0yzTluOa5co gzOAKF9rhLgf/URUcuunX6fnDp4pwdIIAmeqIQa76h8+MOpOv42m3xTWxZ1Vf9mwB1uB ZQvyG1RviLG7ejXGNMT0y+CeNtyXDFZatIWRWfs5dZsaRu5q9wiJmEB1omrt8zCNkFg8 /wyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786422595; x=1787027395; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GMxhp/GgRpaUt1BU0dy/EFJVLwtZvh0sQQllQJR0VqA=; b=sGrDz2x4pSWxcDPiVNrD+AGq8e5a7yyeUIDeECVITM+TznkSMETaL4veQ7O4m4XSuh uAO81Q+v1KaI16tX2SZvJD63EGYuFaxGauUiV0pC76aAFRLTggw8z/QBj8+FJsmBT1Yy F5GOFDtW6BKLUBdyA4hm8ZzPZ6iklnCQZKuYaPJlZxpfMgsYFCFfH5G+aVIttb4EDPSL 6KjpolY/KNKAgbA379bLtwxk6f/0UbWf7zRBr1HC5R/tgovPDK8SGHECBP8d5u+Kv5Ri lPrRNFyMhAk9bc2Sruc+7WglWz1Jnc7p4EL75Dif7b95o4JQqxlcl8cdViCLBdQtgFtw lwGg== X-Forwarded-Encrypted: i=1; AHgh+RoGKeJgdNZHu/NuFz+QqTbmMKkml+DLyIumNi3+geO6y1/7po8uAX9q5cjy+oOt92xh/eb15QvgxTROO6k=@vger.kernel.org X-Gm-Message-State: AOJu0YziO7wMKoprz+3LbAjK48cOrGe9A1WobD7IqAL4UrywYTrZoZrw 2q1o3ER9un1n1pwMf49r9lnyPpKC5cTQJUfgBgcF/IgbQyCKJANI5abM X-Gm-Gg: AR+sD106mDx+frX7c8r7gS9J+LK1Ixq7he6qkEtnta8dZcKWCPPRQynScn72GMO4IP6 rzr4JEHhYfuUSX7Tct9H29ZjI8djqtNZE+uqJYKYqcQ5iMJe2LyoyPanvMsJrdtV/WJvRa3S9Im bIn8mSN+/Y/zQnfe7chuawj7vZfnjTXA0apS6DToxRVFQi+SKo5sAz7Hb5mbF2arNorx91xrIsz QSgssOgf5YLTWw2tQxfFCAKrCOwrts666gcA48109DJbTdyJgquwiqVjGrFatydqBwhZYVNu5fP YCFnIqsAGTj4yLDmFkJ9iYV00NnrY0qNyVk2FtFCqoPHNuk0Qosr9JLWP2lU9OWQTPHFUin5MU9 1FmCtVGb5Z4HOMPaIiaXAkHxB+ObjEIJpWDDxqgqIErrIfCRm3vcq2+MtjSRlNAtnNmcZCDDNku uWYLWAaM5N8MNWlR7lGlW2sWeuKCwe8IdImOY5/YBFeam8NQWTFy15fxuKFVnCPZhINEu9BNk1m C9tja9LLD6sWUAZIgIrgS4VdMq4 X-Received: by 2002:a05:600c:3553:b0:499:7312:2d5f with SMTP id 5b1f17b1804b1-49978494c8cmr6635375e9.19.1786422595138; Mon, 10 Aug 2026 21:29:55 -0700 (PDT) Received: from localhost ([77.237.184.247]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49977e5ace7sm13777145e9.2.2026.08.10.21.29.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 21:29:53 -0700 (PDT) Date: Tue, 11 Aug 2026 07:59:47 +0330 From: Ali Nasrollahi To: Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mchehab@kernel.org, Frank.Li@nxp.com, hverkuil+cisco@kernel.org, guoniu.zhou@oss.nxp.com Subject: Re: [PATCH] media: v4l2-core: make number of video devices configurable Message-ID: References: <20260810162406.118981-2-A.Nasrolahi01@gmail.com> <20260810162858.GA3012183@killaraus.ideasonboard.com> <20260811040459.GE3046075@killaraus.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260811040459.GE3046075@killaraus.ideasonboard.com> On 26/08/11 07:04AM, Laurent Pinchart wrote: > On Tue, Aug 11, 2026 at 07:29:36AM +0330, Ali Nasrollahi wrote: > > On 26/08/10 07:28PM, Laurent Pinchart wrote: > > > On Mon, Aug 10, 2026 at 07:54:07PM +0330, Ali Nasrollahi wrote: > > > > The V4L2 core currently limits the number of registered video devices to > > > > 256. This can become a restriction for workloads that create a large > > > > number of virtual video devices, such as v4l2loopback instances. > > > > > > We don't support v4l2loopback upstream though. > > > > Yes, you are correct. > > > > But perhaps my description was a bit misleading. The main idea of this > > patch is not to support out-of-tree modules by any means, but to allow a > > configurable number of V4L2 devices to be created and used, whether > > through loopback devices or other means. > > Do you have a use case where you're reaching the limit without > out-of-tree drivers ? > My workloads depend on loopback devices which is how I've reached the limit, however I haven't had a usecase with a such number of deivces through physical hardware. > > > > Make the maximum number of video devices configurable through a module > > > > parameter. The default and minimum remain at the existing limit of 256, > > > > while the maximum is capped at 4096. > > > > > > > > The parameter is only available when CONFIG_VIDEO_FIXED_MINOR_RANGES is > > > > disabled, as the fixed minor allocation scheme relies on the existing > > > > minor ranges. > > > > > > > > The device array is allocated according to the configured limit, while > > > > the allocation bitmaps remain statically sized to the maximum supported > > > > limit of 4096. > > > > > > > > Signed-off-by: Ali Nasrollahi > > > > --- > > > > drivers/media/v4l2-core/v4l2-dev.c | 70 +++++++++++++++++++++++------- > > > > 1 file changed, 55 insertions(+), 15 deletions(-) > > > > > > > > diff --git a/drivers/media/v4l2-core/v4l2-dev.c b/drivers/media/v4l2-core/v4l2-dev.c > > > > index fd267fb74905..5a526b577970 100644 > > > > --- a/drivers/media/v4l2-core/v4l2-dev.c > > > > +++ b/drivers/media/v4l2-core/v4l2-dev.c > > > > @@ -31,7 +31,8 @@ > > > > #include > > > > #include > > > > > > > > -#define VIDEO_NUM_DEVICES 256 > > > > +#define VIDEO_MIN_NUM_DEVICES 256 > > > > +#define VIDEO_MAX_NUM_DEVICES 4096 > > > > #define VIDEO_NAME "video4linux" > > > > > > > > #define dprintk(fmt, arg...) do { \ > > > > @@ -39,6 +40,27 @@ > > > > __func__, ##arg); \ > > > > } while (0) > > > > > > > > +static unsigned int video_nr_devices = VIDEO_MIN_NUM_DEVICES; > > > > + > > > > +#ifndef CONFIG_VIDEO_FIXED_MINOR_RANGES > > > > +static int param_set_video_nr_devices(const char *val, > > > > + const struct kernel_param *kp) > > > > +{ > > > > + return param_set_uint_minmax(val, kp, VIDEO_MIN_NUM_DEVICES, > > > > + VIDEO_MAX_NUM_DEVICES); > > > > +} > > > > + > > > > +static const struct kernel_param_ops param_ops_video_nr_devices = { > > > > + .set = param_set_video_nr_devices, > > > > + .get = param_get_uint, > > > > +}; > > > > + > > > > +module_param_cb(video_nr_devices, ¶m_ops_video_nr_devices, > > > > + &video_nr_devices, 0444); > > > > + > > > > +MODULE_PARM_DESC(video_nr_devices, "Maximum number of V4L2 devices (256-4096)"); > > > > +#endif > > > > + > > > > /* > > > > * sysfs stuff > > > > */ > > > > @@ -98,9 +120,14 @@ static struct dentry *v4l2_debugfs_root_dir; > > > > /* > > > > * Active devices > > > > */ > > > > -static struct video_device *video_devices[VIDEO_NUM_DEVICES]; > > > > +#ifdef CONFIG_VIDEO_FIXED_MINOR_RANGES > > > > +static struct video_device *video_devices[VIDEO_MIN_NUM_DEVICES]; > > > > +static DECLARE_BITMAP(devnode_nums[VFL_TYPE_MAX], VIDEO_MIN_NUM_DEVICES); > > > > +#else > > > > +static struct video_device **video_devices; > > > > +static DECLARE_BITMAP(devnode_nums[VFL_TYPE_MAX], VIDEO_MAX_NUM_DEVICES); > > > > +#endif > > > > static DEFINE_MUTEX(videodev_lock); > > > > -static DECLARE_BITMAP(devnode_nums[VFL_TYPE_MAX], VIDEO_NUM_DEVICES); > > > > > > > > /* Device node utility functions */ > > > > > > > > @@ -504,7 +531,7 @@ static const struct file_operations v4l2_fops = { > > > > * in the video_device array, but it was able to obtain a minor number. > > > > * > > > > * This means that we can always obtain a free stream index number since > > > > - * the worst case scenario is that there are VIDEO_NUM_DEVICES - 1 slots in > > > > + * the worst case scenario is that there are video_nr_devices - 1 slots in > > > > * use of the video_device array. > > > > * > > > > * Returns a free index number. > > > > @@ -513,19 +540,19 @@ static int get_index(struct video_device *vdev) > > > > { > > > > /* This can be static since this function is called with the global > > > > videodev_lock held. */ > > > > - static DECLARE_BITMAP(used, VIDEO_NUM_DEVICES); > > > > + static DECLARE_BITMAP(used, VIDEO_MAX_NUM_DEVICES); > > > > int i; > > > > > > > > - bitmap_zero(used, VIDEO_NUM_DEVICES); > > > > + bitmap_zero(used, VIDEO_MAX_NUM_DEVICES); > > > > > > > > - for (i = 0; i < VIDEO_NUM_DEVICES; i++) { > > > > + for (i = 0; i < video_nr_devices; i++) { > > > > if (video_devices[i] != NULL && > > > > video_devices[i]->v4l2_dev == vdev->v4l2_dev) { > > > > __set_bit(video_devices[i]->index, used); > > > > } > > > > } > > > > > > > > - return find_first_zero_bit(used, VIDEO_NUM_DEVICES); > > > > + return find_first_zero_bit(used, video_nr_devices); > > > > } > > > > > > > > #define SET_VALID_IOCTL(ops, cmd, op) \ > > > > @@ -915,7 +942,7 @@ int __video_register_device(struct video_device *vdev, > > > > int i = 0; > > > > int ret; > > > > int minor_offset = 0; > > > > - int minor_cnt = VIDEO_NUM_DEVICES; > > > > + int minor_cnt = video_nr_devices; > > > > const char *name_base; > > > > > > > > /* A minor value of -1 marks this video device as never > > > > @@ -1020,10 +1047,10 @@ int __video_register_device(struct video_device *vdev, > > > > #else > > > > /* The device node number and minor numbers are independent, so > > > > we just find the first free minor number. */ > > > > - for (i = 0; i < VIDEO_NUM_DEVICES; i++) > > > > + for (i = 0; i < video_nr_devices; i++) > > > > if (video_devices[i] == NULL) > > > > break; > > > > - if (i == VIDEO_NUM_DEVICES) { > > > > + if (i == video_nr_devices) { > > > > mutex_unlock(&videodev_lock); > > > > pr_err("could not get a free minor\n"); > > > > return -ENFILE; > > > > @@ -1032,7 +1059,7 @@ int __video_register_device(struct video_device *vdev, > > > > vdev->minor = i + minor_offset; > > > > vdev->num = nr; > > > > > > > > - if (WARN_ON(vdev->minor >= VIDEO_NUM_DEVICES)) { > > > > + if (WARN_ON(vdev->minor >= video_nr_devices)) { > > > > mutex_unlock(&videodev_lock); > > > > return -EINVAL; > > > > } > > > > @@ -1241,7 +1268,7 @@ static int __init videodev_init(void) > > > > int ret; > > > > > > > > pr_info("Linux video capture interface: v2.00\n"); > > > > - ret = register_chrdev_region(dev, VIDEO_NUM_DEVICES, VIDEO_NAME); > > > > + ret = register_chrdev_region(dev, video_nr_devices, VIDEO_NAME); > > > > if (ret < 0) { > > > > pr_warn("videodev: unable to get major %d\n", > > > > VIDEO_MAJOR); > > > > @@ -1250,11 +1277,21 @@ static int __init videodev_init(void) > > > > > > > > ret = class_register(&video_class); > > > > if (ret < 0) { > > > > - unregister_chrdev_region(dev, VIDEO_NUM_DEVICES); > > > > + unregister_chrdev_region(dev, video_nr_devices); > > > > pr_warn("video_dev: class_register failed\n"); > > > > return -EIO; > > > > } > > > > > > > > +#ifndef CONFIG_VIDEO_FIXED_MINOR_RANGES > > > > + video_devices = kzalloc_objs(*video_devices, video_nr_devices); > > > > + if (!video_devices) { > > > > + class_unregister(&video_class); > > > > + unregister_chrdev_region(dev, video_nr_devices); > > > > + pr_warn("video_dev: failed to allocate video_devices\n"); > > > > + return -ENOMEM; > > > > + } > > > > +#endif > > > > + > > > > return 0; > > > > } > > > > > > > > @@ -1262,8 +1299,11 @@ static void __exit videodev_exit(void) > > > > { > > > > dev_t dev = MKDEV(VIDEO_MAJOR, 0); > > > > > > > > +#ifndef CONFIG_VIDEO_FIXED_MINOR_RANGES > > > > + kvfree(video_devices); > > > > +#endif > > > > class_unregister(&video_class); > > > > - unregister_chrdev_region(dev, VIDEO_NUM_DEVICES); > > > > + unregister_chrdev_region(dev, video_nr_devices); > > > > debugfs_remove_recursive(v4l2_debugfs_root_dir); > > > > v4l2_debugfs_root_dir = NULL; > > > > } > > -- > Regards, > > Laurent Pinchart