From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: 楊智成 <jason98166@gmail.com>
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@kernel.org>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
stable+noautosel@kernel.org
Subject: Re: [PATCH] media: ov5640: select the MIPI lane mode from the endpoint lane count
Date: Tue, 11 Aug 2026 10:22:11 +0300 [thread overview]
Message-ID: <anrNowQWOaCkh4W1@kekkonen.localdomain> (raw)
In-Reply-To: <CAPwA33LJsSr3w_Vfc6wd7VXNBW2fjrn2zaVxDGB_RfJ-FRrdHg@mail.gmail.com>
Hi Jason,
On Tue, Aug 11, 2026 at 03:18:01PM +0800, 楊智成 wrote:
> Hi Sakari,
>
> Thanks for the review.
>
> > I guess there wouldn't be harm from backporting either.
>
> Agreed, switched to a plain stable Cc.
>
> > How about:
> >
> > ret = ov5640_write_reg(sensor, OV5640_REG_IO_MIPI_CTRL00,
> > on ? 0x5 | ep.bus.mipi_csi2.num_data_lanes << 5 :
> > 0x40);
>
> Nicer, thanks - applied, with the lane count in a local variable to
> stay within 80 columns.
There's no need for a local variable, the above remains within 80 columns.
--
Sakari Ailus
next prev parent reply other threads:[~2026-08-11 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 4:40 Jason Yang via B4 Relay
2026-08-11 5:54 ` Sakari Ailus
2026-08-11 7:18 ` 楊智成
2026-08-11 7:22 ` Sakari Ailus [this message]
2026-08-11 7:30 ` 楊智成
2026-08-11 8:42 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anrNowQWOaCkh4W1@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jason98166@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=stable+noautosel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®