From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F74D425CEE for ; Tue, 11 Aug 2026 12:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786453104; cv=none; b=kSiaSlZufDMuZrHiaQPguM6yybbOg++/utqx+WOfn1vgqkw80g9EiolEg/MOIBihcZIFOx4qRW/cJp7uOIgwMfHFPRA/ppGzr19VSbUBxTIUtpm2av3hsUdjgziH4uEzjRuJLL7l/7bFJxyXUAIpZAmOCMPiFIauLO/Vxprqm+k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786453104; c=relaxed/simple; bh=JS1/e3NtMBcOe49UexsetxgejmOuLNrBnRooyabTsJQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fIQEZYWjAQ9CY1/RffPnXcftFeQHo/n1VqyQSHE+casgqSLAF/9PeOq/GbWjS/bGwVaAG0Ggi5ik0MO2pJ3qDu7TFf/3hZ+jQTHkYDzaHxuSkZmdY2FuTq4PrM9ygCHTdP0yahPXm/0YtXjSkG9uVmOq+mIIrfccRsptm+SdqtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Yj1CKiSk; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Yj1CKiSk" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-49556f97a9dso20768485e9.1 for ; Tue, 11 Aug 2026 05:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1786453101; x=1787057901; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wadoVsDULYZYXWQe9At0Wixp1lsixD+0O8hIBiY/5QA=; b=Yj1CKiSkpv5GHWZuelmXs/kKq+9bGIXQ6UHDM/Feyhy5LM7CA/DLo4DQRFPEKzlmuu +dmby/6aYbcZNKwcDVQiPyGGh+QwhQtAAQykKnTp+yOYfw/gftPxfnpZepJ6TbkXiEgs PAFb3wE8DJDhE21Vuy4VpqHPEOtuj/AnzQZ4XdNLE/TJiNPFBmPWjXjsqnMVJu7vzsrl 2GkMcETyDtJ4LGBhNe8VfYWac/3IGumQx7JnG05Leavfu67Epzp0SzqTNUm+LMOPfknL T/QVRPUXFwuoZO4pravHj/maRo6eKMyMtm2HueLIDcsD1VebR+M75JIf9Zspx2LCLRKm +T+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786453101; x=1787057901; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wadoVsDULYZYXWQe9At0Wixp1lsixD+0O8hIBiY/5QA=; b=KqZbUus9Hjp1hP1+a6YFD3VLi0tI4LllfqdzPTL23XaB1fcN773pMTYo4Sh/dVKVWH MDYjcVEDP1hvGiyE+WzN/zT59JU1HA11u3ZyPso3lAPJMo2QrmxqvfpHZ/oUxmU8/rM5 tM36FntjnirETmT+QHuu3kTWYyzEkqAolo9rjyRnPik9cTvLRqu61M4ZBO/OwULjSRqy 34Ig5Jj3br6SA+uvLBrcesQy8RZ/JRbhs9eNwjPEp48cieGaTcABACZ5IC6NiPDX0Nm5 789AVYe7CMclDdcI7ASb4W8FHr7EmsRyeUcX7Wp3+clXjxvDdkFjBoPyNTNdxokHr4ub FktQ== X-Forwarded-Encrypted: i=1; AHgh+RrWMniJIZTI59IxaFsDTpy7iqKR54QLpIPwcF9gDZFQeBKtps49JAgfVinF4+RzWigEPItR7EdnU8fO0tY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3mFc+7I0jdN5L9uTZArTvhih3C9nIkdfMsY9HnOt72MoxXZ14 ncT49cu9XiCSE6hWaYxGtvQn2qVvPWgtx1Blj2mUUGAz81SPyC1vF/6TVx+sKhIM2Gc= X-Gm-Gg: AR+sD10VaP2OgzeW63vEdglqeEsjOHvgguO6DOLSggma2gD09vv7BX7C3YcHQZVgCCD 6hk84DgZqSMohq44Dp4S9E3Q/oECMKGoxNHQDAZGf5uJmU+R6wdLtgOFfTgUrVjek2CDKaqjiy6 S54ZDR1JYJDsYPA5sxPg1oLmtlE3AS6Ib/yeMk/fCXNpkj9DLQ+MzLQ5cSVCRI9QdTNMdXthRRa 8o1jGuyHuX5nsP7j7StkiUTV11o3MhXz/r+yq8RCk0/2nODJkY4gfniCjO9dYcplwFDx/WNXV8h 7bhEObu2KP7Qt7x5yYt1nlnFtG01byEvg/nvd1PCclGZDBc4MI1GGMh45Bx6lWfkymf3AMkoBRm x1X0ad5HZCjgsae7DfMpg0pb0uPbYl0l0q0xvwtmZKo1DupNuI+cfeXf+rySGzwgWNurcFZse+S HmED+Sv4YxoYuYzeNt6rAPLWh/j8ROifFNcIAgZAwsscuNkbhhcgeLiFzGmeryBTu0JPnCLgU= X-Received: by 2002:a05:600c:3114:b0:495:6e68:5df2 with SMTP id 5b1f17b1804b1-4997844f628mr47773285e9.12.1786453101143; Tue, 11 Aug 2026 05:58:21 -0700 (PDT) Received: from localhost (109-81-91-46.rct.o2.cz. [109.81.91.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499788fd9a4sm53399135e9.12.2026.08.11.05.58.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 05:58:20 -0700 (PDT) Date: Tue, 11 Aug 2026 14:58:19 +0200 From: Michal Hocko To: Ye Liu Cc: Andrew Morton , Ye Liu , David Rientjes , Shakeel Butt , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/oom_kill, proc: replace magic number 1000 with OOM_SCORE_ADJ_MAX Message-ID: References: <20260811033609.3992348-1-ye.liu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260811033609.3992348-1-ye.liu@linux.dev> On Tue 11-08-26 11:36:08, Ye Liu wrote: > From: Ye Liu > > In oom_badness() and proc_oom_score(), the oom_score_adj normalization > uses a hardcoded 1000, which is the value of OOM_SCORE_ADJ_MAX defined > in include/uapi/linux/oom.h. Other code in the kernel (e.g. > fs/proc/base.c oom_adj handling) already uses OOM_SCORE_ADJ_MAX for > the same purpose. > > Replace the magic number with the macro for consistency and > readability. No functional change. > > Signed-off-by: Ye Liu I am not really sure this adds to the readability much TBH but no fundamental objections from me. Acked-by: Michal Hocko > --- > fs/proc/base.c | 3 ++- > mm/oom_kill.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/proc/base.c b/fs/proc/base.c > index 6a39de424f62..58be38942460 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -594,7 +594,8 @@ static int proc_oom_score(struct seq_file *m, struct pid_namespace *ns, > * exporting for a long time so userspace might depend on it. > */ > if (badness != LONG_MIN) > - points = (1000 + badness * 1000 / (long)totalpages) * 2 / 3; > + points = (OOM_SCORE_ADJ_MAX + > + badness * OOM_SCORE_ADJ_MAX / (long)totalpages) * 2 / 3; > > seq_printf(m, "%lu\n", points); > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 5f372f6e26fa..08bff7a55db8 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -230,7 +230,7 @@ long oom_badness(struct task_struct *p, unsigned long totalpages) > task_unlock(p); > > /* Normalize to oom_score_adj units */ > - adj *= totalpages / 1000; > + adj *= totalpages / OOM_SCORE_ADJ_MAX; > points += adj; > > return points; > -- > 2.25.1 -- Michal Hocko SUSE Labs