From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E795446849 for ; Tue, 11 Aug 2026 14:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786458758; cv=none; b=LHMr1Mw7phmZupG0/vsP7JShVKIYcajmbqgjmcWZlw7Fazjz/TA5LlzdDV5uutQ/UFy7BsewYeJJmm/yjYKntCNTT0Ka2KPvjxp5T+cIzkgHzAMjXPtTTtUTAA08rPF992uOYr0EvLKOCvG1P+QLNwWq7spSbNHe06gX+uDLYDc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786458758; c=relaxed/simple; bh=TzEa1puLoNW4MhAQSEKHLP0ds3Wb9UO8eBrgte828Pg=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=No2xnzxfVsdpU5PEk/4cZMDgpYoMLI4xjJ/z3Wb+zN4joNxjEGmBLrXPSadY50BdWbAqmT9kpBEvym1IhKFHJOOkDZwqeTpUkpNr6J9/lwpPTMGFV1bY0I5EYdXyU5opfP78X3hdjYbQWOONjRq9/6B45RBoMT7vgI1hCuJmdO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nn72XMcw; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nn72XMcw" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-49800c6a846so30237155e9.3 for ; Tue, 11 Aug 2026 07:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786458751; x=1787063551; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HYlCOewNL3l2HhIwDF9AzVHy9ppLOSojfQ0hX+V1OZk=; b=nn72XMcwm3651dUcqrHd9pUU/aj8Aiw0+fT7i+JsoFEXPyoPJLfLA6FOe6V0uHCk8k OHXc6npdZHfcfO5JhEJxzjO7PO4Q89dtT86kIXNQXPIQPh3RD+f3atn5purfNsD6KqLK KnHeBFBmEO6RZOIZJl9Xti7X5s7tpMjAQlA7Dn0xt03hdAIY8UPA8kVeaPkCU15Lw217 dGbPQo8nhz4fL8NQc8QiTrrvknyKQzucczi6BLkSqtQJ7MV/l8857W/bvKNOoDfokOv+ uJHJkHZJTP4BLMiVRYnEO+2gN5P4zTcPw0wxYEDOFDCF8/Qsr3i8ZJwaG7qDCurpvzc6 Jmng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786458751; x=1787063551; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HYlCOewNL3l2HhIwDF9AzVHy9ppLOSojfQ0hX+V1OZk=; b=AJRBhqB17LYYbzymFNDG0yo41xX6SQ7zc6BYr8830II0R69JatmdFaavojzdoKUvLM V+wPKRF1RqZmIhbcADq8ZiFKYQapgu/a2bMxfiYwCbs7bKXL40coW9s/ZmEA0sGBKyIa RSVQ9N7cJVTAQmu4Shj+tremC05ytGdF+19nilMZPobRaBf24ODcCx3PKc8HWrK9C/+X RP+P4EOzpn9AzAza+ycAu8AyYFEScU98VI7qO2DYWystwXPtLz2dJV6bI6JSYbdZhUxd U3X+P6/Z59hoeT8mRFxtyPKx8VCF9D1xZCAzE43V/aj41QU60+/9JPnFb20DoJ6xbAfV tz2w== X-Forwarded-Encrypted: i=1; AHgh+Rqpx1M4rldMtK71H9jVKOjatcr1T/7bAsrGFWcRXVt9CV4s+OMDyePsTBIxGCiLXMOe0RJwM+uuNYcoKZM=@vger.kernel.org X-Gm-Message-State: AOJu0YxaxzkZoo6bmNA8llJtPmub/cezGOOG02Fvr+ImzAAf9t+pz0op Z0ySuV4sdzBUPAyvJfhCaaJwmbCLxWV1FXnnbkCuAC93+keQ3tWX7a54 X-Gm-Gg: AR+sD11agkfZhb3U/hOUT12T5eebmxly11U2TreCzsp09aOUUjCUYCJjgW0npofgkiG iMyCTlP3geUyVdTC0FMayCWgXhwHF6oAttTbWACFvxI7wAw/AtKYq8rCJhxdfA7z8+NKifYgwdZ zfeJI/HcOALrhQwzKltEK6Kx9H191VeA+VOnTD7ZF39St88EednnxYAmWD+VQK69hiO9Od4kBA5 YEPrF2JIAy/gbYvlR2JrI0g7a1Mfoh+KG2kThikiqr5cfxYoUZ8ThFSXdOOtTle2c2aigaJNiFe NEWjYHCF5Xs/WaIw3XbLpeP4XowwM87vsMLI3fMC8Kr/Hz2jXegobgypOgHS/pXvFYxHxjVc6hs etnW1CwBkm7gkSL5QHd2ja3LhkEyg5T7O/Rwp4MoSIr7dLKppMp4hxr1qSzHxRkQF6ravY4POOQ 964xFJaHnTpoc7GJ1wTUPrkYyePgzZRGd97rUUurCq93StJtaW5K2K5Lw7gE190hRf0vaW1LKCO uIQfgziIQhLrSUgvbUq9g== X-Received: by 2002:a05:600c:8b4c:b0:499:593c:3384 with SMTP id 5b1f17b1804b1-49978434835mr60014535e9.6.1786458750690; Tue, 11 Aug 2026 07:32:30 -0700 (PDT) Received: from osama ([2a02:908:185:7e40:b0cf:778:ae86:13b1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499788fd9a4sm62325695e9.12.2026.08.11.07.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 07:32:30 -0700 (PDT) Date: Tue, 11 Aug 2026 16:32:28 +0200 From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Jagan Teki , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge: chipone-icn6211: use devm_mipi_dsi_attach Message-ID: References: <20260521212529.151493-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260521212529.151493-1-osama.abdelkader@gmail.com> On Thu, May 21, 2026 at 11:25:28PM +0200, Osama Abdelkader wrote: > Follow up on the previous devm_drm_bridge_add() conversion by > converting the remaining manual cleanup in chipone-icn6211 to the > managed helper. > > Suggested-by: Luca Ceresoli > Signed-off-by: Osama Abdelkader > --- > drivers/gpu/drm/bridge/chipone-icn6211.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c > index e5957917ad88..d51d770060b6 100644 > --- a/drivers/gpu/drm/bridge/chipone-icn6211.c > +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c > @@ -531,7 +531,7 @@ static int chipone_dsi_attach(struct chipone *icn) > dsi->hs_rate = 500000000; > dsi->lp_rate = 16000000; > > - ret = mipi_dsi_attach(dsi); > + ret = devm_mipi_dsi_attach(dev, dsi); > if (ret < 0) > dev_err(icn->dev, "failed to attach dsi\n"); > > @@ -761,11 +761,6 @@ static int chipone_i2c_probe(struct i2c_client *client) > return chipone_dsi_host_attach(icn); > } > > -static void chipone_dsi_remove(struct mipi_dsi_device *dsi) > -{ > - mipi_dsi_detach(dsi); > -} > - > static const struct of_device_id chipone_of_match[] = { > { .compatible = "chipone,icn6211", }, > { /* sentinel */ } > @@ -774,7 +769,6 @@ MODULE_DEVICE_TABLE(of, chipone_of_match); > > static struct mipi_dsi_driver chipone_dsi_driver = { > .probe = chipone_dsi_probe, > - .remove = chipone_dsi_remove, > .driver = { > .name = "chipone-icn6211", > .of_match_table = chipone_of_match, > -- > 2.43.0 > ping.