From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A6B44C65F for ; Tue, 11 Aug 2026 16:09:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786464541; cv=none; b=B1WYEruTaMylqjex3aXiBywXiHX4uxymQo2cKBR4Q+G3jw4yl/u/M1GRELCIZrJIwadrVgF7dLvLPa5sjYE9RGyqBI174SCY9Ob0xq8JIe0QHwEKGXXw0eLI1qllwnaNhMaraI/I5vSQt0mAiNHhf6KYFONf4DBKYbsdimvF/7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786464541; c=relaxed/simple; bh=MnU5KaBb6FaDZX9IlJcYbY14eq2bqK2HMKqs8JeJFR8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nT56Ay2sJdvRKk+gh9nauuULDpWyBZ478ry/ldNUw3Jd67wMiTVJYvPPSuvyKk64wgyZ+AnV0s0GyXRH4opxzC9EYDKwNlguyYFq14rmAYrP/ea7NOFpedjxldmw1Yqj6zhfBvwGfy1mZPZXuwfx/RtWzBlPxWTKwlb89KbEzuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UAMJWAnM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UAMJWAnM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57F541F000E9; Tue, 11 Aug 2026 16:09:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786464540; bh=cdC4wErGTkONUcIl8hOF5mRnRetlc8d4tXIPMMFvIhM=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=UAMJWAnMz5054y29ifZ8D4QGTeqzSTsMF+giOHOoDT9zQe4lnZGGnGN+o47gzJ5Kg RsYvx/whTgVGLo1BH7bKXQkcWb6Y2Hy7p5k8l4xnka+upaRNpzPSQRHbxgmUkoHbHs Jn6uW/wAs2CRwW36VRi2Z4aYM+soQ2Y5I6YspMcw+woiLVxiGH4Cux8rEHy7zQZIpK MhH02v2LUv8GkBOKoVDEwIoKVQYW9UXXKPHTYlhi3B87PkJN4XALFvIbOZ1nLl3FBj zattpBkZVUqCdryK4ZzX9twazfFEYH9uUBaLKw46AFLt7sCaqSsdJ02dejA7Z5GCmD XnX5j4rGiQNxA== Date: Tue, 11 Aug 2026 10:08:58 -0600 From: Keith Busch To: guzebing Cc: axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Guzebing Subject: Re: [PATCH v4] nvme: reduce firmware activation poll interval Message-ID: References: <20260728121735.1627370-1-guzebing1612@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260728121735.1627370-1-guzebing1612@gmail.com> On Tue, Jul 28, 2026 at 08:17:35PM +0800, guzebing wrote: > +static int nvme_wait_csts(struct nvme_ctrl *ctrl, u32 mask, u32 val, > + unsigned long timeout, bool exit_if_ctrl_disabled, > + u32 *csts) > { > - unsigned long timeout_jiffies = jiffies + timeout * HZ; > - u32 csts; > int ret; > > - while ((ret = ctrl->ops->reg_read32(ctrl, NVME_REG_CSTS, &csts)) == 0) { > - if (csts == ~0) > + while ((ret = ctrl->ops->reg_read32(ctrl, NVME_REG_CSTS, csts)) == 0) { > + if (*csts == ~0) > return -ENODEV; > - if ((csts & mask) == val) > - break; > + if (exit_if_ctrl_disabled && > + !(ctrl->ctrl_config & NVME_CC_ENABLE)) > + return 0; > + if ((*csts & mask) == val) > + return 0; > > usleep_range(1000, 2000); > if (fatal_signal_pending(current)) > return -EINTR; > - if (time_after(jiffies, timeout_jiffies)) { > - dev_err(ctrl->device, > - "Device not ready; aborting %s, CSTS=0x%x\n", > - op, csts); > - return -ENODEV; > - } > + if (time_after(jiffies, timeout)) > + return -ETIMEDOUT; Mostly looks fine, though I was hoping to converge a little more commonality among these functions. I folded some minor changes in when applying, so please have a look at the current git tree to see if the result is okay.